From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934383AbcHDV6P (ORCPT ); Thu, 4 Aug 2016 17:58:15 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:40412 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934038AbcHDV6M (ORCPT ); Thu, 4 Aug 2016 17:58:12 -0400 Subject: Re: [PATCH v3 2/4] rtc: rtc-pm8xxx: Add support for pm8018 rtc To: Neil Armstrong , andy.gross@linaro.org, david.brown@linaro.org, lee.jones@linaro.org, lgirdwood@gmail.com, broonie@kernel.org, a.zummo@towertech.it, alexandre.belloni@free-electrons.com References: <1468936286-2710-1-git-send-email-narmstrong@baylibre.com> <1468936286-2710-3-git-send-email-narmstrong@baylibre.com> Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org, rtc-linux@googlegroups.com From: Stephen Boyd Message-ID: <97671c78-d7ad-9cef-f647-6e7cc8b9234e@codeaurora.org> Date: Thu, 4 Aug 2016 14:58:09 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <1468936286-2710-3-git-send-email-narmstrong@baylibre.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/19/2016 06:51 AM, Neil Armstrong wrote: > diff --git a/drivers/rtc/rtc-pm8xxx.c b/drivers/rtc/rtc-pm8xxx.c > index 795fcbd..976f5f6 100644 > --- a/drivers/rtc/rtc-pm8xxx.c > +++ b/drivers/rtc/rtc-pm8xxx.c > @@ -393,6 +393,16 @@ static int pm8xxx_rtc_enable(struct pm8xxx_rtc *rtc_dd) > return 0; > } > > +static const struct pm8xxx_rtc_regs pm8018_regs = { > + .ctrl = 0x11d, > + .write = 0x11f, > + .read = 0x123, > + .alarm_rw = 0x127, > + .alarm_ctrl = 0x11d, > + .alarm_ctrl2 = 0x11e, > + .alarm_en = BIT(1), > +}; This is the same as pm8921_regs, so why do we need to duplicate it? Can't we point the new compatible at the same data? -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project