From: Markus Elfring <Markus.Elfring@web.de>
To: Shunxi Zhang <ot_shunxi.zhang@mediatek.com>,
linux-mediatek@lists.infradead.org,
linux-arm-kernel@lists.infradead.org, linux-rtc@vger.kernel.org,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Angelo Gioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Lee Jones <lee@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] rtc: mediatek: Add mt6685 RTC driver
Date: Thu, 31 Oct 2024 20:50:36 +0100 [thread overview]
Message-ID: <976d64da-d6e3-4bd9-af57-d475d9939410@web.de> (raw)
In-Reply-To: <20241031135807.31605-1-ot_shunxi.zhang@mediatek.com>
Please add a change description.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.12-rc5#n45
…
> +++ b/drivers/rtc/rtc-mt6685.c
> @@ -0,0 +1,1456 @@
…
> +static void power_on_mclk(struct mt6685_rtc *rtc)
> +{
> + mutex_lock(&rtc->clk_lock);
…
> + mdelay(1);
> + mutex_unlock(&rtc->clk_lock);
> +}
…
Under which circumstances would you become interested to apply a statement
like “guard(mutex)(&rtc->clk_lock);”?
https://elixir.bootlin.com/linux/v6.12-rc5/source/include/linux/mutex.h#L201
Regards,
Markus
prev parent reply other threads:[~2024-10-31 19:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-31 13:58 [PATCH 1/1] " shunxi zhang
2024-10-31 15:58 ` Krzysztof Kozlowski
2024-10-31 16:05 ` Krzysztof Kozlowski
2024-12-27 10:44 ` Shunxi Zhang (章顺喜)
2024-10-31 15:59 ` Krzysztof Kozlowski
2024-10-31 17:24 ` Alexandre Belloni
2024-10-31 19:50 ` Markus Elfring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=976d64da-d6e3-4bd9-af57-d475d9939410@web.de \
--to=markus.elfring@web.de \
--cc=alexandre.belloni@bootlin.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=lee@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-rtc@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=ot_shunxi.zhang@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®