From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EEFA3C6FD1F for ; Sun, 19 Mar 2023 22:23:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230323AbjCSWXG convert rfc822-to-8bit (ORCPT ); Sun, 19 Mar 2023 18:23:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45096 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229913AbjCSWXD (ORCPT ); Sun, 19 Mar 2023 18:23:03 -0400 Received: from eu-smtp-delivery-151.mimecast.com (eu-smtp-delivery-151.mimecast.com [185.58.85.151]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 40D68199CC for ; Sun, 19 Mar 2023 15:23:00 -0700 (PDT) Received: from AcuMS.aculab.com (156.67.243.121 [156.67.243.121]) by relay.mimecast.com with ESMTP with both STARTTLS and AUTH (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id uk-mta-140-WJhT8J87NxWDAFRzzQ3bHA-1; Sun, 19 Mar 2023 22:22:57 +0000 X-MC-Unique: WJhT8J87NxWDAFRzzQ3bHA-1 Received: from AcuMS.Aculab.com (10.202.163.6) by AcuMS.aculab.com (10.202.163.6) with Microsoft SMTP Server (TLS) id 15.0.1497.47; Sun, 19 Mar 2023 22:22:54 +0000 Received: from AcuMS.Aculab.com ([::1]) by AcuMS.aculab.com ([::1]) with mapi id 15.00.1497.047; Sun, 19 Mar 2023 22:22:54 +0000 From: David Laight To: 'Yangtao Li' , Greg Kroah-Hartman , "Rafael J. Wysocki" CC: "linux-kernel@vger.kernel.org" Subject: RE: [PATCH] kobject: introduce kobject_del_and_put() Thread-Topic: [PATCH] kobject: introduce kobject_del_and_put() Thread-Index: AQHZWdaa1t3AZT1o5E2PbH2WKRjqYq8CrpJQ Date: Sun, 19 Mar 2023 22:22:54 +0000 Message-ID: <97711a466efa4353bb924b30cc52d7fa@AcuMS.aculab.com> References: <20230318201640.63238-1-frank.li@vivo.com> In-Reply-To: <20230318201640.63238-1-frank.li@vivo.com> Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.202.205.107] MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: aculab.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Yangtao Li > Sent: 18 March 2023 20:17 > > There are plenty of using kobject_del() and kobject_put() together > in the kernel tree. This patch wraps these two calls in a single helper. But why? You are adding an extra function call for no benefit. At best, perhaps, a static inline function. David ... > +void kobject_del_and_put(struct kobject *kobj) > +{ > + kobject_del(kobj); > + kobject_put(kobj); > +} > +EXPORT_SYMBOL_GPL(kobject_del_and_put); > + > static void dynamic_kobj_release(struct kobject *kobj) > { > pr_debug("kobject: (%p): %s\n", kobj, __func__); > @@ -874,8 +888,7 @@ void kset_unregister(struct kset *k) > { > if (!k) > return; > - kobject_del(&k->kobj); > - kobject_put(&k->kobj); > + kobject_del_and_put(&k->kobj); > } > EXPORT_SYMBOL(kset_unregister); > > -- > 2.35.1 - Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales)