mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Markus Elfring <Markus.Elfring@web.de>
To: Jing Xiangfeng <jingxiangfeng@huawei.com>, linux-scsi@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
	Hannes Reinecke <hare@suse.de>,
	"James E. J. Bottomley" <jejb@linux.ibm.com>,
	"Martin K. Petersen" <martin.petersen@oracle.com>,
	Neerav Parikh <Neerav.Parikh@intel.com>,
	Robert Love <robert.w.love@intel.com>
Subject: Re: [PATCH] scsi: fcoe: add missed kfree() in an error path
Date: Tue, 7 Jul 2020 13:38:25 +0200	[thread overview]
Message-ID: <977e2781-99ed-54c0-27ad-82d768a1c1e6@web.de> (raw)

> fcoe_fdmi_info() misses to call kfree() in an error path.
> Add the missed function call to fix it.

I suggest to use an additional jump target for the completion
of the desired exception handling.


…
> +++ b/drivers/scsi/fcoe/fcoe.c
> @@ -830,6 +830,7 @@ static void fcoe_fdmi_info(struct fc_lport *lport, struct net_device *netdev)
>  		if (rc) {
>  			printk(KERN_INFO "fcoe: Failed to retrieve FDMI "
>  					"information from netdev.\n");
> +			kfree(fdmi);
>  			return;
>  		}

-			return;
+			goto free_fdmi;


How do you think about to apply any further coding style adjustments?

Regards,
Markus

             reply	other threads:[~2020-07-07 11:38 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-07 11:38 Markus Elfring [this message]
2020-07-09  2:11 ` Jing Xiangfeng
2020-07-09  7:22   ` Markus Elfring
2020-07-09 11:08     ` Jing Xiangfeng
  -- strict thread matches above, loose matches on Subject: below --
2020-07-07 10:24 Jing Xiangfeng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=977e2781-99ed-54c0-27ad-82d768a1c1e6@web.de \
    --to=markus.elfring@web.de \
    --cc=Neerav.Parikh@intel.com \
    --cc=hare@suse.de \
    --cc=jejb@linux.ibm.com \
    --cc=jingxiangfeng@huawei.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=robert.w.love@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®