From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753224AbdJGSNT (ORCPT ); Sat, 7 Oct 2017 14:13:19 -0400 Received: from mail-cys01nam02on0075.outbound.protection.outlook.com ([104.47.37.75]:12715 "EHLO NAM02-CY1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753151AbdJGSNQ (ORCPT ); Sat, 7 Oct 2017 14:13:16 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=brijesh.singh@amd.com; Cc: brijesh.singh@amd.com, x86@kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Paolo Bonzini , =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= , Herbert Xu , Gary Hook , Tom Lendacky , linux-crypto@vger.kernel.org Subject: Re: [Part2 PATCH v5 12/31] crypto: ccp: Add Secure Encrypted Virtualization (SEV) command support To: Borislav Petkov References: <20171004131412.13038-1-brijesh.singh@amd.com> <20171004131412.13038-13-brijesh.singh@amd.com> <20171006184951.vq6hlhjanaefizli@pd.tnic> From: Brijesh Singh Message-ID: <97825322-e53b-153f-4208-62b750b9b341@amd.com> Date: Sat, 7 Oct 2017 13:13:07 -0500 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20171006184951.vq6hlhjanaefizli@pd.tnic> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-US X-Originating-IP: [70.112.153.56] X-ClientProxiedBy: BN6PR1201CA0007.namprd12.prod.outlook.com (10.174.238.17) To CY1PR12MB0150.namprd12.prod.outlook.com (10.161.173.20) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 7c222a1c-a55a-4956-0592-08d50daf133b X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(2017030254152)(48565401081)(2017052603199)(201703131423075)(201703031133081)(201702281549075);SRVR:CY1PR12MB0150; X-Microsoft-Exchange-Diagnostics: 1;CY1PR12MB0150;3:/y7bjSc6WZjc9LvSiKNHKkDDqnqryKQpZARGcMwcmIHKwMfAUjgmR/68bFYdEC+8xq+nfBgEzZQRNZAqqFDsJsUXkLhVLs02TfYo56MB6zGNMzMIOKTu4F/JwCc50pGgVSCngHbMciHIeti4DLVoW6vk9h4xFjvQfWJhehu2/JuvTnq5evUxJkaB4yVFQaGto0YWCqQODOPtrdTC94L8L5Z3nzyNM9Ak3uE54vVtg73KsQTy/G6bvMLddm4fOFFw;25:RPEAXYvd8TiPdqlYEGO+z5cQrpTvecr2G0gblE9QlkRkMC5ErzjjwGFzE2B+lCM25UhURrPI3OWfp7mH5ql0begTAiSjf4Vh1uoJyc1ns+ZfBWW5NlxjRmVZut5Jywqx2f0LRLrIjSFpKAbJ+QhhEygrt6Pa/IAy3gGstD+fu4Cf99N4aGke2i0GAXz3UkV7hl3zPAfSGtQeEeC4uHrcCmZfKg+h2EabiaLYHz7jXOAeND7kHU6KpKJnx2ZFcZ90+FfL6Yd1q8KG0WXCJXDI0YpR+eZ9n6KnQHw6ip1LF68Y1hxqeW9M/PBfYaXYdcjl5AuR/mAJ1R+fur0WlowqHQ==;31:UYPXn/rpQW3JkjRM9rTIpkppoxGprakt+epz+AmaDxE5WBHZWmiy9NH/vi7xKwi0od5F5Cj1ga5YXz0jy6L5+K86x4PyFfbjs3JbOvDqW/eAHcPND2czZvjNBs5I5U50IzL5XM+jzFNg6sgFz6WdKPfTcXIqNcjhVTQhQmW4K1NZPuc3hjcCNLCpiSIsL5yP9Dv/qhiH7bE+tfy6+mKelfyGUf+/rOCWRXm7+MyXdq8= X-MS-TrafficTypeDiagnostic: CY1PR12MB0150: X-Microsoft-Exchange-Diagnostics: 1;CY1PR12MB0150;20:lPpbbyEHVo1CsT5/ZVC/LYxe5uRn9Xii9H6b2QPmyYQTmF5FGxr8G4gsLsGvPUw20o+AGRa4AEHQKwTzxG8jdsEGVeTgDxGH+hUq/Pr9QvjfItqYqaAvcQFOdjUfXEWXUiulLGnMwuNYxpIEJyKquSHVaSsiU0PN8h6x9dzun/RVCWTkTgovVIEBbmzqfeqit03K5PIlnrtjWJ8/7d0YH0e17Vbbg2bpI3cdoilWRtcP7hb7TkjNqws0lycfs734arBNdYGiRVp4kv6ls2vRD/xcAT4MjtZNgQknXFUhnDgBjS6HDTuTFotiOOg4SLzpuvBBgf4QXnJV6tKCp5q6zviy7jdnBBHKUSJI8EJ60XDeL/KF0x7ph31y1wQIXtuQ/F84sLb1aBGddtrcBhBvbepku+eIQ5SbEBs76YlaLBiLKCDQ5Fm+5PJeI7KrcgEk8+5mgNh7BUbE/Qp/UQtL1XhEKo87e1/DEJ/u0NWutel7oQM+m1Dt/ADi433EkEQW;4:9dCPBn3Q+xpOLx040yrygwfN4AxibSSj/+wUHSUMgcr6mdt59mNHV4TDZaunIQQj9SoRpr6xu/STdAIpn1gC2+Y6plellxHVpj9gkB1imZN055X0GwTwG6QBETkXMBKi6JuG79nl/tGeye8Lb5kh53+Rpp+sBDzcMsuthZv+WR4b+h5UTN/0d3x86RLiG5wL573rVbytW6VLcexXPe061iKyVIKGTIG4yNTuLig3W026/iNBL5vxfCe6RY3gyBRt X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(3002001)(93006095)(93001095)(100000703101)(100105400095)(10201501046)(6055026)(6041248)(20161123562025)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123560025)(20161123558100)(20161123564025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:CY1PR12MB0150;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:CY1PR12MB0150; X-Forefront-PRVS: 045315E1EE X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6009001)(376002)(346002)(39860400002)(199003)(189002)(24454002)(377454003)(53546010)(6116002)(16526018)(229853002)(101416001)(81166006)(3846002)(478600001)(83506001)(81156014)(106356001)(31696002)(6666003)(6512007)(8676002)(2950100002)(6916009)(33646002)(7736002)(25786009)(54356999)(58126008)(6486002)(316002)(4326008)(36756003)(76176999)(50986999)(54906003)(105586002)(31686004)(66066001)(23676002)(8936002)(6506006)(65956001)(47776003)(6246003)(189998001)(97736004)(53936002)(65806001)(50466002)(5660300001)(2870700001)(64126003)(305945005)(86362001)(2906002)(68736007)(65826007);DIR:OUT;SFP:1101;SCL:1;SRVR:CY1PR12MB0150;H:Brijeshs-MacBook-Pro.local;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtDWTFQUjEyTUIwMTUwOzIzOk9qQTNKdjZ5MmkydmhRM2FDUWl5cllBTGx4?= =?utf-8?B?MStZcWY4Z2o5TnEwbEZJV1lWcXh6ODRvQ0VHa29xdGlDMnJTaXZqbXFwdXFU?= =?utf-8?B?T1BJaFZOblpvMGdEWmxiaVh4SXdpeUMwK0NaM1BGNWpUNkZqbk1TdG9DRDBt?= =?utf-8?B?MldXT0Q5YXVWaXVJbWQ5bXd6aWV6cWprSStqMzFpNzBINzZ5Wnd5KzQvcXlw?= =?utf-8?B?NGxPT1I4OXFsV0pVTm1zdEV0RVRyQ2FGMmVIVTVPZlBFQVk0QW5iR0tjTzU5?= =?utf-8?B?TWJtdWFFTmpLY3Jaci96VEVsamxyWVEvbW9RRTd2RFNRRXdGaVhNdnE2Sm5N?= =?utf-8?B?aWVTZmZuZkkxTFpGMmpQTm1Sc2d0enhnN3pwa2ZYc3VoNmRRTXlxQTVOR2s0?= =?utf-8?B?NndTZEp4UzJXeldCOWZQZTRKaUZxRHZaMEw4TzFKc1NoQWV2cm04M2tXaUVp?= =?utf-8?B?b1BPY2M2cTNjTUdsdUY3ZDdzMkJkWkhjVlR5NDhCTlJlMlgvM3d4TGFjWHdr?= =?utf-8?B?R1o4a0w4RjlOUjFwem9JYkJRVlZhSTF2VUFGYnVnQU4xMVliemhXb1Q5c2Z3?= =?utf-8?B?ZDd3NVd6RnB0aXdpZjNXSnZFa0FRYWtvSHc1SVowQ0doUlY3cm9oTThiS1Ix?= =?utf-8?B?Q1FPR0RnL29KZm1EQU5ObElHcDR0N1lFK3dQRlRFdENZeHFvSkx0UG90MWt0?= =?utf-8?B?Nk1qQTFFQkN0THk4UnlwVEM0aVBwUkN2Y2tsNEd2bytYZXlZcmFhOXNYMHJx?= =?utf-8?B?RFg1a1F4WnV4R1RpTkQwdG8zRC9TM2RsbUpsTWFnTzNwcGxjTW9RSVVyYzZB?= =?utf-8?B?RDd1bG5SdmE1MnI1N0h2dmZSR3c0aUdqeklQM2JadnNnZ0xackVILzE4VE50?= =?utf-8?B?ZGd1WXhSNFBjekNlMWk3TDByRTlDeGRVbnNxem1aVm1oMWxtYm5XYXhoQVF2?= =?utf-8?B?M0hCUHdPMFdNb1hVb3d3R3JMM1Bsdk5BRnBiYUNJeGNzRXYwWkNsNnNCcE9Q?= =?utf-8?B?dkF5eXVmVjFJRkpyZmdWby83S3RNTVpEUWdMbDUwckllSExVemZiNjNSUG84?= =?utf-8?B?Q2hNY2kySHJ3Nk5pWFBTSTVLRlZpS0dHeGJxaG9ub3pyckROSXNyMS9mZXlE?= =?utf-8?B?QkYwZTZFR1MwSnhsNEFuSHF0WTNrUHpSOE42OTQ4aS9UcDd1YktCOWJNb0Nt?= =?utf-8?B?V24zVUdOU1ZPaFNlci9rR0tsWUxuT2V6anVRWnczaWFqQnBhV2JuaElkWEFD?= =?utf-8?B?NHc3RFY1OEw3Rm1JczJGRVV4cUhpUWRIeFh1dSsvSk1BQVBDcE5oUGxvaTRY?= =?utf-8?B?T29zc0lBTk9TZXZNaFQ3ckFEZ2VtemsxeXoybEMwaHhjeWduTzRlTEhkbEZV?= =?utf-8?B?M0UwNkxRY1NtOXhIQnlzZk5sbDhCbXdtS0tZOHFJbG1MTVRtQWV1RWR2T0lH?= =?utf-8?B?WTJscjRLK3N3aXFiUCt0Wmc1bE10RnZEamgvem5KdGl4dEpoaE4vRktmSjRS?= =?utf-8?B?cHNYWFhGOWhqcTBGbWl6K29Oak15RE5yYjk5dG1qQlZIck03VFlkSDhkY2Ro?= =?utf-8?B?VmNiOVJKQVRCQkYzbFUwQkhPTk5jSDF2UnM0RXlaVHJtRERGOVlNTjlIL0NJ?= =?utf-8?B?bi91Y3ZFS2xsVW5xbTBZNkhPTTNIWWQ0cjlLT1ZBRzV1bFdyN2wyaExuaGZG?= =?utf-8?B?cUdXcTluZnRpdGw2L3lDTE5rM20zbFE5ZHlPSjNqU3ZUMlE1d1hTVjJhNGpv?= =?utf-8?B?SmY0cVJtMWw3U05iNVlzQzVPTG9lTXgybGNydDJTQzFPTTVNd29laXgvVE9a?= =?utf-8?B?MTg5anUvOE5RYmdqaGNsemxCV3gxcXdNbnliTHRXb1NzSWc9PQ==?= X-Microsoft-Exchange-Diagnostics: 1;CY1PR12MB0150;6:4hy1hb7R4m5LtqaVWdx0ntIzrbDxQ31d0OwiPkzM3kh+C5YI72hKcwFidTRiIIVpct7dLGsc8LtEzhWIqU3Ba97ng/e0i/7+wOl/+Rrg4DUnxaef9TN6P865LOpMBX0RKJSPPF7plXgZWswJLPn1RP2OQrA1tNlU8EsedWUC2kDCYjt8KoiBKnOdg+o2lTCAg28Fs7EAPlQGqIkUPVLktbaj7zvEz8ZKBAKmPKlRxvoONzPYV2CYdJvw96Z1TJUBy8CXd4p0vx3CfefHiz7p/5FYhWkKSbmZypqpbiYBCmroiiEXs0JyGuWB2FbB1SAj5/HS1WrMhpOtwufsuRMi1A==;5:AxceZomKRWnm+UYn48WfDCPKWAn5P63xmVIPddHmRjc2ezKnb5aD0CZ70IQivIvXUY3uqVeDMkja3l/5rUNZ6IXGivq22eJIyc3UYsbe/Wjee9nj44dVRnOzr8FgVJgQUS4tWHHOajGo7zE/yOKvDmy9ADHD56cJahECSEd31EA=;24:Uujhn7H7hn8YPHMueWp/D95V0y1MW2QVKfVkTPhJzCroHYv9ZsXVL8DRVymwZKDZKdbDpImZz4I8Meqnf1ueBmgVUC/z7LzQFgHH1qGve9g=;7:KiY4pmG9fiRCshV/mNgWtvZtufhXFjv7+kh5gRPSOfA/wdiTa8IVFL8NNWY25eeKn/MVDGbSQhMHSRdTdgTlSJIy/j34qHE/zARVF60ojZoQoDInL86u4Htdu4SBxafJ/0iZgrt89tW5RrV5DWvYcCjvydlLXKXxlq3Qwd8fZS2pk0+MFXFRJ2Vko+dqoIHvwiVHhFsWA9ies+OlDwumWDQ8ZbKb6LXRX6QpECoQeT8= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;CY1PR12MB0150;20:WE7DNBhw7e9+ogrBDx7p3H9C7rPXXvyXBkZliiXBJ6EoVScCC28s6NNP/ZLyR/ViME+HfUj2Yhl9K1I2sVunjClYcAkxSur4rN09SsNo2FD7/TXLgLjmhje3FoWV//a5i4U5JamIqxFrRByt/PwWsvSC7Kvg4iSSk20/2WUjdCfaO8c802GGcSGWPmzHGnNd+pGts3N879ae5t/hruRCkyZMZZEjlpvD+NBD7pqxqaVnOTGzJ8ObwV9+rMBh3bdu X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Oct 2017 18:13:11.8835 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR12MB0150 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/6/17 1:49 PM, Borislav Petkov wrote: ... >> +static int sev_wait_cmd_ioc(struct psp_device *psp, unsigned int *reg) >> +{ >> + psp->sev_int_rcvd = 0; >> + >> + wait_event(psp->sev_int_queue, psp->sev_int_rcvd); > What happens if the command times out and it never sets psp->sev_int_rcvd? Sorry i missed replying on this comment.  We should not run into cases where after issuing PSP command we do not get an interrupt. I would prefer to avoid adding the timeout value. At least so far in all my runs I have not came across this situation but it can happen ;).  The tricky part is, what should be the default timeout value. Depending on the user inputs some commands can take long time.