From: Javier Martinez Canillas <javier@osg.samsung.com>
To: Alban Bedel <alban.bedel@avionic-design.de>, linux-media@vger.kernel.org
Cc: Mauro Carvalho Chehab <mchehab@osg.samsung.com>,
Sakari Ailus <sakari.ailus@iki.fi>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [media] v4l2-async: Pass the v4l2_async_subdev to the unbind callback
Date: Tue, 10 May 2016 17:42:30 -0400 [thread overview]
Message-ID: <9782608b-65da-8379-9ec8-bb7f08429af6@osg.samsung.com> (raw)
In-Reply-To: <1462886354-2115-1-git-send-email-alban.bedel@avionic-design.de>
Hello Alban,
On 05/10/2016 09:19 AM, Alban Bedel wrote:
> v4l2_async_cleanup() is always called before before calling the
> unbind() callback. However v4l2_async_cleanup() clear the asd member,
> so when calling the unbind() callback the v4l2_async_subdev is always
> NULL. To fix this save the asd before calling v4l2_async_cleanup().
>
> Signed-off-by: Alban Bedel <alban.bedel@avionic-design.de>
> ---
Patch looks good to me. So after fixing the issues pointed out by Sakari:
Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com>
Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America
prev parent reply other threads:[~2016-05-10 21:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-10 13:19 Alban Bedel
2016-05-10 18:45 ` Sakari Ailus
2016-05-10 21:42 ` Javier Martinez Canillas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9782608b-65da-8379-9ec8-bb7f08429af6@osg.samsung.com \
--to=javier@osg.samsung.com \
--cc=alban.bedel@avionic-design.de \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@osg.samsung.com \
--cc=sakari.ailus@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®