From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39F18C433F5 for ; Sat, 23 Apr 2022 19:03:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236855AbiDWTFz (ORCPT ); Sat, 23 Apr 2022 15:05:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45848 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229491AbiDWTFx (ORCPT ); Sat, 23 Apr 2022 15:05:53 -0400 Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.25]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 19DC11C6C9E for ; Sat, 23 Apr 2022 12:02:56 -0700 (PDT) Received: from omf04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay12.hostedemail.com (Postfix) with ESMTP id 200C11215B1; Sat, 23 Apr 2022 19:02:55 +0000 (UTC) Received: from [HIDDEN] (Authenticated sender: joe@perches.com) by omf04.hostedemail.com (Postfix) with ESMTPA id 5BE202002A; Sat, 23 Apr 2022 19:02:54 +0000 (UTC) Message-ID: <97899995717e1ebd12f97c5df2b8e37ba6f6aa7b.camel@perches.com> Subject: Re: [PATCH] scripts: get_maintainer: add an option to format for command line From: Joe Perches To: Ian Cowan Cc: linux-kernel@vger.kernel.org Date: Sat, 23 Apr 2022 12:02:53 -0700 In-Reply-To: <20220423185552.126453-1-ian@linux.cowan.aero> References: <20220423185552.126453-1-ian@linux.cowan.aero> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.40.4-1ubuntu2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Stat-Signature: zj3ezcznfoidoznrh4eyo6armekew6ha X-Rspamd-Server: rspamout08 X-Rspamd-Queue-Id: 5BE202002A X-Session-Marker: 6A6F6540706572636865732E636F6D X-Session-ID: U2FsdGVkX1/w1MIXMcbCKzYmRFcU+v3W+K6L4HNWCHY= X-HE-Tag: 1650740574-447406 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 2022-04-23 at 14:55 -0400, Ian Cowan wrote: > This adds the option to return the list of maintainers in the format for > sending via command line, specifically targeted for `git send-email`. > This will add a `--to` tag before the first email and a `--cc` tag for > each following email. The option can be toggled by using the > `--cl-format` flag when calling the get_maintainer script. > > The new addition is disabled by default and will only print (even if > enabled) if there are maintainers to return. This will prevent the > script from trying to generate a formatted line without any maintainers > and also allow the user to visually verify that the outputted line contains > the correct maintainers and lists (by verifying the roles). nack. get_maintainers does not need to be the be-all/end-all script for every purpose. Try adding wrapper scripts instead. I use something like this: https://lore.kernel.org/lkml/1473862411.32273.25.camel@perches.com/