mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Nicholas Chin <nic.c3.14@gmail.com>
To: Viresh Kumar <viresh.kumar@linaro.org>,
	"Rafael J. Wysocki" <rafael@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
	rafael.j.wysocki@intel.com, vincent.guittot@linaro.org,
	zhenglifeng1@huawei.com
Subject: Re: [PATCH] cpufreq: acpi: Don't enable boost on policy exit
Date: Fri, 18 Apr 2025 11:06:27 -0600	[thread overview]
Message-ID: <978bc0b7-4dfe-4ca1-9dd5-6c4a9c892be6@gmail.com> (raw)
In-Reply-To: <CAKohpomN1PYn1NPSsxCxqpMfg-9nYgCRQD6dFGQ30B+76vneQw@mail.gmail.com>

On 2025-04-17 23:58, Viresh Kumar wrote:
> What about something like this instead ? Nicholas, can you give this a try
> along with the $Subject patch (both patches should be applied) ?
> 
> diff --git a/drivers/cpufreq/acpi-cpufreq.c b/drivers/cpufreq/acpi-cpufreq.c
> index 924314cdeebc..71557f2ac22a 100644
> --- a/drivers/cpufreq/acpi-cpufreq.c
> +++ b/drivers/cpufreq/acpi-cpufreq.c
> @@ -909,8 +909,10 @@ static int acpi_cpufreq_cpu_init(struct
> cpufreq_policy *policy)
>         if (perf->states[0].core_frequency * 1000 != freq_table[0].frequency)
>                 pr_warn(FW_WARN "P-state 0 is not max freq\n");
> 
> -       if (acpi_cpufreq_driver.set_boost)
> +       if (acpi_cpufreq_driver.set_boost) {
>                 policy->boost_supported = true;
> +               policy->boost_enabled = boost_state(cpu);
> +       }
> 
>         return result;

Thanks, applying this patch along with the $Subject patch works.

  reply	other threads:[~2025-04-18 17:06 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-16  5:29 Viresh Kumar
2025-04-16  8:47 ` zhenglifeng (A)
2025-04-16 12:38   ` Rafael J. Wysocki
2025-04-17  1:54 ` Nicholas Chin
2025-04-17  5:02   ` Viresh Kumar
2025-04-17  5:09     ` Viresh Kumar
2025-04-17 12:39       ` Rafael J. Wysocki
2025-04-17 15:53         ` Rafael J. Wysocki
2025-04-18  5:58           ` Viresh Kumar
2025-04-18 17:06             ` Nicholas Chin [this message]
2025-04-18 19:28               ` Rafael J. Wysocki
2025-04-19  7:54                 ` Viresh Kumar
2025-04-19  9:35                   ` zhenglifeng (A)
2025-04-21  6:20                     ` Viresh Kumar
2025-04-21  7:45                       ` zhenglifeng (A)
2025-04-21 11:37                     ` Viresh Kumar
2025-04-21 13:36                       ` zhenglifeng (A)
2025-04-22  9:41                         ` Viresh Kumar
2025-04-22 12:05                           ` zhenglifeng (A)
2025-04-17 12:36     ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=978bc0b7-4dfe-4ca1-9dd5-6c4a9c892be6@gmail.com \
    --to=nic.c3.14@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=rafael.j.wysocki@intel.com \
    --cc=rafael@kernel.org \
    --cc=vincent.guittot@linaro.org \
    --cc=viresh.kumar@linaro.org \
    --cc=zhenglifeng1@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®