From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E66811DF736 for ; Thu, 14 Nov 2024 09:13:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731575589; cv=none; b=bp3vG1lB0PNXRc0+kg4wh6zVU2hEM2hxLHLiPWFDNI/PsBmrGAKupE8ow7Iv9Yf8klfEJgSQJnZhfeSzi0YWiK3gZmTaPBApA3LH35ZAmYXvY7w/hFDIzdMagLkqNmU7TmZd43Elotmh34yrBs/zoJ2DNR+oOP6pbCLfxL2b2lg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731575589; c=relaxed/simple; bh=ZlochL675vKEl4dprZTa/z7ai2B8pgWEOJ0VD/AVS28=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=na/Sqim3/zg/jSxECVUxY6abn/zcAdkR5m4qqcDOG90e5PzHHftS238r5NJFuXORK26fTGH4ciwWICyHbJEnbGS5NIFOTYyGaIPNyoG5wYeXLoFWClyoq1l8oeve9elLG1CcvyowjLD6ctclKpu2KOcu54VNydndCv1Rh8wcEQI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=bP7V0Pzt; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="bP7V0Pzt" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1731575586; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VUeaOXQiwvSG7xEIr9TGhk8zuNyNZ/eaCIMRElm3z+E=; b=bP7V0Pztu0J/GfW/KKSEbw+fqjgciBQGS/NhuAUbqu/ngKnRCPnITlt4MXqZPisQBU9s9b Llaa9+s0BwZoJzd1cqSnI3+LwewEWPfx3PoYxv08D1QXQTC3n4/WWJwoOu08IC8QHWItnE fjrf0E6akJIWHkaxX2qH1QNOShTK8hI= Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-691-CuCWh4B_PKSG-gJafIuCKA-1; Thu, 14 Nov 2024 04:13:03 -0500 X-MC-Unique: CuCWh4B_PKSG-gJafIuCKA-1 X-Mimecast-MFC-AGG-ID: CuCWh4B_PKSG-gJafIuCKA Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-7b1581d41dcso46226285a.2 for ; Thu, 14 Nov 2024 01:13:03 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731575583; x=1732180383; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=VUeaOXQiwvSG7xEIr9TGhk8zuNyNZ/eaCIMRElm3z+E=; b=fkKgxrw4KVKIID0yia34sZKdWwuNClABG6sbPbQHdSg4JJBLlp/CmAAOHjpESApPG3 biyvuhIS2OtwJVbp7Y8vGQjyvGBU0PK2h7isb4o4A5C3n+as97O4N/Ub0IU/pqFDpIK5 n6DSIYc/SYMV8Nwqtae6flB6/98XkNhtByGdgj7zaSC8TRGwbROKbJbGHwIvXfAByrXw ZFEdviUO1uK7IgWhAgZpPQJXllK/LgMQ/C5pAi/Q6ng0SE/DF96bmSSLyR87LVHjUTHx ehXMHZnI8b0JszPStrZ3ul/h42xVoon5evW2s4//CFsfnhJU1FYMUuxcA5aVU0D/TkQj X0MA== X-Forwarded-Encrypted: i=1; AJvYcCXByi1J6u+AVLwZmbQJWz1lbGVgyBrS/A+YzHTd4WeWQE67K7s8WCkh/CmruME8f3TsDmQrLElZP6Ugpzs=@vger.kernel.org X-Gm-Message-State: AOJu0YxIf/2Ex1af+eDNwi42szK08WJIOivUaWNuz4FklYg5fuFg15BL kO/yASG1kbc0pYlo4vK0Vn7WH+h8uwBWBNlegy7Gfq/+68H2CYoGovhuw/AkAqhowAaJ0hcx5I+ Qg1yb2wMygsqdXC5RVWRqyKXLsKnnohKlnXgbzFI4CULT+pY3gBaZoS6gnsvA+A== X-Received: by 2002:a05:620a:448f:b0:7a9:c406:eeb3 with SMTP id af79cd13be357-7b35c09efc9mr200077085a.1.1731575583034; Thu, 14 Nov 2024 01:13:03 -0800 (PST) X-Google-Smtp-Source: AGHT+IHiS3vUHfH1zuhrwZzd1lLo5Hyvopj7rMtfjzgPmX9vV/xp1+1gGzFFTWpSfzlmkHlXbLU+yQ== X-Received: by 2002:a05:620a:448f:b0:7a9:c406:eeb3 with SMTP id af79cd13be357-7b35c09efc9mr200074485a.1.1731575582686; Thu, 14 Nov 2024 01:13:02 -0800 (PST) Received: from [192.168.88.24] (146-241-44-112.dyn.eolo.it. [146.241.44.112]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7b35c99ddbdsm28735085a.47.2024.11.14.01.12.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 14 Nov 2024 01:13:02 -0800 (PST) Message-ID: <978cdfc7-f584-4ab5-a062-db19ed363691@redhat.com> Date: Thu, 14 Nov 2024 10:12:58 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v8 net-next 3/4] ipv4/udp: Add 4-tuple hash for connected socket To: Philo Lu , netdev@vger.kernel.org Cc: willemdebruijn.kernel@gmail.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, dsahern@kernel.org, horms@kernel.org, antony.antony@secunet.com, steffen.klassert@secunet.com, linux-kernel@vger.kernel.org, dust.li@linux.alibaba.com, jakub@cloudflare.com, fred.cc@alibaba-inc.com, yubing.qiuyubing@alibaba-inc.com References: <20241108054836.123484-1-lulie@linux.alibaba.com> <20241108054836.123484-4-lulie@linux.alibaba.com> <14a1a4a1-7281-4715-bf6e-73d3dd5417ef@linux.alibaba.com> Content-Language: en-US From: Paolo Abeni In-Reply-To: <14a1a4a1-7281-4715-bf6e-73d3dd5417ef@linux.alibaba.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 11/13/24 02:50, Philo Lu wrote: > On 2024/11/12 22:58, Paolo Abeni wrote: >> On 11/8/24 06:48, Philo Lu wrote: >> [...] >>> Signed-off-by: Philo Lu >>> Signed-off-by: Cambda Zhu >>> Signed-off-by: Fred Chen >>> Signed-off-by: Yubing Qiu >> >> [...] >>> @@ -2937,7 +3128,7 @@ struct proto udp_prot = { >>> .owner = THIS_MODULE, >>> .close = udp_lib_close, >>> .pre_connect = udp_pre_connect, >>> - .connect = ip4_datagram_connect, >>> + .connect = udp_connect, >>> .disconnect = udp_disconnect, >>> .ioctl = udp_ioctl, >>> .init = udp_init_sock, >> >> 2 minor notes, possibly not needing a repost: >> >> - The SoB chain looks strange, do you mean co-developed-by actually? > > Yes, we're all involved in the development. I think it could be > indicated by SoBs (and all of us agree with this). Please let me know if > I'm wrong :) > > Or strictly as [1], it should be: > > Co-developed-by: Cambda Zhu > Signed-off-by: Cambda Zhu > Co-developed-by: Fred Chen > Signed-off-by: Fred Chen > Co-developed-by: Yubing Qiu > Signed-off-by: Yubing Qiu > Signed-off-by: Philo Lu > > [1] > https://www.kernel.org/doc/html/latest/process/submitting-patches.html#when-to-use-acked-by-cc-and-co-developed-by The latter (with co-dev-by tags) I think would be better, it will give full attribution to all of you. Since the scope of this work is relevant I think it would be better a complete recognition. >> - udplite is not touched. AFAICS should not be a problem - just the >> feature will not be available for udplite. > > Agreed. Theoretically, the feature relies on udp4_hash4/udp6_hash4 when > connecting, and all other functions including lookup/unhash/rehash > always check "hashed4" firstly, and do nothing if it's false (which is > the case for udplite). > > AFAICT, the effects to udplite include: > - Additional memory consumption in udp_sock and udptable > - Control path: udp_hashed4 checking when unhash/rehash > - Data path: udp_has_hash4 checking when lookup > (like unconnected sks in udp) Looks good. Please note explicitly in the cover letter that udplite is intentionally excluded here, the reason why such choice is safe (basically a synopsis of the above) and repost with the update tags chain including my Acked-by tag (you should retain Willem acked-by tag, too.) Thanks! Paolo