From: Yingkun Meng <mengyingkun@loongson.cn>
To: Mark Brown <broonie@kernel.org>
Cc: lgirdwood@gmail.com, linux-kernel@vger.kernel.org,
alsa-devel@alsa-project.org, loongarch@lists.linux.dev,
loongson-kernel@lists.loongnix.cn
Subject: Re: [ PATCH v2 2/3] ASoC: loongson: Add Loongson ASoC Sound Card Support
Date: Wed, 14 Jun 2023 17:14:27 +0800 [thread overview]
Message-ID: <978fa726-e194-2162-e10d-aed3a1c756e8@loongson.cn> (raw)
In-Reply-To: <1568e064-606e-4f56-951f-429a87a3a2d9@sirena.org.uk>
On 2023/6/13 03:06, Mark Brown wrote:
> On Mon, Jun 12, 2023 at 05:00:46PM +0800, YingKun Meng wrote:
>
>> + if (ls_card->mclk_fs) {
>> + mclk = ls_card->mclk_fs * params_rate(params);
>> + ret = snd_soc_dai_set_sysclk(cpu_dai, 0, mclk,
>> + SND_SOC_CLOCK_OUT);
>> + if (ret < 0) {
>> + dev_err(codec_dai->dev, "cpu_dai clock not set\n");
>> + return ret;
>> + }
> Does this need to be in the machine driver - this isn't configuring an
> external clock, it's just within the SoC, so presumably the driver for
> the SoC DAI can just set itself up.
I think so. The driver for the SoC DAI cannot obtain the MCLK frequency of
I2S bus from the clock subsystem.
next prev parent reply other threads:[~2023-06-14 9:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-12 9:00 YingKun Meng
2023-06-12 19:06 ` Mark Brown
2023-06-14 9:14 ` Yingkun Meng [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-06-12 8:57 YingKun Meng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=978fa726-e194-2162-e10d-aed3a1c756e8@loongson.cn \
--to=mengyingkun@loongson.cn \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=loongarch@lists.linux.dev \
--cc=loongson-kernel@lists.loongnix.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®