From: Steffen Vogel <post@steffenvogel.de>
To: linux-kernel@vger.kernel.org
Cc: Evgeniy Polyakov <zbr@ioremap.net>, Joe Perches <joe@perches.com>,
Steffen Vogel <post@steffenvogel.de>
Subject: [PATCH v2 08/12] w1: improve code-style of struct declarations
Date: Mon, 29 Oct 2018 04:03:38 +0100 [thread overview]
Message-ID: <978fc1676896e84c7ca7ce9942de25c4db00708b.1540782140.git.post@steffenvogel.de> (raw)
In-Reply-To: <cover.1540782140.git.post@steffenvogel.de>
Among improving the readability of the struct declarations,
this fixes a warning about incorrect brace placement
raised by the checkpatch tool.
Signed-off-by: Steffen Vogel <post@steffenvogel.de>
---
drivers/w1/w1_netlink.h | 28 +++++++++++++---------------
1 file changed, 13 insertions(+), 15 deletions(-)
diff --git a/drivers/w1/w1_netlink.h b/drivers/w1/w1_netlink.h
index 08cbf08f3649..7873eb54352e 100644
--- a/drivers/w1/w1_netlink.h
+++ b/drivers/w1/w1_netlink.h
@@ -61,19 +61,18 @@ enum w1_netlink_message_types {
* The netlink connector data sequence is, struct nlmsghdr, struct cn_msg,
* then one or more struct w1_netlink_msg (each with optional data).
*/
-struct w1_netlink_msg
-{
- __u8 type;
- __u8 status;
- __u16 len;
+struct w1_netlink_msg {
+ __u8 type;
+ __u8 status;
+ __u16 len;
union {
- __u8 id[8];
+ __u8 id[8];
struct w1_mst {
- __u32 id;
- __u32 res;
+ __u32 id;
+ __u32 res;
} mst;
} id;
- __u8 data[0];
+ __u8 data[0];
};
/**
@@ -117,12 +116,11 @@ enum w1_commands {
* One or more struct w1_netlink_cmd is placed starting at w1_netlink_msg.data
* each with optional data.
*/
-struct w1_netlink_cmd
-{
- __u8 cmd;
- __u8 res;
- __u16 len;
- __u8 data[0];
+struct w1_netlink_cmd {
+ __u8 cmd;
+ __u8 res;
+ __u16 len;
+ __u8 data[0];
};
#ifdef __KERNEL__
--
2.11.0
next prev parent reply other threads:[~2018-10-29 3:12 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-29 3:03 [PATCH v2 00/11] w1: coding style and checkpatch fixes Steffen Vogel
2018-10-29 3:03 ` [PATCH v2 01/12] w1: add SPDX identifiers Steffen Vogel
2018-10-29 3:03 ` [PATCH v2 02/12] w1: improve code-style by adhering tp 80 columns per line limit Steffen Vogel
2018-10-29 3:03 ` [PATCH v2 03/12] w1: add newlines after declarations Steffen Vogel
2018-10-29 3:03 ` [PATCH v2 04/12] w1: cleanup whitespaces according to coding style document Steffen Vogel
2018-10-29 3:03 ` [PATCH v2 05/12] w1: use octal numbers instead of macros for file mode Steffen Vogel
2018-10-29 3:03 ` [PATCH v2 06/12] w1: do not log errors about failed memory allocations Steffen Vogel
2018-10-29 3:03 ` [PATCH v2 07/12] w1: use __func__ for logging the function name Steffen Vogel
2018-10-29 3:03 ` Steffen Vogel [this message]
2018-10-29 3:03 ` [PATCH v2 09/12] w1: using linux instead of asm prefix for includes Steffen Vogel
2018-10-29 3:03 ` [PATCH v2 10/12] w1: use pointers instead of types to determine size of allocs Steffen Vogel
2018-10-29 3:03 ` [PATCH v2 11/12] w1: replace non-standard %LX format-string by %llX Steffen Vogel
2018-10-29 3:03 ` [PATCH v2 12/12] w1: fix typo in comment Steffen Vogel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=978fc1676896e84c7ca7ce9942de25c4db00708b.1540782140.git.post@steffenvogel.de \
--to=post@steffenvogel.de \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=zbr@ioremap.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®