From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from rtits2.realtek.com.tw (rtits2.realtek.com [211.75.126.72]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4D1E4388E61; Mon, 12 Oct 2026 03:22:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=211.75.126.72 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791775328; cv=none; b=HV0NmfbEPA7htzLCeaX0LC5J2n4WPKuCblYJyBwLiIcks9Kv6ilx8hQlgEN6a15i2yVJEBmdDLfljphRLa+nUauvih/NE3BLIlUz/6O4bIKQJ2yTEGUzmOqLQ8MjoxQYcVLgsbKBR8rOo4aTFtT7K2MXuprsmdJUyuhflaBmaNA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791775328; c=relaxed/simple; bh=+2u3a32RLD50VIM8AqP/4VeP49/dYLJSk5KKkEujr3c=; h=From:To:CC:Subject:Date:Message-ID:References:In-Reply-To: Content-Type:MIME-Version; b=U6aqkFlErySc/W8QwTwRSSifjQ2qtQupPbZnnm1JVRzDiPw1Y1NEu1j7VMlVA8pC6RkvEjOXQ32izTCDp5uXCf1bryxpvIs/TEn+oLbMt5fb2OZT75w1dSvrH+3vvl6x+4aVGrTKFVHAQ9ax9XYAX+zyfPh3Zy/gX3CJW/nPMmI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=realtek.com; spf=pass smtp.mailfrom=realtek.com; dkim=pass (2048-bit key) header.d=realtek.com header.i=@realtek.com header.b=JG52BYr6; arc=none smtp.client-ip=211.75.126.72 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=realtek.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=realtek.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=realtek.com header.i=@realtek.com header.b="JG52BYr6" X-SpamFilter-By: ArmorX SpamTrap 5.80 with qID 69C3Lm7vA3481125, This message is accepted by code: ctloc85258 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=realtek.com; s=dkim; t=1791775309; bh=+2u3a32RLD50VIM8AqP/4VeP49/dYLJSk5KKkEujr3c=; h=From:To:CC:Subject:Date:Message-ID:References:In-Reply-To: Content-Type:Content-Transfer-Encoding:MIME-Version; b=JG52BYr6BMIQeAQ1qzDiWM3h8QbA0d/PUmMNG00pGq6TAkActHxCnZ/Ys/YpEF+cm UHv+CrIwE6DO531liRjhVdIJi00+S0cktMEjVI64CGeRQ632Rdnyypv802TcPz9igJ jkDGuTnJJXsf63xA+gXQlB7OD7zjpz4TteGqkJj/nV1ghQ3e0ZKcEehysabEdg9XUs aCoeZfELNiTBWCpYbGa+A4DSRl5NOVK5BY0jSUsEe3kWOTTslIJJul08laAFSZoxbE sJuEkm5FdXNrTKBtzGUrQzkbbd2tjh1oWO8jaW6zBom+mrJJas95CyRw9nSGJLk+jd Ks2iwEPD327Mw== Received: from mail.realtek.com (rtkexhmbs04.realtek.com.tw[10.21.1.54]) by rtits2.realtek.com.tw (8.15.2/3.29/5.94) with ESMTPS id 69C3Lm7vA3481125 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 12 Oct 2026 11:21:48 +0800 Received: from RTKEXHMBS06.realtek.com.tw (10.21.1.56) by RTKEXHMBS04.realtek.com.tw (10.21.1.54) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.49; Mon, 12 Oct 2026 11:21:52 +0800 Received: from RTKEXHMBS06.realtek.com.tw ([::1]) by RTKEXHMBS06.realtek.com.tw ([fe80::b3cc:c263:b82d:e87c%10]) with mapi id 15.02.2562.049; Mon, 12 Oct 2026 11:21:52 +0800 From: Ping-Ke Shih To: Mehmet Fide CC: Luka Gejak , Bitterblue Smith , "linux-wireless@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "mehmet.fide@screeningeagle.com" Subject: RE: [PATCH rtw-next v5 2/3] wifi: rtw88: update the beacon from a wiphy work Thread-Topic: [PATCH rtw-next v5 2/3] wifi: rtw88: update the beacon from a wiphy work Thread-Index: AQHdVu3mwmHy3D3OSEW9+SwESNh3d7b5QEgwgAADEmA= Date: Mon, 12 Oct 2026 03:21:52 +0000 Message-ID: <97931e8606134d8390762041a638e556@realtek.com> References: <1d68c868609a8d63dc884c155023c2e100dca886.1791362281.git.mehmet.fide@screeningeagle.com> <0d01a6f2cd9842ae991091918700d638@realtek.com> In-Reply-To: <0d01a6f2cd9842ae991091918700d638@realtek.com> Accept-Language: en-US, zh-TW Content-Language: zh-TW Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Ping-Ke Shih wrote: =20 > Mehmet Fide wrote: > > From: Mehmet Fide > > > > set_tim() queues update_beacon_work to rebuild the reserved page with > > the new TIM. Make it a wiphy work so that it runs under the wiphy lock > > like the other beacon downloads and can look at mac80211 state; >=20 > What "mac80211 state" did you mean? Without wiphy_work, it can't state > it? >=20 > > the > > next patch needs that to tell whether a channel switch is being > > announced. > > > > rtw_core_stop() runs without the wiphy lock on the IPS path and can no > > longer cancel the work, so the work checks RTW_FLAG_RUNNING under the > > driver mutex instead, as the watchdog and the C2H work do. (forgot to say) Or you should add wiphy lock on IPS path, and cancel the work. >=20 > rtw88 doesn't use wiphy work/lock yet. and you are the first one to use > wiphy_work. Mixing to use wiphy work/lock and ieee80211_work with driver > lock looks not good. Should we just use ieee80211_work to avoid confusing= ? >=20 > Or we should migrate to wiphy work/lock? >=20 > For me, I prefer you use ieee80211_work with driver lock for now, because > I guess I don't have time to verify the migration... >=20 > Ping-Ke >=20