From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 37E6B37E2E5 for ; Tue, 28 Apr 2026 08:57:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777366635; cv=none; b=N9SDT0qvLdWu/Z5MiJf7zg1RACEVYonD2Wgvr6qWnMMF/V3AH4cjwXpJ1zz1f3b2/15SdgBU+h73u+RM1zRwwgBgF6TGxjpSaUa8GXxXK2C5g+KW6jhDsy50BwBmCgxhr6wh/5EHz+isQMl1MTNgUgFbQvteBSltsFl7BKLsOaM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777366635; c=relaxed/simple; bh=6/kXOpIPrMyYeAZQVyerbvyBh4ZULLVmilh78gfeyXo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=q8dVAOXYchuzm4My6sIEdnt36Sio6bUoWcmcVvWaaTQ6cuJ3JVQKsKn0oTnxSy/cp8K0PSqLYOvlZOTKWWH4+WAzfKTnL/NEx6CNZBoGbll2a/v4Twowmt7aKJrQsPfDZAdoPiKoahJbPBGI4B98wgxGtzZ6kvc6FKo2d5lrCaI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=SnbT/UeZ; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=YVErJX6W; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="SnbT/UeZ"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="YVErJX6W" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63S3tvo12112539 for ; Tue, 28 Apr 2026 08:57:13 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= ZrIv032C0RLaUKbrdVzoDDiJxw7RgWufz1Fjh7XtFuQ=; b=SnbT/UeZ9SYbGdo4 0WzyD5jTFOmk3wtQ71JvXsSaDGkEc0WhrOO4rBTVFrbs2Yl7ChxzVnYs27d8rjla 2TjFrPGnn5N1LoADoXEuDPOtk+9uipRVs+3UW00ztwBfY2kPIHgkz29//pU8JcQZ MXkwcdp+jr0K5CJWJcK6ujQRx3eIOb+2z+CSNHsgX/U+J48VsApo/HMylPnJC0G/ AnbW5wQlEMYHWK6c2Mg2AtJrbCkMbaEPQyAI4UyBFqP7AxfpmUp52HhvcIVkr0rd SZg4gEsCY78pPaBtnklnmMkvBfuUcDmIxPHoWFIFPIRoKwcwB8fzQRgV6KJR6S/k xpV12A== Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dtdmbjq6t-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 28 Apr 2026 08:57:13 +0000 (GMT) Received: by mail-qv1-f69.google.com with SMTP id 6a1803df08f44-8acb4b340f4so30233606d6.1 for ; Tue, 28 Apr 2026 01:57:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1777366632; x=1777971432; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ZrIv032C0RLaUKbrdVzoDDiJxw7RgWufz1Fjh7XtFuQ=; b=YVErJX6WuBg9HU1KVE6h7PaxTFMPUmZOqH7WWlUcw2lv/K72mXj8S+Aj7IPG9godH6 7RQFGNF+W/I7eW6CPMeDqg8n57jjUdFY3c5ql9KfL3jsvZbSIg39hTjsS1I+MxDUaIHQ iYP992ttS4iNYSqXrWpg28F2k2W66/YREZjud1BxOlgjlWjnGWTUrOyFr0g7bRDh9+60 CmIbPKqoqLKqJ53AHzK3jPwu4nk/ZDJ5XtUhdcLODnOfxQpRYGTbKbap4akzB+t7F6NM lsZNN+TaTO9j2YJwYvbJPHx6854jdJoM6RYwrRnDAIIZfz3eLdxB/2n+UFh3nMzsDnBy 91aQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777366632; x=1777971432; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ZrIv032C0RLaUKbrdVzoDDiJxw7RgWufz1Fjh7XtFuQ=; b=MbU7jswvcQsA+trciWuqIzdiyf7Ex/Vu+NZXtP5ie+uLQVDvRGBugevXN1xMQgJpoK AM0y8eP3wAKZGx3eXxmZqLzc13rwn1oVeQaHQVIxJw8HrbIHvwQC3GBReYj599cBYtkx zZFFjOeJn7/v0O1+G08Xr3ODNs4L5jsBBAfFzghSPbCNrcEiEIeHEpkYkPk06wdKKt2/ KU86I8VLno5Ri/60suyK2gKJn3DFkk7LzgJZ+6J9hNexSDlCulGPRX5J83TZCznWh68p YXfG32jX/7arul+KP9yLLJhjQ5DEayhZi6FnVdAWm6t6TIp0uh1OPKzYOd4lVreSpDpr 7v6A== X-Forwarded-Encrypted: i=1; AFNElJ+hQmtO4Ou3fgf2Q6k/uCsFLDVO0Lv81mrAzfOV3/kbVU230OBYRGydjGcItCBwP/8VClc8FgKQR0A7R0E=@vger.kernel.org X-Gm-Message-State: AOJu0YwYRH3H6TtQEh2Sf9z/PTLOeAQNeOcnMH+tihADrxDdqCcNXbhN Qbkvv+j6wpdqAkSTItOQMXATaM/2jCmt9FRyO9RllwEYDiBOuYkSDZxYATtL1AvsnIXbGX28jhL rQWUIMga467cVoSHFuF8/RJ8tlKvebfP+eWlL4wbSG7s9Jyf6YfFIvoksn4hF9Kearlw= X-Gm-Gg: AeBDieuRZOXICJ2KrACo3M+hcJ2Gme5KqzS8+2PlVN9VXJDZp0XC1IDuU+TZv8OycX0 kuhDQ3D/tglnYNrVGGuVBKrgABTvYV4XM97yu8xAd1MceUffRq0U9ufa0isU9N4zrKXjBntILhE CB+asWC3Dekf5WvDESHYLUO9GvlP0veckjErIN3njSF7uMXCczrc0aLfyml7vhlFpR0dMRyOB9A SGLmn3BMpcscmss/z8/1oILJ2ime02THq3xJBaTZdDKAAD0uEEqBFqJcAYRZLv4vVKli702M/Lw Ant2RpOUr0RntHg2Znth3OZeWI+8hoQtqRv6MXQFcETyhgywOx6XjZr7mqWaY8Khi3Byan4O98d qmuH1+0Jrngx8nEW38O1CVCcZ2bf9MdJxpdSuG/HtcTyfE5XC1OlS+Vbpi+6mD2ltA7ppPEWY8R s09NjrvqYIao1zcw== X-Received: by 2002:a05:6214:629:b0:89a:4741:2147 with SMTP id 6a1803df08f44-8b3e2a0dfa3mr27568916d6.8.1777366632276; Tue, 28 Apr 2026 01:57:12 -0700 (PDT) X-Received: by 2002:a05:6214:629:b0:89a:4741:2147 with SMTP id 6a1803df08f44-8b3e2a0dfa3mr27568606d6.8.1777366631761; Tue, 28 Apr 2026 01:57:11 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-bb808a35e19sm70631966b.16.2026.04.28.01.57.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 28 Apr 2026 01:57:10 -0700 (PDT) Message-ID: <97969bf9-8eb2-4498-90bd-9973fb2bd638@oss.qualcomm.com> Date: Tue, 28 Apr 2026 10:57:07 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 8/8] ARM: dts: qcom: Add Samsung Galaxy S4 To: contact@alex-min.fr, Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , MyungJoo Ham , Chanwoo Choi , Guru Das Srinagesh , Linus Walleij , Rob Clark , Joerg Roedel , Will Deacon , Robin Murphy , Kees Cook , Tony Luck , "Guilherme G. Piccoli" Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, iommu@lists.linux.dev, phone-devel@vger.kernel.org References: <20260427-mainline-send-v1-sending-v2-0-dcaa9178007b@alex-min.fr> <20260427-mainline-send-v1-sending-v2-8-dcaa9178007b@alex-min.fr> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260427-mainline-send-v1-sending-v2-8-dcaa9178007b@alex-min.fr> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: oDm7MnYxG2L9S8S6QJ1TAKsEAtgE6y2h X-Authority-Analysis: v=2.4 cv=PcrPQChd c=1 sm=1 tr=0 ts=69f07669 cx=c_pps a=wEM5vcRIz55oU/E2lInRtA==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=J1_VKfl4AAOAIIosoXcA:9 a=QEXdDO2ut3YA:10 a=OIgjcC2v60KrkQgK7BGD:22 X-Proofpoint-ORIG-GUID: oDm7MnYxG2L9S8S6QJ1TAKsEAtgE6y2h X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDI4MDA4MCBTYWx0ZWRfX2oh+A5qkNrpe CPdcMxta6HNHIvoZwK3oCWDzb3IayuygR1wDA2MU2F+IOvLcIfw8cQihMsELcg3+NlYYu8xPWA6 9YZ1StH+lOM4wydpQVvLHk3Ues5pwKRI32HCOde9hU02UcoPO+nRrhngtvEJOuMrP7lTHKevGFa zwTSGuGB17BZfBhNiqsIqL9I6ctCE2WoJm/nAxoIAXrBvQd4/FA0y54pKcLYQUaXgrXt2k4soas 7gFLHe+Lyh+2y0sajfpF8d13FJqRXU79jkakaSSWggw2Sbqnsqphbt+1O2jl1jE+sx5E/Y9XIou sWIZ5HHKnf7cJbAfdzxEHXSj4Zdkl038OOMm9XXoe/RU3H5eU9slbfA9Q+Vxv/EL8+XT6BC8ewo FiblFxRkarVKPJEXp4kk8aajCZ7MpttZsoSQUrIZn6OEMXIRxvUZWvVNGLk0exlcr1J87Pp2JUy uLq2Ou7rN8o+MyPFZsA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-28_02,2026-04-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 spamscore=0 lowpriorityscore=0 suspectscore=0 clxscore=1015 malwarescore=0 adultscore=0 priorityscore=1501 bulkscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2604280080 On 4/27/26 9:34 PM, Alexandre MINETTE via B4 Relay wrote: > From: Alexandre MINETTE > > Add a device tree for the Samsung Galaxy S4, codenamed jflte. > > This has been tested on a Samsung Galaxy S4 GT-I9505. The initial support > covers UART, USB peripheral mode with USB networking, the front LED and > the physical buttons. > > Signed-off-by: Alexandre MINETTE > --- > arch/arm/boot/dts/qcom/Makefile | 1 + > .../boot/dts/qcom/qcom-apq8064-samsung-jflte.dts | 485 +++++++++++++++++++++ > 2 files changed, 486 insertions(+) > > diff --git a/arch/arm/boot/dts/qcom/Makefile b/arch/arm/boot/dts/qcom/Makefile > index 32a44b02d2fa..c23c961f79e3 100644 > --- a/arch/arm/boot/dts/qcom/Makefile > +++ b/arch/arm/boot/dts/qcom/Makefile > @@ -12,6 +12,7 @@ dtb-$(CONFIG_ARCH_QCOM) += \ > qcom-apq8064-ifc6410.dtb \ > qcom-apq8064-sony-xperia-lagan-yuga.dtb \ > qcom-apq8064-asus-nexus7-flo.dtb \ > + qcom-apq8064-samsung-jflte.dtb \ > qcom-apq8064-lg-nexus4-mako.dtb \ 'l'g < 's'amsung [...] > + i2c-led { > + compatible = "i2c-gpio"; > + sda-gpios = <&tlmm_pinmux 6 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>; > + scl-gpios = <&tlmm_pinmux 7 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>; Have you tried setting up the I2C-GPIO busses as GSBI devices, like I think I suggested the last time? This will potentially bring power and latency benefits, since there's an actual bus controller connected to these pins Konrad