From: Philippe Schenker <dev@pschenker.ch>
To: Conor Dooley <conor@kernel.org>
Cc: netdev@vger.kernel.org, Paolo Abeni <pabeni@redhat.com>,
Conor Dooley <conor+dt@kernel.org>,
Woojung Huh <woojung.huh@microchip.com>,
Vladimir Oltean <olteanv@gmail.com>,
linux-kernel@vger.kernel.org, UNGLinuxDriver@microchip.com,
Marek Vasut <marex@denx.de>,
Florian Fainelli <f.fainelli@gmail.com>,
devicetree@vger.kernel.org, Eric Dumazet <edumazet@google.com>,
"David S . Miller" <davem@davemloft.net>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Jakub Kicinski <kuba@kernel.org>, Andrew Lunn <andrew@lunn.ch>,
Rob Herring <robh+dt@kernel.org>
Subject: Re: [PATCH net-next v1 1/2] dt-bindings: net: dsa: Add KSZ8567 switch support
Date: Tue, 23 Jan 2024 18:30:16 +0100 [thread overview]
Message-ID: <979b1e77b5bb62463d52e7b9d3f9ca1415f4006a.camel@pschenker.ch> (raw)
In-Reply-To: <20240123-atlas-dart-7e955e7e24e5@spud>
On Tue, 2024-01-23 at 17:23 +0000, Conor Dooley wrote:
> On Tue, Jan 23, 2024 at 05:17:53PM +0100, Philippe Schenker wrote:
> >
> >
> > On Tue, 2024-01-23 at 16:06 +0000, Conor Dooley wrote:
> > > On Tue, Jan 23, 2024 at 02:50:13PM +0100, Philippe Schenker
> > > wrote:
> > > > From: Philippe Schenker <philippe.schenker@impulsing.ch>
> > > >
> > > > This commit adds the dt-binding for KSZ8567, a robust 7-port
> > > > Ethernet switch. The KSZ8567 features two RGMII/MII/RMII
> > > > interfaces,
> > > > each capable of gigabit speeds, complemented by five 10/100
> > > > Mbps
> > > > MAC/PHYs.
> > > >
> > > > Signed-off-by: Philippe Schenker
> > > > <philippe.schenker@impulsing.ch>
> > >
> > > This device has all the same constraints as the other ones in
> > > this
> > > binding, why is it not compatible with any of them? If it isn't,
> > > the
> > > compatible should mention why it is not.
> >
> > Hi Conor, Thanks for your message!
> >
> > I need the compatible to make sure the correct ID of the switch is
> > being set in the driver as well as its features.
>
> Are the features of this switch such that a driver for another ksz
> switch would not work (even in a limited capacity) with the 8567?
> Things like the register map changing or some feature being removed
> are
> examples of why it may not work.
Yes the ksz dsa driver is made so that it checks the ID of the attached
chip and refuses to work if it doesn't match. [1]
It is a very similar chip and uses the same regmap as KSZ9567 but with
lower phy-speeds on its 5 switch ports. The two upstream CPU ports are
gigabit capable. All this information is set-up in the second patch of
this series. [2]
I will include a description to the second series. Thanks for your
feedback.
Philippe
[1]
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/net/dsa/microchip/ksz_common.c?h=v6.8-rc1#n3181
[2]
https://patchwork.kernel.org/project/netdevbpf/patch/20240123135014.614858-2-dev@pschenker.ch/
>
> > You mean I shall mention the reason in the commit-message, or
> > where?
>
> Yes.
>
> Thanks,
> Conor
>
> > > > Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml |
> > > > 1 +
> > > > 1 file changed, 1 insertion(+)
> > > >
> > > > diff --git
> > > > a/Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml
> > > > b/Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml
> > > > index c963dc09e8e1..52acc15ebcbf 100644
> > > > ---
> > > > a/Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml
> > > > +++
> > > > b/Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml
> > > > @@ -31,6 +31,7 @@ properties:
> > > > - microchip,ksz9893
> > > > - microchip,ksz9563
> > > > - microchip,ksz8563
> > > > + - microchip,ksz8567
> > > >
> > > > reset-gpios:
> > > > description:
> > > > --
> > > > 2.34.1
> > > >
next prev parent reply other threads:[~2024-01-23 17:30 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-23 13:50 Philippe Schenker
2024-01-23 13:50 ` [PATCH net-next v1 2/2] " Philippe Schenker
2024-01-23 15:58 ` Arun.Ramadoss
2024-01-23 16:12 ` Philippe Schenker
2024-01-23 16:06 ` [PATCH net-next v1 1/2] dt-bindings: " Conor Dooley
2024-01-23 16:17 ` Philippe Schenker
2024-01-23 17:23 ` Conor Dooley
2024-01-23 17:30 ` Philippe Schenker [this message]
2024-01-23 18:37 ` Conor Dooley
2024-01-23 19:44 ` Philippe Schenker
2024-01-24 18:08 ` Andrew Lunn
2024-01-25 12:53 ` Conor Dooley
2024-01-25 9:57 ` Vladimir Oltean
2024-01-25 13:22 ` Conor Dooley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=979b1e77b5bb62463d52e7b9d3f9ca1415f4006a.camel@pschenker.ch \
--to=dev@pschenker.ch \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew@lunn.ch \
--cc=conor+dt@kernel.org \
--cc=conor@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marex@denx.de \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=robh+dt@kernel.org \
--cc=woojung.huh@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®