From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Vineeth Karumanchi <vineeth.karumanchi@amd.com>,
Rob Herring <robh@kernel.org>
Cc: nicolas.ferre@microchip.com, claudiu.beznea@tuxon.dev,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, krzysztof.kozlowski+dt@linaro.org,
conor+dt@kernel.org, linux@armlinux.org.uk,
vadim.fedorenko@linux.dev, andrew@lunn.ch,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, git@amd.com
Subject: Re: [PATCH net-next v3 4/4] dt-bindings: net: cdns,macb: Deprecate magic-packet property
Date: Thu, 6 Jun 2024 08:17:12 +0200 [thread overview]
Message-ID: <979b8f74-321d-4b83-bd3b-01643b3cbc35@linaro.org> (raw)
In-Reply-To: <241cb8ec-14c9-4d7c-9331-2df0b8bf21b2@amd.com>
On 06/06/2024 07:13, Vineeth Karumanchi wrote:
> Hi Rob,
>
>
> On 05/06/24 9:11 pm, Rob Herring wrote:
>> On Wed, Jun 05, 2024 at 03:54:57PM +0530, Vineeth Karumanchi wrote:
>>> WOL modes such as magic-packet should be an OS policy.
>>> By default, advertise supported modes and use ethtool to activate
>>> the required mode.
>>>
>>> Suggested-by: Andrew Lunn <andrew@lunn.ch>
>>> Signed-off-by: Vineeth Karumanchi <vineeth.karumanchi@amd.com>
>>> ---
>>> Documentation/devicetree/bindings/net/cdns,macb.yaml | 1 +
>>> 1 file changed, 1 insertion(+)
>>
>> You forgot Krzysztof's ack.
>>
>
> There is a change in the commit message from earlier version,
> as we are not using caps any more, I thought of not including the ack.
>
> I will add his ack in next version.
And where is it mentioned that you drop someone's ack on purpose?
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-06-06 6:17 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-05 10:24 [PATCH net-next v3 0/4] net: macb: WOL enhancements Vineeth Karumanchi
2024-06-05 10:24 ` [PATCH net-next v3 1/4] net: macb: queue tie-off or disable during WOL suspend Vineeth Karumanchi
2024-06-06 1:44 ` Andrew Lunn
2024-06-07 5:54 ` Vineeth Karumanchi
2024-06-05 10:24 ` [PATCH net-next v3 2/4] net: macb: Enable queue disable Vineeth Karumanchi
2024-06-06 2:00 ` Andrew Lunn
2024-06-05 10:24 ` [PATCH net-next v3 3/4] net: macb: Add ARP support to WOL Vineeth Karumanchi
2024-06-06 1:59 ` Andrew Lunn
2024-06-07 5:19 ` Vineeth Karumanchi
2024-06-05 10:24 ` [PATCH net-next v3 4/4] dt-bindings: net: cdns,macb: Deprecate magic-packet property Vineeth Karumanchi
2024-06-05 15:41 ` Rob Herring
2024-06-06 5:13 ` Vineeth Karumanchi
2024-06-06 6:17 ` Krzysztof Kozlowski [this message]
2024-06-06 7:04 ` Vineeth Karumanchi
2024-06-06 2:00 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=979b8f74-321d-4b83-bd3b-01643b3cbc35@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=andrew@lunn.ch \
--cc=claudiu.beznea@tuxon.dev \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=git@amd.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=pabeni@redhat.com \
--cc=robh@kernel.org \
--cc=vadim.fedorenko@linux.dev \
--cc=vineeth.karumanchi@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®