From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751333AbdH2Gaj (ORCPT ); Tue, 29 Aug 2017 02:30:39 -0400 Received: from fllnx209.ext.ti.com ([198.47.19.16]:41628 "EHLO fllnx209.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751258AbdH2Gah (ORCPT ); Tue, 29 Aug 2017 02:30:37 -0400 Subject: Re: [PATCH][pci-next] PCI: endpoint: fix incorrect end of table check in while loop To: Bjorn Helgaas , Colin King References: <20170823160303.23366-1-colin.king@canonical.com> <20170828182505.GH8154@bhelgaas-glaptop.roam.corp.google.com> CC: Bjorn Helgaas , , , From: Kishon Vijay Abraham I Message-ID: <979c168c-2334-d509-29b6-891799fc5f61@ti.com> Date: Tue, 29 Aug 2017 11:59:44 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <20170828182505.GH8154@bhelgaas-glaptop.roam.corp.google.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday 28 August 2017 11:55 PM, Bjorn Helgaas wrote: > On Wed, Aug 23, 2017 at 05:03:03PM +0100, Colin King wrote: >> From: Colin Ian King >> >> Currently, the while loop will iterate until a matching name is found >> or until the id pointer wraps around to NULL (the latter is incorrect). >> >> The end of a pci_epf_device_id table is terminated with zero'd entries >> for name and driver_data, so can change the while loop to iterate while >> the first character in the name is a non-zero character. >> >> Detected by CoverityScan, CID#1454557 ("Logically dead code") >> >> Fixes: 9e9d6eb48623 ("PCI: endpoint: Add an API to get matching "pci_epf_device_id") >> Signed-off-by: Colin Ian King > > Kishon, do you want to ack this, please? Acked-by: Kishon Vijay Abraham I > >> --- >> drivers/pci/endpoint/pci-epf-core.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/pci/endpoint/pci-epf-core.c b/drivers/pci/endpoint/pci-epf-core.c >> index ae6fac5995e3..70eccc04ee7f 100644 >> --- a/drivers/pci/endpoint/pci-epf-core.c >> +++ b/drivers/pci/endpoint/pci-epf-core.c >> @@ -273,7 +273,7 @@ pci_epf_match_device(const struct pci_epf_device_id *id, struct pci_epf *epf) >> if (!id || !epf) >> return NULL; >> >> - while (id) { >> + while (*id->name) { >> if (strcmp(epf->name, id->name) == 0) >> return id; >> id++; >> -- >> 2.14.1 >>