From: "Gordon Farquharson" <gordonfarquharson@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: linville@tuxdriver.com, mb@bu3sch.de, stefano.brivio@polimi.it,
rmk@arm.linux.org.uk
Subject: [RFC] [PATCH] Fix b43 driver build for arm
Date: Mon, 18 Feb 2008 15:03:10 -0700 [thread overview]
Message-ID: <97a0a9ac0802181403ja79c32v864b093414b2755@mail.gmail.com> (raw)
The b43 driver in 2.6.25-rc[12] fails to build for arm on an x86_64
box using a cross-compiler:
FATAL: drivers/net/wireless/b43/b43: sizeof(struct ssb_device_id)=6 is
not a modulo of the size of section __mod_ssb_device_table=64.
Fix definition of struct ssb_device_id in mod_devicetable.h
The following patch fixes the build, but given the discussion in
regarding the fix for the module device table definition for m68k [1],
I'm not sure that this patch is the right thing to do. However, the
fix for m68k was implemented in 2.6.25 [2].
diff --git a/include/linux/mod_devicetable.h b/include/linux/mod_devicetable.h
index 139d49d..0471294 100644
--- a/include/linux/mod_devicetable.h
+++ b/include/linux/mod_devicetable.h
@@ -351,7 +351,8 @@ struct sdio_device_id {
struct ssb_device_id {
__u16 vendor;
__u16 coreid;
- __u8 revision;
+ __u8 revision
+ __attribute__((aligned(sizeof(__u32))));
};
#define SSB_DEVICE(_vendor, _coreid, _revision) \
{ .vendor = _vendor, .coreid = _coreid, .revision = _revision, }
Please CC me on replies as I'm not subscribed to the list.
Gordon
[1] http://lkml.org/lkml/2007/11/28/12
[2] http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=7492d4a416d68ab4bd254b36ffcc4e0138daa8ff
--
Gordon Farquharson
GnuPG Key ID: 32D6D676
next reply other threads:[~2008-02-18 22:03 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-18 22:03 Gordon Farquharson [this message]
2008-02-18 22:08 ` Michael Buesch
2008-02-18 22:13 ` Russell King
2008-02-18 22:24 ` Michael Buesch
2008-02-18 22:34 ` Russell King
2008-02-18 22:43 ` Michael Buesch
2008-02-18 22:50 ` Harvey Harrison
2008-02-18 22:56 ` Michael Buesch
2008-02-18 22:53 ` Russell King
2008-02-18 23:00 ` Russell King
2008-02-18 23:17 ` Michael Buesch
2008-02-18 23:42 ` Sam Ravnborg
2008-02-19 0:01 ` Michael Buesch
2008-02-19 4:59 ` Gordon Farquharson
2008-02-19 10:41 ` Michael Buesch
2008-02-20 0:44 ` Gordon Farquharson
2008-02-20 14:44 ` Michael Buesch
2008-02-20 19:37 ` Sam Ravnborg
2008-02-22 4:24 ` Gordon Farquharson
2008-02-22 12:08 ` Gordon Farquharson
2008-02-22 14:07 ` Michael Buesch
2008-02-23 4:34 ` Gordon Farquharson
2008-02-23 5:51 ` Michael Buesch
2008-02-23 10:14 ` Gordon Farquharson
2008-02-23 15:58 ` Michael Buesch
2008-02-26 14:37 ` Ben Dooks
2008-02-26 16:12 ` Gordon Farquharson
2008-02-19 5:32 ` Sam Ravnborg
2008-02-22 13:13 ` Matthieu CASTET
2008-02-18 23:04 ` Michael Buesch
2008-02-19 8:37 ` Geert Uytterhoeven
2008-02-19 10:34 ` Michael Buesch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=97a0a9ac0802181403ja79c32v864b093414b2755@mail.gmail.com \
--to=gordonfarquharson@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mb@bu3sch.de \
--cc=rmk@arm.linux.org.uk \
--cc=stefano.brivio@polimi.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®