From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 39BE7241A11 for ; Wed, 15 Jan 2025 11:55:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=205.220.177.32 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736942127; cv=fail; b=gLzFqekLamHU9rUqVQ5RPXQQ7/Hcs2SSTV5/pLb1ETWCCfLrUgUrcqdDM2IOL01jrWhqjpRFEB72AwoRLZeKUFYqCNIeAuvCGjNt5xG//8fOYCuJ3aZUovQ2gCr8XYjq91F0n3g51n/f0+dsAtrC1J4ajUzuNThUQtNa6OzwCgA= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736942127; c=relaxed/simple; bh=qJy3RsUokmLRe2MaozgK139BjR/GzB8jPmybjBDJuEo=; h=Date:From:To:Cc:Subject:Message-ID:References:Content-Type: Content-Disposition:In-Reply-To:MIME-Version; b=So95xWNuR0Kvbr8MjBg5x+RgRYqJgxyzOMRZo+qSLlzHApJk7L14w/0ML3Pjp54c+9y7pz34vp9zB2xHk32Ic1UA0Owd0rPT+Ec0gZnZIx1/UR7GfVeAWS1hBHtezh4rWFyByP+a+3CP8+KFZdmCxNDz0r6LC4Oy2SVgMJeW1rs= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com; spf=pass smtp.mailfrom=oracle.com; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b=I0ccE8aT; dkim=pass (1024-bit key) header.d=oracle.onmicrosoft.com header.i=@oracle.onmicrosoft.com header.b=OslNh26c; arc=fail smtp.client-ip=205.220.177.32 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oracle.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="I0ccE8aT"; dkim=pass (1024-bit key) header.d=oracle.onmicrosoft.com header.i=@oracle.onmicrosoft.com header.b="OslNh26c" Received: from pps.filterd (m0333520.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 50F8tpdb030209; Wed, 15 Jan 2025 11:55:06 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=corp-2023-11-20; bh=RhC49Wlua325vzgK/H y2VtF862Jc0+Ewzqw9+x2LwX8=; b=I0ccE8aTrIMOePXeHq2v75ZpmALR8yicFd 6ZlvslbhDdysSIRNxavoxnZ5L7mz7sLgUEfZ57Ohv0HTOm3YKg/W8rohwR7VUSY3 w1xcNUe540fNuVpo42yBADY48ctZ5BaItFlNFUmsqkHAuw3s+AOpsXTh6tpoz+Fj LyDtLbkI+R4N8z2xSTIwcAmrxawaa5lT/ReSO3pP4eo7toTaAOgzR3RKtWCcoNnp ptBU/P+afloAm7QMsbOHGRqhMUWwj8t0VlDTkB+GHfm3x0LXuR+d25BdOhi3Z/rq bDXMxhoPLRsSdGFrESyge/gvOx/u75yATH6J3q4J38K5oCWGfy3A== Received: from iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta03.appoci.oracle.com [130.35.103.27]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 443gpcr1y1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 15 Jan 2025 11:55:06 +0000 (GMT) Received: from pps.filterd (iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 50FAXdKp036293; Wed, 15 Jan 2025 11:55:05 GMT Received: from nam12-bn8-obe.outbound.protection.outlook.com (mail-bn8nam12lp2177.outbound.protection.outlook.com [104.47.55.177]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 443f39we7c-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 15 Jan 2025 11:55:05 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=dZQ1aCEIFFPaa2/LQxN301EsPT5EEo0QBdzi6jhmODyu9r+ywCE7jv89a5c10aIJ6EBuqPGE2oqgWxjIt/MEejwe4zq9pVmfYJVhvixrZQTsCv4HGdEPlL+RbljoRtTkPT2rY82BwLDqKZL51fVeXw3YQipFLjz2Apa+MTecrbMO6zS6/hMBcjFT6m1hj+rxv2mKGlSUXHNr1IU/bwXzzhV64of1zqmCEzai8nG5xowzIH4FKbdeVzAnQKvXAuEomQJOkrSKVj0A3sDuxGy/KxeNxgfrggZF1Uo2tH49QUesUrI/SyGZq0n8t9W3fpJUpOgDBAS+aMHw2wMttD6qkg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RhC49Wlua325vzgK/Hy2VtF862Jc0+Ewzqw9+x2LwX8=; b=jKRohRSeexu68zqp0M2TAdLasviD1axpbSawIRL9iuA8uz1qMDTS0wGX1Kn2Kcpa50sql7mw1CRwG4tNTPYdnZRsabig3iIfvTsYxiUSdZGg4JZe49aZaCwib/hqF23pyYFIjoJbe9lA3wWMY2/eUn05pXkF5XjdFuxJy0NdRJ2p9c0NC5hKkCVACNEdDRtvyvTcl+DJ+xpIhvnfzKIrWkVHlaBqAJISVJNSMydgy91xaTPJ/EnbI7r2dlUz0fv0BZkcoK8Knfvt3hzwOLRnqRZrhUX57TjAODfW4NhYAfz5nx1wSWRFsqvAkLkOqvup2vQK0YMNgGOf5+L9SD5IDQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RhC49Wlua325vzgK/Hy2VtF862Jc0+Ewzqw9+x2LwX8=; b=OslNh26c6JGjvjFwJD0dXphXll+NI5XkAeyrOr86LlOUfWz4V2GHWm4mQ+BMzgJbeUL/KHneC12rzgjxDTiTrRv1B0e3vWcaWm1ff9A+aOuz1cs8YuD56xsg6ZVIY69ztdvcH8GF0YRbyJ3esadbJ6D5P/OZcxpQvshmt1NCX8A= Received: from MN2PR10MB3374.namprd10.prod.outlook.com (2603:10b6:208:12b::29) by CH2PR10MB4248.namprd10.prod.outlook.com (2603:10b6:610:7e::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8356.13; Wed, 15 Jan 2025 11:55:03 +0000 Received: from MN2PR10MB3374.namprd10.prod.outlook.com ([fe80::eab5:3c8c:1b35:4348]) by MN2PR10MB3374.namprd10.prod.outlook.com ([fe80::eab5:3c8c:1b35:4348%3]) with mapi id 15.20.8335.017; Wed, 15 Jan 2025 11:55:03 +0000 Date: Wed, 15 Jan 2025 11:55:01 +0000 From: Lorenzo Stoakes To: Dave Hansen Cc: "Liam R. Howlett" , dave.hansen@linux.intel.com, kirill.shutemov@linux.intel.com, Shakeel Butt , SeongJae Park , David Hildenbrand , Vlastimil Babka , Andrew Morton , Jens Axboe , Pavel Begunkov , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Ryan Roberts Subject: Re: untagged_addr_remote() in do_madvise() Message-ID: <97a0dc3d-2125-4e58-b923-e9e944975e6c@lucifer.local> References: Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: LNXP265CA0089.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:76::29) To MN2PR10MB3374.namprd10.prod.outlook.com (2603:10b6:208:12b::29) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MN2PR10MB3374:EE_|CH2PR10MB4248:EE_ X-MS-Office365-Filtering-Correlation-Id: 0fcebe22-aa7e-40d7-73ea-08dd355b7230 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|7416014|376014|366016; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?j+PdcBsJkjMBES86ADKVKf8GkW2Lc1MHzJq1sPtEr+9YMXXmhPev9YfkWaov?= =?us-ascii?Q?/1/yKYG6IgUhGse2L2P2pfRKtoqfDxaRdktl8o72KJPJuaCBTvNClPoR6lTz?= =?us-ascii?Q?9ZWFkyaPcwRp8yIFTHMAxyKXFq/aX29DIArLX06RihQW71V8VBFqFCvnHJ9u?= =?us-ascii?Q?pwhQuEXI9chcJi1lFv1p+ZMJguEMDJGyxJbpA7d88XoTdda97b4aQHS7rjfv?= =?us-ascii?Q?zTzSjHuCFHj45Ex/drDp1KkXcB42hyXLcYya5CDH6wdvKz5DEakQHNFj9YjB?= =?us-ascii?Q?1xEdg3Drv5egkeGBS/EBFBASa9cEXFgTKnpwXlPeJqkilqFfqGyh9BtoDQdh?= =?us-ascii?Q?1Pd6D8wGfpbzVldLOij8vW63UbUNRgELtDGuE6+vEEGnxe2OHEZn8aZfAJNq?= =?us-ascii?Q?KcCMihLZjxJQ9ExZgt0WacYCNnZJvSz7H1b+585BjHo7lsdriCwMedVHFywr?= =?us-ascii?Q?jgRsqTg+otanYRKqUiim/CvP/8/4cOAKiPtlEg5sapax4V+8cXVA74UmsuK+?= =?us-ascii?Q?z9B6wKQRglctM5ZSKkDfT15k3Q40k3P9v20k/GjA/4JP781ls26Z/nFxO9zT?= =?us-ascii?Q?VFm/jecX/AW7iXhHEsLaRxXDJ0+suBxlDMqE6PyhhMo47QEf+utrirzZngb/?= =?us-ascii?Q?UJz86ekkBGIN+CpFN9c/aGJSVfKbclNEziMbyT2uvyzZZT2goFKUY0x8wPgp?= =?us-ascii?Q?GXI+/kVx/CAJ4pmKAVHIatEy7YWczayFw1kvucsprNiI3X2nJOSL5LXFzXiC?= =?us-ascii?Q?gha7XFRBcY8wY00nmYAAOlmlQP1mzqMrHqkIu01sSpJ3rIbyfHIuBiibibIc?= =?us-ascii?Q?w95ZEdnKMd0DMCDDLLe9ePzYWrsLwmkQj3ixMo9Qwpnd9IvrVViT/Y5fnexx?= =?us-ascii?Q?0FWme2ngbF6d3+SNvtB2PluKp5vjHts4qTi8i+AB4zacSg5PNvxhUwnhhbnE?= =?us-ascii?Q?YjPK8NXmrBIwZDC67CWndPAOvzZ9oY//LuAYagbH8YN5mXfS84R+0vOakcxT?= =?us-ascii?Q?R7ruxeMJdHhoRsxCH/EZ98TRTgd7thBunJk7c5AYBVSho66rT2CK2kA2zHSR?= =?us-ascii?Q?ScbQENkscHYCm/xejmutJIpKtu8F3TJxJUWdL4rGX+NRoemrQjfpy5npPMAI?= =?us-ascii?Q?FyjA1TX299qvMDaV5Ocf5W9ZsQ4Scyp2S3i1R+U0FMCd9nYAshymGpko4EoS?= =?us-ascii?Q?eUzhn4Q0OIopfhsKItnVBTi4bz/6NNLuqRGO6aYOtrIFiGGZWMEpUbOV9gKb?= =?us-ascii?Q?lkZmInxsAn4Jh3z9W6xYq2dPRW/vEVWTqw9/mq5Xuv1RK46BWFFD/nMroDSd?= =?us-ascii?Q?P8mhSEFWAr/qZZmOCByH41AmyCRnM9OGjtDargFlPwweolJ6DwzMaPLcGEp3?= =?us-ascii?Q?G/sJ3MFNtZ8+dtSDO/RF5UKDfQv1?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN2PR10MB3374.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(7416014)(376014)(366016);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?tYYCZAiFMAg4jx7P5JR9LXd+otZBAS9VJypfPdR+v87IlskTSjmcX7jPQLyW?= =?us-ascii?Q?lflEvB71ddJRjZjd8sYQZbUCbnfVnF3XpxLReFjqq/dZKj/2vYAULNAMB0P/?= =?us-ascii?Q?5cLfBaTtp7H1TQuvjnFpQzu5Z9X5wOGkU6xBAegzqjAw6b5LGLXIute6IyQN?= =?us-ascii?Q?sL1AsRtTjLgEAhTCRtsk1INeOa8dgBn+MvhJK97QAWVxv2a6DdyIBp3LrQrt?= =?us-ascii?Q?VXHHKx9PTN4HnXmmrJsbnmPN4t2+br5v+roDYjc/y3QGTvMGzJkgO7AAzodX?= =?us-ascii?Q?t6s9oh42lvAhw34XhnWPRZxUET2L9joAh+h6EUdkSyuLvEKkTgkXb+/B4HR0?= =?us-ascii?Q?vdo+hHWsBh3IyoTGJSXZKVrPQKzb/Gt7FUo082m4YAqzjuP3GfjN7F9Vle2U?= =?us-ascii?Q?urOTxOo/B5rfusEG/FXVgxwgljBH2F513zhxZRp/K9yxDIKlGK1LNILD+Yp0?= =?us-ascii?Q?7umK0iQBxxLwINBWPYD1znUh0fGMgtEmQ8tnPUi3kZ3zZFCLo7g//gYkIUm8?= =?us-ascii?Q?aRirTYLpCk3h2Sdm3TEiuRN0vqr/y6jCroWL3TFrfdy0ryz1SX/V4Mr3GLgO?= =?us-ascii?Q?ARq1dytdZepXxNeprO4JPTgAbA/dpQjtDSosHi9/zxON6FJScqA0q1MzxRED?= =?us-ascii?Q?1IWy8OsMLA1tf4VXNVvkgGWRRuCaTlWrMs7c374xTqgToi3J5c3kB34aIPMo?= =?us-ascii?Q?54t6MQvniQjvV6xlRI5r5124aZ3GovbNpQxnaY8TpRRvJr8jUVkXNdO4xu52?= =?us-ascii?Q?aVDFblXZLaJNhljxvgevZJ13VXuthiQNpllcpJydqoiEsPUUSp+5bNDoy0+s?= =?us-ascii?Q?cFYzdQtIbjgz0AcV3wO5kMf/8q/FQ4jVCQ9J4H/bnUncZO2MeYngT0c8B/jZ?= =?us-ascii?Q?4kov10mEA9xfjSry1x+YFswsGbFLK2rpc917JUR1Lq3lvSl6edfoZ31dgVYQ?= =?us-ascii?Q?/2zMUnNCmtGyDoMKqopccE7EH9Hn0Gqh8s76w+ERANUfyDN6OA+IExeQJKia?= =?us-ascii?Q?0WKCiGKjCeXcUlc7xrYjDyjoa+c4fdSrtLLYGhlqK+AVnrmrYMynY0uEQIU1?= =?us-ascii?Q?7W9baeruxsxwWnAlrSyS5DJBW3J0ePY5EaG8Lzbf4HC9GYLy4ujrNw695xJO?= =?us-ascii?Q?2Pj5BxBnZsT/JwF8pIboWKOQAfNmLhwiMsTMOsbkkLFoDknRTcNlczV3t91L?= =?us-ascii?Q?hJPFIJAc9eMUoySIbYmZjp6B3He2NT6C6s+3ECiR2Dt3TMaVOvtAuxo+A3eg?= =?us-ascii?Q?qQNUqLeX/zO/PJmKqRfPYS28tV3btVYhK/bXc4v12SHmk6uEBxfsL8A8iDmA?= =?us-ascii?Q?9bLL1OGXedga2uHvApVD3TWwGiZfgy01+8UdUnHzgmkJTluvC9a4kj6f2S2V?= =?us-ascii?Q?H3A7wlz6NgDqLa7UYFF+qEkH2NTx6vZC04SyR+txhklFAcHf3IP8EvNTsMdF?= =?us-ascii?Q?MiEBggT23mGb/XQdFx+W/yIt6HQH35+Tl/l3UTGqaMweI3z7S7tIdyOklHIt?= =?us-ascii?Q?ps3vouq96LLrsg3aVmkfmOICDCRCBbCIVv/S8KlsuQcTMcwgzIEyQmgnHPGg?= =?us-ascii?Q?J0cfxlZySV+pfjmJY2XEd6ftnJ3PLqTLRsFzPNDa/9dbDbHoYCQscnMr4xNQ?= =?us-ascii?Q?ug=3D=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: W0+5FWi4ZCcvDooAoUmTq1Oxz2CW5sj4j0AnLnG2SVraGdsvpg2nNFddOlas+yJE4JgkJ0EZQkXxve0glSa4nJ6i9aNIswQ77xBD0MOnEZJY4WPsWjlvjCSnEFDkJTBoWiA/QoYNFFxKpTDY8Zfg2AYzjQXpSPbR2YalTJIDKYT7oVoWlisOgy4JSmCd2lRaqdhoh0zi51YUhmFDv2qZ1AjKwAYYKqUkoF7+HcRSerND/4q7lZ490fROGcbqf2leXnkhlSsA+LQYhymOLCfSsadka67eaVh3ofeV/6KpaWM4Tv26ntG7zwDdGN1sPktMd3ZAedFLFN+LOc+iCyxJK7uXM54NQb4np06dMri6oRTlJZ2Yz1e3afSr0nO7ARSuIbkKHsALeKodeDjkVLiOVl7O0yqAO9iCAVhxjhMWJ8O7/TKUR8bHkQvrKuxxKomqx4XBL4U1nefxANtPUOFaB1suGZTmNTHkD73OdqVj5QuwFYlhBNSTxtTzktWfX1qUWl4+UnWtKIG0Xt5LMvicXzDncRaa3GSLOv2kiVSZ//7Kyr1SIIbYp6P5MhiijLaaWqco3cclooL6MSxgYnHaj5jF8xRTTagavBMSvkjSIec= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0fcebe22-aa7e-40d7-73ea-08dd355b7230 X-MS-Exchange-CrossTenant-AuthSource: MN2PR10MB3374.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Jan 2025 11:55:03.1473 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: SFVYmtGGi0n+vrgnepkvBiC6Cu0BfADj7Khyuupt6kre/+PCxVxy4XDv+fUzWDibffUc1n1Rsqkdf/L7zRdZxgOMyhxXzgr8CnTIbgwuRws= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR10MB4248 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1057,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-01-15_04,2025-01-15_02,2024-11-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 mlxscore=0 malwarescore=0 spamscore=0 suspectscore=0 mlxlogscore=999 adultscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2411120000 definitions=main-2501150090 X-Proofpoint-GUID: XeuEiyXs94ZWTpDKzv4f4q9ft7QLY0sp X-Proofpoint-ORIG-GUID: XeuEiyXs94ZWTpDKzv4f4q9ft7QLY0sp On Tue, Jan 14, 2025 at 01:13:36PM -0800, Dave Hansen wrote: > On 1/14/25 12:41, Lorenzo Stoakes wrote: > ... > > However, MADV_HWPOISON, MADV_SOFT_OFFLINE seems fundamentally broken for tagged > > addresses: > > > > #ifdef CONFIG_MEMORY_FAILURE > > if (behavior == MADV_HWPOISON || behavior == MADV_SOFT_OFFLINE) > > return madvise_inject_error(behavior, start, start + len_in); > > #endif > > > > ^ this is invoked before untagged_addr_remote() is called (as no mmap lock is > > acquired) and so no attempt at untagging happens at all...! > > Except this call path: > > madvise_inject_error() -> > get_user_pages_fast() -> > gup_fast_fallback() > > does its own untagging: > > start = untagged_addr(start) & PAGE_MASK; > Yeah you're right! Good spot. > It might also have some funky behavior if start+len_in overflows. But, > just as in the other case, it's invalid to begin with so I think > userspace kinda gets to keep the pieces. Right yeah. > > But I do 100% agree that this is non-obvious. In a perfect world, tagged > addresses would get untagged at the user/kernel boundary in _one_ choke > point. But the world is hard and that would make things too easy and > then we wouldn't get paid the big bucks. ;) Yeah agreed especially on that last bit ;) I think it'd be good to have a comment there, I will stick on my todo to add one. Or Liam - if you're doing some changes here - maybe you could add? Just something highlighting that gup_fast does the untagging? > > To clarify things, I don't think it'd be the worst thing to just move > the madvise_inject_error() down and have that case acquire > mmap_read_lock(). Sure, it's not required, but it's basically debugging > code and I can't imagine it's avoiding the lock for performance reasons. Yeah it's odd that, but that code is going to the lengths of using gup_fast so I have to assume that maybe some debug user really does care about perf? It'd need some more digging to really feel confident to use a lock there I think.