From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f175.google.com (mail-yw1-f175.google.com [209.85.128.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 87FA2456DE0 for ; Mon, 24 Aug 2026 14:44:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787582694; cv=none; b=PUSd4LafN5pY+Odbqt9Qz6k5LB3Gz3qaZpjb5ia52BOxjQdVb5LrC0u70oZJ8jr5Oz+j8aJM8qPGyDlpoEeGh+Z2pc7B+51nQyyvqIoiXyksBIttpJbcpKf96UU8Suh7E9sPsVY3rDUh/rMclA4G3wFbMVv+BsA38YdL1HrCMgs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787582694; c=relaxed/simple; bh=apGggQcJp2WV1URiHg8Asmh4iwaxGu1pF3vH60oXvTw=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References: MIME-Version:Content-Type; b=fody2V7Qf+PqAwOxcqxOIhza2UUc2lgI76UxyyC2+1y9UzLE2y3klvTtJ3P30MujmLHb+3YSR8lUQv4JjhBXVSnY9apmqgfLfIlcynhTzdFIKksBQrzWDLTo5NGk0gtbeHC7iL9P/9Lm8UPK6XlAVc1Z0/AnyPi3LVvqT5AbIJA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=vjfA+dv3; arc=none smtp.client-ip=209.85.128.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="vjfA+dv3" Received: by mail-yw1-f175.google.com with SMTP id 00721157ae682-81ea0b7d137so30765987b3.2 for ; Mon, 24 Aug 2026 07:44:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1787582691; x=1788187491; darn=vger.kernel.org; h=content-type:mime-version:references:message-id:in-reply-to:subject :cc:to:from:date:from:to:cc:subject:date:message-id:reply-to :content-type; bh=0mZ5Gk4/1Pu5bK3S+WjW2BlP4j/qxWTHvLM7mSgUCfk=; b=vjfA+dv39bRlVtK0b0GiuzgSC5Dw1NWDJhcPFIX+5i1SXqDN4Poyu8PuB8wxuWaklV vSn+QfqIxrvfnXLqYLZGfBzwXcEU7Ohsog4WOxIHMfRylgketZWsD6uvG8IpdRqaCq36 av+sgXujeDW4AkrUEsvxcrhKTH3v0xkbKO7nJW0gNz3CTAwC5eRpASfwRQGgR4bD9NgD oEhHl4iFJ4T1KC8HnbPrLYQ+L/lEPhnZQhc6Guec/9L+By7XpAyI9eqgFlZZEbxQEml7 eEDt/MZvpYnD2UkNDh7s0MKICzHOW8oxHS7v3v/G1I96pVF2rwpJ5n1u6d7Wjc+48yc0 04hw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787582691; x=1788187491; h=content-type:mime-version:references:message-id:in-reply-to:subject :cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=0mZ5Gk4/1Pu5bK3S+WjW2BlP4j/qxWTHvLM7mSgUCfk=; b=NFE04RUajsSyr2wdWojWAxJCRk2hDEYiYSYXoGHFEuj3KaJ4NtxdSO2HfX7wo/FBmR 4cgKEjfq3rY07J7UpUW/+Ifm+InH+LapCogs86HTD3YJwSlqWTvPt1Gi8iT6N5F26B9D UfU9S5yMjxkxR5Jwp3pK7jXFV0C799X9Qub92cxADcembGjSC7WNvN6VSbniPhozX5XO 9Rv9VJeauaPeYyExYB48uymaMd1ZJDtj2oXshtzXVkBu6ayWkFZdYdwGHbnIoDZhAVZ6 TMIAAMZCkIotb9Ai9mZ4wHI6vfC3L5mTQZnXyvH2Q+DbM9ST0onYRuC9iapdGAx3Yvcb XKIA== X-Forwarded-Encrypted: i=1; AHgh+RrUcRvw/NESycaeFHZueg5U4EEGyCsTeHP/V2M+AFjaIh3AcBsBYRGPF9RlIKHnsGplK/XH0WCh8Kgm890=@vger.kernel.org X-Gm-Message-State: AFuF++nKazH/Vuyj32kTSbWQrL8xFaxLQaLlm85CFPRYADg0J277PPiK wc8CTAjLeEnMhBy0DWeJ3bk6IhSRJA6HmpAwShb0gGqKfpMsL76hdv6N7gYNQAXwvg== X-Gm-Gg: AR+sD137pGJOua6qVEfVnAkQuNHZXBPOB4K7Kw2n3wrDjjqbBExZ5DRCbtXd1KHJQuh R4Vxc9BOlGZUaS7zQgp0FY3zWTWnUc8vwRBpjYIRvXnS4U6GDZ/jwMzn5UOgv1JD1zDdiQ7D26w huigVOkIEdZdPXRZ0hdozUN0/EDG5nUn2bPxsIXf7QmriJtrl72XY167UVesPTAjIllCWF2J/qu /HBcEW/YWhg0Pvwhz4C2QXMrtLEQ0Om0GoaSXvjAy+SHad0khcLyRpq36tS7oVGXnC8SxzCtfd8 KU7ZY2kti/GYM+9/3jMOgCe+bb4Zt3MjqLlYHpfiIJFAUrF+gHMBDrmjYtxuOYbFV68EWJryuKL 6QPWVHZxgaTu3IEwbD5qEI3Cw3zvprMpfwPVU03osza7b2bzdPn0Qw0oN67vshz0pB0FFr7NZzm MUzp9QXH4Za2c/EzpYcJ9EqJqYYpsE2KP8oX+MbenOxRgK/dOwuZyh4wvyAqzn7ghL/0Qfp2tVl NtGJBiQJSv9dbldA4zI4k9TXbrAubrWRYa9JYz03n249sdh X-Received: by 2002:a05:690c:5:b0:853:f007:7557 with SMTP id 00721157ae682-853f016ba69mr7002677b3.19.1787582690568; Mon, 24 Aug 2026 07:44:50 -0700 (PDT) Received: from darker.attlocal.net (172-10-233-147.lightspeed.sntcca.sbcglobal.net. [172.10.233.147]) by smtp.gmail.com with ESMTPSA id 00721157ae682-84cacac521asm34834717b3.48.2026.08.24.07.44.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Aug 2026 07:44:50 -0700 (PDT) Date: Mon, 24 Aug 2026 07:44:46 -0700 (PDT) From: Hugh Dickins To: Andrew Morton cc: Ackerley Tng , Alexander Viro , Baolin Wang , Barry Song , Binbin Wu , Christian Brauner , Christoph Hellwig , Christoph Lameter , Claudio Imbrenda , David Hildenbrand , JP Kobryn , Jan Kara , Jens Axboe , Johannes Weiner , Kairui Song , Kiryl Shutsemau , Lance Yang , Leonardo Bras , Lorenzo Stoakes , Marcelo Tosatti , Matthew Wilcox , Mel Gorman , Miaohe Lin , Michal Hocko , Minchan Kim , Muchun Song , Oscar Salvador , Peter Zijlstra , Qi Zheng , Rik van Riel , Sebastian Andrzej Siewior , Shakeel Butt , Suren Baghdasaryan , Vlastimil Babka , Yang Shi , Yu Zhao , Zach O'Keefe , Zi Yan , linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: [PATCH 22/25] fs/fbatch: drop_caches invalidate_bh_lrus() not lru_add_drain_all() In-Reply-To: <14a16945-529b-8bc0-ab38-3ea97e54e223@google.com> Message-ID: <97a16bae-dfe8-b58b-f0c9-6eafb3881195@google.com> References: <14a16945-529b-8bc0-ab38-3ea97e54e223@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII drop_caches has no good reason to lru_add_drain_all(), now that the per-cpu fbatch references are gone; but it may have good reason to do the invalidate_bh_lrus() part of it. Signed-off-by: Hugh Dickins --- fs/drop_caches.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/drop_caches.c b/fs/drop_caches.c index 49f56a598ecb..054af78e6a2e 100644 --- a/fs/drop_caches.c +++ b/fs/drop_caches.c @@ -10,7 +10,7 @@ #include #include #include -#include +#include #include "internal.h" /* A global variable is a bit ugly, but it keeps the code simple */ @@ -60,7 +60,7 @@ static int drop_caches_sysctl_handler(const struct ctl_table *table, int write, static int stfu; if (sysctl_drop_caches & 1) { - lru_add_drain_all(); + invalidate_bh_lrus(); iterate_supers(drop_pagecache_sb, NULL); count_vm_event(DROP_PAGECACHE); } -- 2.51.0