From: Dave Hansen <dave.hansen@intel.com>
To: "Reshetova, Elena" <elena.reshetova@intel.com>
Cc: "jarkko@kernel.org" <jarkko@kernel.org>,
"seanjc@google.com" <seanjc@google.com>,
"Huang, Kai" <kai.huang@intel.com>,
"mingo@kernel.org" <mingo@kernel.org>,
"linux-sgx@vger.kernel.org" <linux-sgx@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"x86@kernel.org" <x86@kernel.org>,
"Mallick, Asit K" <asit.k.mallick@intel.com>,
"Scarlata, Vincent R" <vincent.r.scarlata@intel.com>,
"Cai, Chong" <chongc@google.com>,
"Aktas, Erdem" <erdemaktas@google.com>,
"Annapurve, Vishal" <vannapurve@google.com>,
"Bondarevska, Nataliia" <bondarn@google.com>,
"Raynor, Scott" <scott.raynor@intel.com>
Subject: Re: [PATCH v10 4/6] x86/sgx: Define error codes for use by ENCLS[EUPDATESVN]
Date: Mon, 4 Aug 2025 07:19:52 -0700 [thread overview]
Message-ID: <97a3e5f8-92d7-43f0-ab99-77e248589adc@intel.com> (raw)
In-Reply-To: <DM8PR11MB5750515E878BAC6199882330E723A@DM8PR11MB5750.namprd11.prod.outlook.com>
On 8/4/25 00:21, Reshetova, Elena wrote:
...
>>> + EUPDATESVN = 0x18,
>>> };
>>
>> This update is not consistent with the changelog nor the patch subject.
>
> I can remove the alignment fix.
It's not the alignment.
It's the definition of EUPDATESVN that goes completely unmentioned.
...
>> Ideally, we find a way to relay this in a very succinct way.
>
> Could you please elaborate what you mean by this?
> Changing the description? The name or?
Relaying it in the comment next to the definition would be best.
next prev parent reply other threads:[~2025-08-04 14:19 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-01 11:25 [PATCH v10 0/6] Enable automatic SVN updates for SGX enclaves Elena Reshetova
2025-08-01 11:25 ` [PATCH v10 1/6] x86/sgx: Convert sgx_(vepc_)open to __sgx_(vepc_)open Elena Reshetova
2025-08-01 16:42 ` Dave Hansen
2025-08-04 7:16 ` Reshetova, Elena
2025-08-01 11:25 ` [PATCH v10 2/6] x86/sgx: Introduce functions to count the sgx_(vepc_)open() Elena Reshetova
2025-08-01 16:45 ` Dave Hansen
2025-08-04 7:18 ` Reshetova, Elena
2025-08-01 11:25 ` [PATCH v10 3/6] x86/cpufeatures: Add X86_FEATURE_SGX_EUPDATESVN feature flag Elena Reshetova
2025-08-01 16:46 ` Dave Hansen
2025-08-01 11:25 ` [PATCH v10 4/6] x86/sgx: Define error codes for use by ENCLS[EUPDATESVN] Elena Reshetova
2025-08-01 16:57 ` Dave Hansen
2025-08-04 7:21 ` Reshetova, Elena
2025-08-04 14:19 ` Dave Hansen [this message]
2025-08-05 10:11 ` Reshetova, Elena
2025-08-01 11:25 ` [PATCH v10 5/6] x86/sgx: Implement ENCLS[EUPDATESVN] Elena Reshetova
2025-08-01 17:12 ` Dave Hansen
2025-08-04 7:39 ` Reshetova, Elena
2025-08-01 11:25 ` [PATCH v10 6/6] x86/sgx: Enable automatic SVN updates for SGX enclaves Elena Reshetova
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=97a3e5f8-92d7-43f0-ab99-77e248589adc@intel.com \
--to=dave.hansen@intel.com \
--cc=asit.k.mallick@intel.com \
--cc=bondarn@google.com \
--cc=chongc@google.com \
--cc=elena.reshetova@intel.com \
--cc=erdemaktas@google.com \
--cc=jarkko@kernel.org \
--cc=kai.huang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sgx@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=scott.raynor@intel.com \
--cc=seanjc@google.com \
--cc=vannapurve@google.com \
--cc=vincent.r.scarlata@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®