From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 50AB23890E8 for ; Wed, 4 Mar 2026 07:52:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772610753; cv=none; b=PRepxJLvkyZpVI+bEslPx0fKomKWnJ47FtAlbBcsHBYa1yO1d5cTeFSCjx8u+cEf1znEOKEoNEcy4IxUzWN5GMapyUC7/oArSl7FsXBwNbvl2le6z1wdK8JqnXMahTW5Hn7v52xoHg+91UFLrvJIEOtOwY+W9aPUInYc1QM9w6s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772610753; c=relaxed/simple; bh=EcLDMvBjjbTD/cKF5y1BkO7ob6e6OBIu3jcREkFicZE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=uMUoCN6Mm61b6KGRZREYTaHGQSRel9sAvZMPmhJYOMpSpj6tplbaJLipj71emedTaLx6LljJnuSjFWcy2xhsu7zJnRcJJQr5raMgZjIG4J9vKq/STPj03xyMnznrYH4XA9bHJC/xIQFNwG4Np4yv58EyO6AWERkX4C9RwFoO7wo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=FNnTPrmD; arc=none smtp.client-ip=209.85.221.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="FNnTPrmD" Received: by mail-wr1-f50.google.com with SMTP id ffacd0b85a97d-439af7d77f0so3147995f8f.0 for ; Tue, 03 Mar 2026 23:52:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1772610748; x=1773215548; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=iaji8MiSwOMoEhpHJ9TfGIIdRoqWhERpR7BNI+IYVW8=; b=FNnTPrmDvPeJsl7KgOkZBHjigGbAfeWKOyNkXPj/ux+4SYrQn4MTPSHMrouYmSgqIa YuFUNmIKbBGjpl8HC4GdNNkeY3ChhyRlnRpH4V0ri52oDep3hlSTOoliQedMT0Q80eJ/ u74NOjzU2/l3poPflXJgxfZbtt5Jd1H9iW1nzjA/GbFpj7Don+kWtej1SpQqfk5AYi09 Eb9dLae/TK4h5q3fJZKI1g95C/udZxLAoLe0Upb2/LygfKo5T5+smDUdi37tfQZDsldY 1va/Z7NSVaRop+Elt1Nxco58Kr4VF80cTnrvUk2M/x5YabCEcP0q7FV2F+ubPjbxO5dH 6ovw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772610748; x=1773215548; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=iaji8MiSwOMoEhpHJ9TfGIIdRoqWhERpR7BNI+IYVW8=; b=AJwJ4MJl6qSNDWuU7u6GjqArvP1GI/6blF0d2Uj8ds7EqST62G9oNp3kCktX1XhHLD Uc2yPzYcfNCp/dDl9mjyrU12AuO2iZZSdaIC7C7cDfMXXJBjbwy7K/JKKwIL+4papl0E h7CjK0axJB/0piMCBmr8XUXor/hwh85VgIBQJAt9uqtTwpr5AM9txrE42eBsuPq///wh haykF7RxxzwV9QnTJGuGMhQjcGWbW3mSz9QdLorie4oDVUUzOi/Zpq02P20+ZslEiV/m 1KodahRqZDfXZ4/aO6OOEqTIL/488x+xzzmWcNwXBimq/anKdeEEvHL01y/aEdIHIJTq 8isA== X-Forwarded-Encrypted: i=1; AJvYcCX5qX2jf1xtGYo6hvSavUUng4ggYj8b/TLXwBrp4En7vPZB9jAqJiYJm/geMGZ9sKkm0Yp8qbBtVcko0I8=@vger.kernel.org X-Gm-Message-State: AOJu0Ywm/SBNZR84zYw4rjgFCovuf4B9v6SUUV+kD+DSeUiiJlKEI0ku J8rxMU8eeLhiIWeAq8QXmALYaRJhFT/8SXe2kM8wL7NyoKLkUcH1mW9Uogy5bTFuxgA= X-Gm-Gg: ATEYQzxu27Ex1Q5sPyxizkIXStFh72i1HCZYy3Nn2wEhAT2Ctq/qKV0f0sXrpL8hRBY WYieCiCyaXnGu4Fb9FmoXY1u0o3/qzDN9+q+PHfHTwD6g1H7CgsEQcm6eTD7b9vgz9r5Xs9G7XU fJpAhPbuu07KZcmVCTHQM5nqxOotmp338p0shMeczfAQWZ2S1ThgfJH4EgkA6QA6Ie+LS4y4s4m 9Trb1Rb+D0c7f53JHeyV82cWCugx1VtN4CTVRuhyAaUVwBvipkL3qh9rIxCcSi7NQ5+hrlxNugK Xz5lFZbJgq6/wLBqKH69/BIMaIGf5Zi8cXaCjpM895A28X/h5Ny0I7B98xTQl67NvPSNmSgTDg8 eGBOL0735hzfrkovBhR/Sg13ME3XY3tVFVSwI/Vcaicb1Ak7LlZpP9HvdsA4H9Aul7v5tpy71H1 OcAii80ggsZoVTuOIProiYY414lxwO9m71TRed8VY9VA2/ZXW3Jt5AYOLEm1KNFBKB6UE8yUyTJ eqN0LYp6BvLvGeD+cxbfmqsn9CQ9dGZua5p+T+ltUhnxQNx4P4C4EEJPWsWQRPOiSdb9HtZxEk2 eIps X-Received: by 2002:a05:6000:4301:b0:439:b886:20d3 with SMTP id ffacd0b85a97d-439c7f7e5b7mr2101563f8f.15.1772610748337; Tue, 03 Mar 2026 23:52:28 -0800 (PST) Received: from ?IPV6:2a00:1028:838d:271e:8e3b:4aff:fe4c:a100? (dynamic-2a00-1028-838d-271e-8e3b-4aff-fe4c-a100.ipv6.o2.cz. [2a00:1028:838d:271e:8e3b:4aff:fe4c:a100]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4399c60f764sm42229774f8f.3.2026.03.03.23.52.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 03 Mar 2026 23:52:27 -0800 (PST) Message-ID: <97a56169-b71c-4ad0-8992-c6e2d381ff02@suse.com> Date: Wed, 4 Mar 2026 08:52:26 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/8] modules: Move 'struct module_signature' to UAPI To: =?UTF-8?Q?Thomas_Wei=C3=9Fschuh?= Cc: David Howells , David Woodhouse , Luis Chamberlain , Daniel Gomez , Sami Tolvanen , Aaron Tomlin , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Mimi Zohar , Roberto Sassu , Dmitry Kasatkin , Eric Snowberg , Paul Moore , James Morris , "Serge E. Hallyn" , Nathan Chancellor , Nicolas Schier , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Eduard Zingerman , Song Liu , Yonghong Song , John Fastabend , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , Shuah Khan , keyrings@vger.kernel.org, linux-kernel@vger.kernel.org, linux-modules@vger.kernel.org, linux-s390@vger.kernel.org, linux-integrity@vger.kernel.org, linux-security-module@vger.kernel.org, linux-kbuild@vger.kernel.org, bpf@vger.kernel.org, linux-kselftest@vger.kernel.org References: <20260302-module-signature-uapi-v1-0-207d955e0d69@linutronix.de> Content-Language: en-US From: Petr Pavlu In-Reply-To: <20260302-module-signature-uapi-v1-0-207d955e0d69@linutronix.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 3/2/26 1:42 PM, Thomas Weißschuh wrote: > This structure definition is used outside the kernel proper. > For example in kmod and the kernel build environment. > > To allow reuse, move it to a new UAPI header. > > While it is not a true UAPI, it is a common practice to have > non-UAPI interface definitions in the kernel's UAPI headers. > > This came up as part of my CONFIG_MODULE_HASHES series [0]. > But it is useful on its own and so we get it out of the way. > > [0] https://lore.kernel.org/lkml/aZ3OfJJSJgfOb0rJ@levanger/ > > Signed-off-by: Thomas Weißschuh This looks reasonable from my side and reduces code duplication. With the removal of MODULE_SIGNATURE_TYPE_MERKLE in patch 6, as reported by the AI, the changes seem ok to me. Feel free to add: Reviewed-by: Petr Pavlu -- Thanks, Petr