From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA385C433FF for ; Mon, 29 Jul 2019 05:39:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A34852070B for ; Mon, 29 Jul 2019 05:39:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726655AbfG2Fjw (ORCPT ); Mon, 29 Jul 2019 01:39:52 -0400 Received: from mga14.intel.com ([192.55.52.115]:9061 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725934AbfG2Fjw (ORCPT ); Mon, 29 Jul 2019 01:39:52 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Jul 2019 22:39:52 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,321,1559545200"; d="scan'208";a="322747182" Received: from ahunter-desktop.fi.intel.com (HELO [10.237.72.122]) ([10.237.72.122]) by orsmga004.jf.intel.com with ESMTP; 28 Jul 2019 22:39:49 -0700 Subject: Re: [PATCH] mmc: sdhci-s3c: Mark expected switch fall-through To: "Gustavo A. R. Silva" , Ben Dooks , Jaehoon Chung , Ulf Hansson Cc: linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, Stephen Rothwell , Kees Cook References: <20190729000259.GA24022@embeddedor> From: Adrian Hunter Organization: Intel Finland Oy, Registered Address: PL 281, 00181 Helsinki, Business Identity Code: 0357606 - 4, Domiciled in Helsinki Message-ID: <97a8a7d5-6d20-2a6a-5a62-24bd6c8c0ddc@intel.com> Date: Mon, 29 Jul 2019 08:38:29 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190729000259.GA24022@embeddedor> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 29/07/19 3:02 AM, Gustavo A. R. Silva wrote: > Mark switch cases where we are expecting to fall through. > > This patch fixes the following warnings: > > drivers/mmc/host/sdhci-s3c.c: In function 'sdhci_s3c_probe': > drivers/mmc/host/sdhci-s3c.c:613:19: warning: this statement may fall through [-Wimplicit-fallthrough=] > host->mmc->caps |= MMC_CAP_8_BIT_DATA; > drivers/mmc/host/sdhci-s3c.c:614:2: note: here > case 4: > ^~~~ > > Reported-by: Stephen Rothwell > Signed-off-by: Gustavo A. R. Silva Acked-by: Adrian Hunter > --- > drivers/mmc/host/sdhci-s3c.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/mmc/host/sdhci-s3c.c b/drivers/mmc/host/sdhci-s3c.c > index 8e4a8ba33f05..cefa0fb8cfde 100644 > --- a/drivers/mmc/host/sdhci-s3c.c > +++ b/drivers/mmc/host/sdhci-s3c.c > @@ -611,6 +611,7 @@ static int sdhci_s3c_probe(struct platform_device *pdev) > switch (pdata->max_width) { > case 8: > host->mmc->caps |= MMC_CAP_8_BIT_DATA; > + /* Fall through */ > case 4: > host->mmc->caps |= MMC_CAP_4_BIT_DATA; > break; >