From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752444AbdETKwK (ORCPT <rfc822;w@1wt.eu>);
        Sat, 20 May 2017 06:52:10 -0400
Received: from mx2.suse.de ([195.135.220.15]:37028 "EHLO mx1.suse.de"
        rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP
        id S1750823AbdETKwI (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Sat, 20 May 2017 06:52:08 -0400
Subject: Re: [GIT PULL] KVM fixes for v4.12-rc2
To: Linus Torvalds <torvalds@linux-foundation.org>,
        =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= <rkrcmar@redhat.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
References: <20170519184340.GC11087@potion>
 <CA+55aFybQF2pFMWL3_uUZ8sh7xoDd9L4Mw2MzCV_wC_112QXig@mail.gmail.com>
From: Juergen Gross <jgross@suse.com>
Message-ID: <97a8ffc4-dd0f-3e2a-0dc4-1ac46c993745@suse.com>
Date: Sat, 20 May 2017 12:52:05 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.1.0
MIME-Version: 1.0
In-Reply-To: <CA+55aFybQF2pFMWL3_uUZ8sh7xoDd9L4Mw2MzCV_wC_112QXig@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: de-DE
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 20/05/17 00:21, Linus Torvalds wrote:
> So I noticed that my diffstat didn't match either the KVM or the Xen pull.
> 
> The *reason* seems to be that both Radim and Juergen have enabled the
> "patience" diff, because if I add "--patience" to the diff line, I get
> the same numbers you guys report.
> 
> On Fri, May 19, 2017 at 11:43 AM, Radim Krčmář <rkrcmar@redhat.com> wrote:
>>
>>  28 files changed, 297 insertions(+), 125 deletions(-)
> 
> Without "--patience" (the default) I get:
> 
>  28 files changed, 292 insertions(+), 120 deletions(-)
> 
> which is close, but not the exact same thing.
> 
> So I don't mind people using the patience version of the diffing code,
> but on the whole it's a loss as often as it is a win, so I'm wondering
> _why_ you do this? Is there some other project that has started
> suggesting using the patience diff (either with a command line option
> or by just doing
> 
>   git config diff.algorithm patience
> 
> anyway, it's not a big deal, I'm just curious..

In my case it was a patch which was much easier to review using the
patience diff. I just didn't switch back afterwards (what I did now).


Juergen