From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.13]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 80E993F8EC9 for ; Wed, 10 Jun 2026 14:00:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.13 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781100012; cv=none; b=B0MCSAjIpfyE5zT1aEt7J7nQ5mBypjKmp36X6L78vpgenHlTBbo7JfPtN7g6Zmh4Z6nszZhEtdq1cRP5me+Jo6h1VU4kUJjUwzzSV85p/jjY0MSxqT2HBh5x5kBv4xCa7CgEzHcQnphxsUtKqgadqGHhPM7BRDpRynXWyGgRw3o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781100012; c=relaxed/simple; bh=lSmeWmGSvos+VJwGcRA8JyabB7wzhIoB+/mZkMeRpZ0=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=OakMxVePUiOPnnJAijSTCJntwnL+JVnZDxvLZWQQahTjKDgW6zVeF1DekLjN0KmLWFMvyb025/btL/sGq0WljsXAs5w5xPXU/JjULcqYhmBb7b5Xd+Tm4YpCiJ31pR5I6uCGvbNXoirHe0rvEuYedjdu+lhT10yM3q8NsqquhwI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=BWW7uaxE; arc=none smtp.client-ip=192.198.163.13 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="BWW7uaxE" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1781100010; x=1812636010; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=lSmeWmGSvos+VJwGcRA8JyabB7wzhIoB+/mZkMeRpZ0=; b=BWW7uaxEFpKR/61gQYPdeEsYCG4aUr+z24S4L+3LpH7rnBw+4bQzBPc9 HgnefitNjh7pLYavvI/59+Z9T2rd4bIZE/mbZOZ/WWsQZa8gfrjadam/N CHDhrwC/xhwu4kIAbwLfMUr+YKMx2JPJOPp+zhuKA/v8s/0krImcp6NHv 0VSlNHDPnGklST61ySvafW4ZX0mzVOaRXRk46p+tqn2LlLDxHjsyRoXNm 32T7mjCaKxkSSYqfJ6csiFZEYZOsgNVtUUxibdRsneO1JqV+ojKsU9hj5 f29gOH4pmIv+EfJwx/3+8NY8RW/Vakps4zQlscNPoSfleg0FaM6RKnFUE Q==; X-CSE-ConnectionGUID: ejU/g8Y8Sm6O0OEIYgG+bQ== X-CSE-MsgGUID: Q1fI972rQWaZq18o1ebLhQ== X-IronPort-AV: E=McAfee;i="6800,10657,11812"; a="84463294" X-IronPort-AV: E=Sophos;i="6.24,197,1774335600"; d="scan'208";a="84463294" Received: from fmviesa010.fm.intel.com ([10.60.135.150]) by fmvoesa107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Jun 2026 07:00:10 -0700 X-CSE-ConnectionGUID: bJdcSQXnSWW1HLXtEQr3CQ== X-CSE-MsgGUID: nI9lx0QnQfGu2kpDT3ltSw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.24,197,1774335600"; d="scan'208";a="242046002" Received: from fpallare-mobl4.ger.corp.intel.com (HELO localhost) ([10.245.244.3]) by fmviesa010-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Jun 2026 07:00:08 -0700 From: Jani Nikula To: Maxime Ripard Cc: Nicolas Frattaroli , Maarten Lankhorst , Thomas Zimmermann , David Airlie , Simona Vetter , Daniel Stone , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, kernel@collabora.com Subject: Re: [PATCH] drm/tests: Move test EDID data to separate .c file In-Reply-To: <20260610-quantum-glossy-partridge-136d8b@houat> Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs Bertel Jungin Aukio 5, 02600 Espoo, Finland References: <20260610-test-edid-array-definition-fix-v1-1-4467ba487886@collabora.com> <79f42f7e29b7a807c8ca4e622a547183018d65cb@intel.com> <20260610-quantum-glossy-partridge-136d8b@houat> Date: Wed, 10 Jun 2026 17:00:05 +0300 Message-ID: <97ac9e7b0f65f6f8c34c74718a0b707b95b1127c@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain On Wed, 10 Jun 2026, Maxime Ripard wrote: > On Wed, Jun 10, 2026 at 03:32:12PM +0300, Jani Nikula wrote: >> On Wed, 10 Jun 2026, Nicolas Frattaroli wrote: >> > Having the test EDID arrays defined in the .h directly will duplicate >> > them across every user of the EDID arrays. This works fine as long as >> > there's only one user, but may produce build warnings/errors when there >> > are multiple users and not all of them use all definitions. >> > >> > Move the array definitions to a new .c file, and mark the declarations >> > in the header as "extern" to avoid the linker throwing a fit, and give >> > them an explicit size (either 128 or 256, depending on EDID) to avoid >> > the compiler inferring that they must be size 1. >> > >> > Reported-by: Jani Nikula >> > Closes: https://lore.kernel.org/r/04ff70850213ae0f75486b1a27a7edb6fb4e71c3@intel.com/ >> > Fixes: ce1d0139adac ("drm/tests: bridge: Add test for HDMI output bus formats helper") >> > Fixes: 082fbc179c01 ("drm/tests: bridge: Add KUnit tests for bridge chain format selection") >> > Signed-off-by: Nicolas Frattaroli >> >> Thanks for doing this. >> >> I think I would've also moved the comments with the edid-decode >> results. Matter of taste I guess. >> >> Reviewed-by: Jani Nikula > > Yeah, I agree but since it fixes a compilation warning it can be done as > a subsequent patch. Btw the Sashiko review comment looks appropriate. > > Acked-by: Maxime Ripard > > Maxime -- Jani Nikula, Intel