From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BA4AF2853FD for ; Mon, 16 Mar 2026 20:54:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773694496; cv=none; b=LM+hcEbwhLZmOvguAxkVaJXdqNBuyBsed7jrVMH+48gsPKwOMZsIK1j7B/7nV6BlRHvuD5/++4ptGceZ2Co+l7AmMenk0EVEJ/xeZG5TLZVZKeIN1qJ9iC41OaGai8Ix+zmDaG2KS9mfYpS6dcTj968aLiK68ya+Wf35PakcL10= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773694496; c=relaxed/simple; bh=4KRiweGLXxpGd1Bat+MwMPGxqS78TlSHqKE8E8sAtb4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=aiECCneMc/IZp2T7LRHqpV0caZ01+iQiP7uaILTQVUIF+mLHwhChgV7Af/QU76w2H/Qgo831/BP3yNx4QcDHrXx49mtvzlb0oEwh/Z3LZLMJxcSMqaVxgnWW53WQkOG5pVTp3snkmi06p1BqHKdAmRh3aQ82MqGD4DoGElj6gAs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=iqCS0vSF; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=h/1KgHuw; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="iqCS0vSF"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="h/1KgHuw" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62GI50711420052 for ; Mon, 16 Mar 2026 20:54:52 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= fIPRW9ojG6PosnLQMZvCH1qVnkK0dNhAcHrugDb3mb4=; b=iqCS0vSFgvA95inI FDkdY8rpRTOm38K0Q/aNEVo+HRhDTGcu0lBX6P0GmFNN/Fc4pPRjuY5MgiWsacq6 eEXzcu+ATLUp7LnrxwtT7yxq66Ew7SvFGjfQbZEi0qzbY9+NcKHx/NNWGFQJPj0B w6mVFRiGQlF5wswRcztc/U3dIw68FaBu7aIqHYfW20Vws3ld3as6+XUxp/8vVenW qIj9UG4fMUpR5cd+4T7qojAenMbQN9R9XC+7dpGdk6/dRoKI982H+kMci8W020ao hTdfZGkD/HmjpMK/tOJsCw+t7LpqwCcfcdU0PRZ6DPpyPmRBj9fM9tAcnkLSfIT+ 66JaKg== Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cxdt82t91-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 16 Mar 2026 20:54:52 +0000 (GMT) Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-2b0560c1320so138634605ad.2 for ; Mon, 16 Mar 2026 13:54:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773694492; x=1774299292; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=fIPRW9ojG6PosnLQMZvCH1qVnkK0dNhAcHrugDb3mb4=; b=h/1KgHuws9L5kp3rcfR2IwsBDIpZGgqoVQMK2H0qlrEGBXWcvs6SQ5YSGiHtpJIpQ/ iQAojKCh2PZ8HEVkj+28EI649IwBI+ZZdh53V7pGXPpJuWn3ar+pQDTfIbAGeRDNpBBC aH0rwR8rJ+OpXmF/TZ/SmDEJIvfPZuF5SfHoPYEHLX7vS8YmD8eC+1iHWrlB/y/rcqA+ M7zF1CeG0qsFmrkr+Nl4xx9s2eLfLp4WxlMkO56oft/DrTtEjPN3O63wZcaXaUAUR20C 3jd/lIsG59Mq6WpdzC6z3MVOm2k0FD+NUBL8wUZQJ6gnYRndYWaPedkkJl7xJN0qcv1k 83SQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773694492; x=1774299292; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=fIPRW9ojG6PosnLQMZvCH1qVnkK0dNhAcHrugDb3mb4=; b=F+/mmqN8h2+EdxOmVEIdrIkiP3sEppY1j2DF+S7tWcpEd7m20JWmPGem1KoDUqvEyh SvFjDzESRV96He5gljvyRK7nat11rbgp9z8n7Dx8/4Qe77WQdwqYcAAH8n9I3/VnqBlY Ty3ivXhDd2ULQpTO/oUkXdoM4EghJ54UsHEt+YzDgstmpVuSQI/6ARLR3UcgxqYa632P c3+gJPKnQ1VFVNgZYqr5cDXsDxf7s7IA6iclym7HJFoybBL7OynnK41sJwnaJeEdps+k m25S8KglSoIhfYAh7Pw1bAHFPC1HN2eT6p51u8e25FJqtqKV/J7GOUn1IjjebBLoKF02 vsXw== X-Forwarded-Encrypted: i=1; AJvYcCWvMA5FszFpqQjlVlh38oD7YCSIcwtrpZJPwzwmO5U5twskbBtGEwu+RaF15qtpHNYFQlCxsDJ0RRqHBqM=@vger.kernel.org X-Gm-Message-State: AOJu0Yx7kGHYKi49C65Rer68Rf2B/NYefwxx3aEfxBj6PvFdVQXvaEW4 d5SvRAUiN28dYpg3+9J50myQv6Y0NhceSsLf7tcEyp47BssFEh5/F8Ux4am7Slwh0VH3mHr5I5/ pieFxmN2eXACbrgOlyD+MEcTBJ0dIRH9OZSZIVJwGf+VlH/1ntoZrdEskdJaz7ddzYzk= X-Gm-Gg: ATEYQzwXpoJAvInEAP+J7Xg3eIIaa6cGhQ2mJK9OdZ6RE/Bn5PTxAQvn+AOJCldsxEf AJPsgqOZG5WTQ6msMUloPaA4z8yvH+iuTJ3UcZYiLDBv6d5a/+bPtBE0Z9mjlF+q4jahQt+JDNe pcNmhylHKndUgTzfjdBOtn298balQRTdjCJpCg0rLEJpQZ+C7+3QEZiUf3YxX9+K1m7FjPCEi6m qgl9iE7bgVF8vyMLGJaWjfpw458xZKXRTiB26a2h9aBOPmRoMJQQbcILPZgqQxajJTvnhvz3J0G suD/l+m1IxWvMImdzHr0hDLcuudSA7mpq1tqwsJJguHZVIGZVg+0pmeI6cWtGCxufm7zObsf4Af pB32vnzBKBm+uqlJ3OlBsx4x8F9UA5+K9aXjubPikDNnvwj0SbW8vFSpePLWXErOu+3WboOuGaH pYWeit X-Received: by 2002:a17:902:e5d2:b0:2ae:7f24:4940 with SMTP id d9443c01a7336-2aecac97dbcmr161128895ad.50.1773694491602; Mon, 16 Mar 2026 13:54:51 -0700 (PDT) X-Received: by 2002:a17:902:e5d2:b0:2ae:7f24:4940 with SMTP id d9443c01a7336-2aecac97dbcmr161128715ad.50.1773694491133; Mon, 16 Mar 2026 13:54:51 -0700 (PDT) Received: from ?IPV6:2401:4900:1c27:17c8:7897:b4f6:fc6e:b55? ([2401:4900:1c27:17c8:7897:b4f6:fc6e:b55]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2aece83b35fsm128243285ad.80.2026.03.16.13.54.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 16 Mar 2026 13:54:50 -0700 (PDT) Message-ID: <97b5fc67-9dc0-4d86-a98d-eabf7465ba40@oss.qualcomm.com> Date: Tue, 17 Mar 2026 02:24:44 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] drm/msm: Fix GMEM_BASE for A650 To: rob.clark@oss.qualcomm.com Cc: Alexander Koskovich , Sean Paul , Konrad Dybcio , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Marijn Suijten , David Airlie , Simona Vetter , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Konrad Dybcio References: <20260314-fix-gmem-base-a650-v1-1-3308f60cf74c@pm.me> <2938aa01-cc1b-4dd8-a4af-45ff8354a061@oss.qualcomm.com> From: Akhil P Oommen Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-GUID: LPbZGxDN2R0_XxeVjIYKpg3M780vDiix X-Authority-Analysis: v=2.4 cv=CKInnBrD c=1 sm=1 tr=0 ts=69b86e1c cx=c_pps a=MTSHoo12Qbhz2p7MsH1ifg==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=EUspDBNiAAAA:8 a=iNc0q687GlOE84pCJgIA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=GvdueXVYPmCkWapjIL-Q:22 X-Proofpoint-ORIG-GUID: LPbZGxDN2R0_XxeVjIYKpg3M780vDiix X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzE2MDE2OSBTYWx0ZWRfX2uftGPCdkHa3 RNTO34OjMxMdpjlvVllFz4VamOja7Wv9W/EXJOyTnMr1VjYd/HiDwMYvL0X8Y/ZlnLEJd6D01iw CgyMrfm/cmq7uZrQBudfKtoUrgXSAAANCsjC/aIIsfxPwePdZ/fZzWfq+5xmvPHncEhztHpAoKI Zm0L9Pul7cxYw4l/+hF8klULCCCkB4hzH1b+4Ppulj55JCRBcXguFrVE7St9UK+A8K4ee668BMG DvbpXwViAfFnRSCP+sBo0FelgJjRV8dgu7iXxjT/L6AqJ52yztsgCBwfC1xXxCwMqk7LpD5CMCo xMAyRbxsKhxNsC2FY1HBlWgbSvHQONDmLOi4fVKRDyMBhGkKlc++ydwfth95/8zKIZiocs5bZGs hht0JB45efPtrJ593fkIlttpa1y8v6gqB+wzHsQoYTjsjflYTdxZKroW7ALwipvaoX6ECXyEQYP r+XzpOX9RkibhVaP9pQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-16_05,2026-03-16_06,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 lowpriorityscore=0 phishscore=0 priorityscore=1501 bulkscore=0 adultscore=0 impostorscore=0 suspectscore=0 spamscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603160169 On 3/16/2026 8:01 PM, Rob Clark wrote: > On Mon, Mar 16, 2026 at 2:22 AM Konrad Dybcio > wrote: >> >> On 3/14/26 5:14 AM, Alexander Koskovich wrote: >>> Commit dc220915ddb2 ("drm/msm: Fix GMEM_BASE for gen8") changed the >>> GMEM_BASE check from adreno_is_a650_family() & adreno_is_a740_family() >>> to family >= ADRENO_6XX_GEN4. >>> >>> This inadvertently excluded A650 (ADRENO_6XX_GEN3), causing it to report >>> an incorrect GMEM_BASE which results in severe rendering corruption. >>> >>> Update check to also include ADRENO_6XX_GEN3 to fix A650. >>> >>> Fixes: dc220915ddb2 ("drm/msm: Fix GMEM_BASE for gen8") >> >> Hm, that commit also changed the value for A730 - Akhil/Rob, should >> that be changed back? > > No, it was incorrect before my patch. The only problem was the change > happened in a6xx_gen3, not a6xx_gen4. So this patch is correct. << a little unrelated to this patch >> Rob, on A740 and A8x GPU, KMD is mapping GMEM at 16MB and 64MB offsets respectively. So returning 0 here to userspace for those GPUs doesn't seem right for those GPUs. I believe userspace is interested in the aperture base address configured in UCHE_GMEM_RANGE/UCHE_CCHE_GC_GMEM_RANGE registers so that it can compute the IOVA to read GMEM via UCHE. -Akhil. > > BR, > -R > >> Konrad >> >>> Signed-off-by: Alexander Koskovich >>> --- >>> drivers/gpu/drm/msm/adreno/adreno_gpu.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/drivers/gpu/drm/msm/adreno/adreno_gpu.c b/drivers/gpu/drm/msm/adreno/adreno_gpu.c >>> index d5fe6f6f0dec..0ac3fba5c277 100644 >>> --- a/drivers/gpu/drm/msm/adreno/adreno_gpu.c >>> +++ b/drivers/gpu/drm/msm/adreno/adreno_gpu.c >>> @@ -376,7 +376,7 @@ int adreno_get_param(struct msm_gpu *gpu, struct msm_context *ctx, >>> *value = adreno_gpu->info->gmem; >>> return 0; >>> case MSM_PARAM_GMEM_BASE: >>> - if (adreno_gpu->info->family >= ADRENO_6XX_GEN4) >>> + if (adreno_gpu->info->family >= ADRENO_6XX_GEN3) >>> *value = 0; >>> else >>> *value = 0x100000; >>> >>> --- >>> base-commit: 1f318b96cc84d7c2ab792fcc0bfd42a7ca890681 >>> change-id: 20260314-fix-gmem-base-a650-cfd9bfcea425 >>> >>> Best regards,