From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752309AbdJEUwM (ORCPT ); Thu, 5 Oct 2017 16:52:12 -0400 Received: from mout.web.de ([212.227.17.12]:61936 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751888AbdJEUwK (ORCPT ); Thu, 5 Oct 2017 16:52:10 -0400 Subject: [PATCH 2/2] powermac: Improve a size determination in five functions From: SF Markus Elfring To: linuxppc-dev@lists.ozlabs.org, Benjamin Herrenschmidt , Michael Ellerman , Paul Mackerras Cc: LKML , kernel-janitors@vger.kernel.org References: <5188c0b3-476a-6a14-bab5-052ad0f4dae0@users.sourceforge.net> Message-ID: <97bf4b4e-811e-58c4-214e-7d60c014a3d0@users.sourceforge.net> Date: Thu, 5 Oct 2017 22:52:05 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <5188c0b3-476a-6a14-bab5-052ad0f4dae0@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:WzwRl3uowq2FXEbBQ0Go1tZepF5/mJC3uvm6uIaztkloRyYVVzU rUJ6pwB663S/ZanzAf0U7Kt/qmyWMzVLPRs4usSU00s03iBsVNRVBzJBDokwm4w6eAnobg7 djWidHBJSxf0O28VN4TBbfaisr1v+L059KWAK40mxT+oOHSVjr8ERxMSMHb7XiXOWnebfvK Pmgsy7/AZZLp6qny6gr8A== X-UI-Out-Filterresults: notjunk:1;V01:K0:eHHNufSw08k=:+OJ/dmKEUqiJNztbItaXvL k6Mw4vyhQEw9+3nVXfaAJ1iBCp9zx6DsKVztv9DQCC/4qIHTUNuBekAG9TPuMGeqDf36rPMPz RVHC/1g6DbdCtcPSYDoeDvEw4A8k1UkqyUZm5XDBjjwlcvYC2IkKdjMNsr/6JGiV4PFgo6H6i Lkt0RelkQEzdxKIyVemLg/FOmU+y8nt2/W8SPaWe0FQBSaygMDt9QIK7PiVj7QvTJX0KF/PTI fl5vPvysOIg4Nu5xzIjxc3QMB6i+AmxOqMB+tj66YpxBe/boJMkvVLKub34oGQX2xDvoz8AgL N/ttricpBy5rDupulaXzRP/u6lclVZb8X848gtH6fs9dsXaXNhzibVAuw7QTMdfbg+NLk4Qcy qECU+3t5nt7Ca2cxgy77/pGEn1l1/G3Y2qdI3Jqs8IMI+B1+5o6pv5cuvOBgMhO2wYr9NuBY2 luoMDsILfjQhCxhGEo89u5HKWvxGsAxRrj5zON26/eukgtjy1d30bz24OYyVOWQaOT9a+yXq5 wtS+gMKHWAsyOkDi9mbHfW5XIXRZcc0edYCihSmSdXl/LDWJGf7VZahMz12dn3FXW5cvvOgNV ONBWeIOKVkXSKMUEEi6ivJEQR4Q0ziseiJTjOh/hXLe2mynsOScKm5LlnS6tBQUW4v4bmvQ4h 6ySGzkPQpBqu7ZmVDm0qssjU+vpu1lFFV8GrMGtSEA0s0MfTpIHA7xQ/4/khxCOY0hFxczRzt 1MLF5jMxN9BTFlUSHkMRhxxKpu19BDzU/jxnV5IcK1tUWEgywIJiJiAB60pnJHrfpbKjzmzn9 6FRgexB0oZkW+efNkW5CfHH4zwUfSbkL8aAYgw2j/DKeYHwHCo= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Thu, 5 Oct 2017 22:40:39 +0200 Replace the specification of data structures by pointer dereferences as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- arch/powerpc/platforms/powermac/low_i2c.c | 6 +++--- arch/powerpc/platforms/powermac/pfunc_core.c | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/arch/powerpc/platforms/powermac/low_i2c.c b/arch/powerpc/platforms/powermac/low_i2c.c index ecd166b5549b..46b7eb1a0f5f 100644 --- a/arch/powerpc/platforms/powermac/low_i2c.c +++ b/arch/powerpc/platforms/powermac/low_i2c.c @@ -492,7 +492,7 @@ static struct pmac_i2c_host_kw *__init kw_i2c_host_init(struct device_node *np) const u32 *psteps, *prate, *addrp; u32 steps; - host = kzalloc(sizeof(struct pmac_i2c_host_kw), GFP_KERNEL); + host = kzalloc(sizeof(*host), GFP_KERNEL); if (!host) return NULL; @@ -571,7 +571,7 @@ static void __init kw_i2c_add(struct pmac_i2c_host_kw *host, { struct pmac_i2c_bus *bus; - bus = kzalloc(sizeof(struct pmac_i2c_bus), GFP_KERNEL); + bus = kzalloc(sizeof(*bus), GFP_KERNEL); if (bus == NULL) return; @@ -1253,7 +1253,7 @@ static void* pmac_i2c_do_begin(struct pmf_function *func, struct pmf_args *args) * near OOM that need to be resolved, the allocator itself should * probably make GFP_NOIO implicit during suspend */ - inst = kzalloc(sizeof(struct pmac_i2c_pf_inst), GFP_KERNEL); + inst = kzalloc(sizeof(*inst), GFP_KERNEL); if (inst == NULL) { pmac_i2c_close(bus); return NULL; diff --git a/arch/powerpc/platforms/powermac/pfunc_core.c b/arch/powerpc/platforms/powermac/pfunc_core.c index df3c93bef228..e0462fedcdb8 100644 --- a/arch/powerpc/platforms/powermac/pfunc_core.c +++ b/arch/powerpc/platforms/powermac/pfunc_core.c @@ -643,7 +643,7 @@ static int pmf_add_function_prop(struct pmf_device *dev, void *driverdata, while (length >= 12) { /* Allocate a structure */ - func = kzalloc(sizeof(struct pmf_function), GFP_KERNEL); + func = kzalloc(sizeof(*func), GFP_KERNEL); if (func == NULL) goto bail; kref_init(&func->ref); @@ -719,7 +719,7 @@ int pmf_register_driver(struct device_node *np, return -EBUSY; } - dev = kzalloc(sizeof(struct pmf_device), GFP_KERNEL); + dev = kzalloc(sizeof(*dev), GFP_KERNEL); if (dev == NULL) { DBG("pmf: no memory !\n"); return -ENOMEM; -- 2.14.2