From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751619AbcGORqm (ORCPT ); Fri, 15 Jul 2016 13:46:42 -0400 Received: from mail-qk0-f178.google.com ([209.85.220.178]:33152 "EHLO mail-qk0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751279AbcGORqk (ORCPT ); Fri, 15 Jul 2016 13:46:40 -0400 Subject: Re: [RFC PATCH] tracing: add sched_prio_update To: Julien Desfossez , Steven Rostedt References: <1467661564-7516-1-git-send-email-jdesfossez@efficios.com> <20160705111914.238b28ee@gandalf.local.home> <355420018.58738.1467755434744.JavaMail.zimbra@efficios.com> <20160706091325.3f9879eb@gandalf.local.home> <20160706135324.GA8583@sinkpad.internal.efficios.com> Cc: Mathieu Desnoyers , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , daolivei@redhat.com, linux-kernel@vger.kernel.org From: Daniel Bristot de Oliveira Message-ID: <97c2c0d1-c815-2f5c-d1ae-925ee6904fb8@redhat.com> Date: Fri, 15 Jul 2016 14:46:33 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: <20160706135324.GA8583@sinkpad.internal.efficios.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/06/2016 10:53 AM, Julien Desfossez wrote: >> But still, it's a >> > rather hefty tracepoint (lots of fields), probably want to keep from >> > adding comm too. > Yes, I agree we can remove the comm field, it is easy to get from the > previous sched_switch. > Sorry for the delay. I do liked this tracepoint! about comm, I think that having the comm will make the tracepoint easier to understand, so I vote for maintain the comm field. But I also see Steven's point and I would not complain if you more expert guys agree on removing comm :-).