From: Vikash Garodia <vikash.garodia@oss.qualcomm.com>
To: Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
"Joerg Roedel (AMD)" <joro@8bytes.org>,
Vasant Hegde <vasant.hegde@amd.com>,
Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>,
Will Deacon <will@kernel.org>,
Robin Murphy <robin.murphy@arm.com>,
David Woodhouse <dwmw2@infradead.org>,
Lu Baolu <baolu.lu@linux.intel.com>,
Jean-Philippe Brucker <jpb@kernel.org>,
Rob Herring <robh@kernel.org>,
Saravana Kannan <saravanak@kernel.org>,
Tomasz Nowicki <tomasz.nowicki@caviumnetworks.com>,
Eric Auger <eric.auger@redhat.com>,
Joerg Roedel <jroedel@suse.de>,
Srinath Mannam <srinath.mannam@broadcom.com>,
Oza Pawandeep <quic_poza@quicinc.com>,
Lorenzo Pieralisi <lpieralisi@kernel.org>,
Bjorn Helgaas <bhelgaas@google.com>,
Alex Williamson <alex@shazbot.org>
Cc: iommu@lists.linux.dev, linux-kernel@vger.kernel.org,
virtualization@lists.linux.dev, devicetree@vger.kernel.org,
kvm@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-media@vger.kernel.org,
Vishnu Reddy <busanna.reddy@oss.qualcomm.com>
Subject: Re: [PATCH v7 4/5] iommu/of: Require reg for iommu-addresses
Date: Thu, 12 Nov 2026 19:34:11 +0530 [thread overview]
Message-ID: <97c4eabf-16b0-4e3f-8aab-1c56912c27d4@oss.qualcomm.com> (raw)
In-Reply-To: <3713bf13-cec6-4b02-a29b-8f76070f03b3@linaro.org>
On 11/11/2026 5:32 PM, Bryan O'Donoghue wrote:
> On 06/11/2026 17:14, Vikash Garodia wrote:
>> @@ -257,6 +252,9 @@ void of_iommu_get_resv_regions(struct device *dev,
>> struct list_head *list)
>> }
>> type = iommu_resv_region_get_type(dev, &phys, iova,
>> length);
>> + if (type != IOMMU_RESV_DIRECT)
>> + continue;
>> +
>
> This change is not about requiring a reg though, which is why it should
> be a standalone patch with its own justifications.
>
This is about reg, which determines the direct mapping, hence the code
is very much applicable to this patch. Please refer this code [1]
[1]
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/drivers/iommu/of_iommu.c#n223
Regards,
Vikash
> Basically the patch should state why a mismatch is dropped instead of
> being reserved.
>
> ---
> bod
next prev parent reply other threads:[~2026-11-12 14:04 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-06 17:14 [PATCH v7 0/5] of_iommu: add support for "iommu-ranges" Vikash Garodia
2026-11-06 17:14 ` [PATCH v7 1/5] iommu/dma: Keep reserved regions below the IOVA rbtree anchor Vikash Garodia
2026-11-11 13:03 ` Dmitry Baryshkov
2026-11-06 17:14 ` [PATCH v7 2/5] iommu: Use resource_size_t for reserved region length Vikash Garodia
2026-11-10 17:28 ` Rob Herring (Arm)
2026-11-11 13:02 ` Dmitry Baryshkov
2026-11-06 17:14 ` [PATCH v7 3/5] iommu/of: Make OF_IOMMU depend on OF_ADDRESS Vikash Garodia
2026-11-11 13:03 ` Dmitry Baryshkov
2026-11-12 13:40 ` Vikash Garodia
2026-11-06 17:14 ` [PATCH v7 4/5] iommu/of: Require reg for iommu-addresses Vikash Garodia
2026-11-11 12:02 ` Bryan O'Donoghue
2026-11-12 14:04 ` Vikash Garodia [this message]
2026-11-12 14:19 ` Bryan O'Donoghue
2026-11-06 17:14 ` [PATCH v7 5/5] iommu/of: Add support for "iommu-ranges" on a device node Vikash Garodia
2026-11-11 11:04 ` [PATCH v7 0/5] of_iommu: add support for "iommu-ranges" Vinayak Katoch
2026-11-11 13:01 ` Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=97c4eabf-16b0-4e3f-8aab-1c56912c27d4@oss.qualcomm.com \
--to=vikash.garodia@oss.qualcomm.com \
--cc=alex@shazbot.org \
--cc=baolu.lu@linux.intel.com \
--cc=bhelgaas@google.com \
--cc=bryan.odonoghue@linaro.org \
--cc=busanna.reddy@oss.qualcomm.com \
--cc=devicetree@vger.kernel.org \
--cc=dwmw2@infradead.org \
--cc=eric.auger@redhat.com \
--cc=iommu@lists.linux.dev \
--cc=joro@8bytes.org \
--cc=jpb@kernel.org \
--cc=jroedel@suse.de \
--cc=kvm@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=quic_poza@quicinc.com \
--cc=robh@kernel.org \
--cc=robin.murphy@arm.com \
--cc=saravanak@kernel.org \
--cc=srinath.mannam@broadcom.com \
--cc=suravee.suthikulpanit@amd.com \
--cc=tomasz.nowicki@caviumnetworks.com \
--cc=vasant.hegde@amd.com \
--cc=virtualization@lists.linux.dev \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®