From: <Parthiban.Veerasooran@microchip.com>
To: <yang.lee@linux.alibaba.com>
Cc: <Christian.Gromm@microchip.com>, <linux-staging@lists.linux.dev>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -next] staging: most: dim2: Use devm_platform_get_and_ioremap_resource()
Date: Thu, 9 Mar 2023 12:07:25 +0000 [thread overview]
Message-ID: <97c60193-4462-1a09-c3e6-235c57a844fd@microchip.com> (raw)
In-Reply-To: <20230308063653.92879-1-yang.lee@linux.alibaba.com>
On 08/03/23 12:06 pm, Yang Li wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> According to commit 890cc39a8799 ("drivers: provide
> devm_platform_get_and_ioremap_resource()"), convert
> platform_get_resource(), devm_ioremap_resource() to a single
> call to devm_platform_get_and_ioremap_resource(), as this is exactly
> what this function does.
>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
Acked-by: Parthiban Veerasooran <parthiban.veerasooran@microchip.com>
> ---
> drivers/staging/most/dim2/dim2.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/staging/most/dim2/dim2.c b/drivers/staging/most/dim2/dim2.c
> index 7a5f80e637a0..b8bd01ca1f11 100644
> --- a/drivers/staging/most/dim2/dim2.c
> +++ b/drivers/staging/most/dim2/dim2.c
> @@ -775,8 +775,7 @@ static int dim2_probe(struct platform_device *pdev)
> goto err_free_dev;
> }
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - dev->io_base = devm_ioremap_resource(&pdev->dev, res);
> + dev->io_base = devm_platform_get_and_ioremap_resource(pdev, 0, &res);
> if (IS_ERR(dev->io_base)) {
> ret = PTR_ERR(dev->io_base);
> goto err_free_dev;
> --
> 2.20.1.7.g153144c
>
prev parent reply other threads:[~2023-03-09 12:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-08 6:36 Yang Li
2023-03-09 12:07 ` Parthiban.Veerasooran [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=97c60193-4462-1a09-c3e6-235c57a844fd@microchip.com \
--to=parthiban.veerasooran@microchip.com \
--cc=Christian.Gromm@microchip.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=yang.lee@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®