From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 83336426ED5 for ; Fri, 10 Jul 2026 13:00:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783688412; cv=none; b=laBGYMa2la8NNCN9yoQIszi9YOKBPbD90JaQE823mNodyhvFCQbCBY7hfvwLle74BeNbLtG8z7Q3rpvYSfFyzD0K6K6pIkG+NrUeWlYaHK3EbTABMNbkTMB+at2cjDKIgYaO0IsrmiinhN/gEejYh7V2Om/FzdoUR9WpPnPaKnE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783688412; c=relaxed/simple; bh=PmXeuS+A/v+x53Qb+qL+JvhuBQ1sFDSeRb4adax00Ik=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=VtFnoBL4/XYv8KPMbQej5y6Z1lE7/JOOP7+LXDH/2IZydev3l4KqDKQqfsLXOwShGQon2TRwlXeQx1i6qw3+bB4lFM5tLqRVl43Hnh2b005K2AsvJcdoVIPCsQWcBTIrSqbtBVqO0tAwGx+98mVk6IIRDjnH5TuZQdyJruycgb8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=PuhQXC6G; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Y10kIgkv; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="PuhQXC6G"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Y10kIgkv" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66AAmd80615210 for ; Fri, 10 Jul 2026 13:00:07 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= d9Beo4a6GfwyHuZZh9Hbzb5Kq0VxcvFZ/EiNXB2jbIo=; b=PuhQXC6Gk6j6LRq5 9Q+/MFiOjZajkX1qKNGTTDTIOjgf2432sOZ1ATBzTmIfXZ++iuMUHsyqnuvVjUQw GVrLogYnX6bKbVVd4HisZuB+eLryn733JdqcCcOs4CUfJjyy1PpcDhEuNb/qoyX2 4Ja4UUo2VEsULIry5GC8yNb2XCypGtGWZj+bntp/bmBM5WyZHlv+PkVPn4yf7Nfh 2OF1Z6rIlxanYzzu1SlB6AHURbnVrc8pvgfFyV5gtFzTk/65JutbJUxilmotq8VC 8lc+U8B+i0UgWBF0akU87z+nfpaLC4hQLF1yegfp+WzOPbIEOzPKirCshqMqqzBk 7zOt7w== Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fajte35ej-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 10 Jul 2026 13:00:07 +0000 (GMT) Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-8e8e83314abso3164496d6.3 for ; Fri, 10 Jul 2026 06:00:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783688406; x=1784293206; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=d9Beo4a6GfwyHuZZh9Hbzb5Kq0VxcvFZ/EiNXB2jbIo=; b=Y10kIgkvD43uWuIgLPRMfbsmUGo37oyDEXvbsFNsMFUGO72D9mfZtNAuqKvmK6fmDA NG42ABmWIPfpC9xlhfn0Tr16IH/tjz/dbLNioRuuRnelghN/5csdUDiIKoAFk7krU8rq 2meo3Wbrs3MnXakHHWWqDTm+hjDyQhLQi37GTEcgAV2h1HNcbyjKbH6dLtmgnyHzssxc jcFZmVsqvZED1Wsl/QOLDV8v290lqWLlwwr3xwsc+39om5bQVfhwwAapn1cwIsNQrPQO ZKBIgbXSbXr7Z2NTAHmra6p9x0btz1L+xGOswREK5FjR3mniDdzrpuao+qogh+jXPKIT sNOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783688406; x=1784293206; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=d9Beo4a6GfwyHuZZh9Hbzb5Kq0VxcvFZ/EiNXB2jbIo=; b=gmzoaoiDKkWVQkZevDRQrCZuCt3dRJHMzzO9kai9NrtIsQoIt5+zprp0VUotnlMHCD 1b2W2hkvsm+KrCzovF0gHpbh0L/4c1+u3ELUWUshkOiNfSmd738k9POfaEONjQe8OXF6 +j06k+OELLjztNz59p27ILFbUOG0ckusjCrKlHJqYkck2PDuZ97RwR2ujrxkKbGTmglY 2/MZPduphpvxId3/okZAriOcReDZwhcUnztnpWWhFEazXmVhwudr1Hxn13sfUbqi3QVN V9Dyji7DIIR+DOLovN5abPzqQkveYXLetDdG0D0m9ejlUh3IQJHnVjoeTOr94rDTTcOl InYw== X-Forwarded-Encrypted: i=1; AHgh+Ro3lvSp8FdFrrm6OKPp3pHkmorah7s00U/BmvS8MxG2qo8S9ATk0pSASnf5KgTtGlYLGAb7LzIh7WulYuo=@vger.kernel.org X-Gm-Message-State: AOJu0Yx8bZx0ysldyfRGfncLf+XpV6u17ENeH7dIk8ZChdIBj40b7S/z TBrYJMlrHNR2c6LdzUZ3e8NxURWdf6FNIhE8akPnXGGnvvzH6brQFKLG5YTOyeO94ehOwHD+zAQ J0ZsSSS/3BGSjdkPF7HWG1zX4C5vTCRJ+rtcwPV7ZnvwsX0vKKyqBS3hvlmZ/+UGgm4k= X-Gm-Gg: AfdE7cl/NtfB0iC/p5oWYOlX+KVwVYpXiA6a3oxqGPwMStc4j33I0ym9TBAxLYXtmiy yoH8IMM8WksosWf/LOk/3Lh0nrCi7vKItSFk9FzgofoDkcKdWls7vFYUYKTJjXR7mZzhp06irXQ iqVOMYuAEl4Kk4vs18j97JVIx7G3Z22k6zwMotZELdx7zWyXK8z2IGDX24Dcfrd0BIAmGRt0kp+ y2fgYwnoBBJG2whlQr/AHKpciXZByRbPDfROBEMqg+fhJtdrH9/gjT2BDpW7ZoPAodXg2E/zj7I hF+0TJWG8C+jOpcBeCabNgkfGK12Ufe6tw82K9hL0yW7sF1zPzo06OYU/LGkNFqxJR+dkIutpZJ RxC8Mmy1CieOzIDPg0eXUungrAQYoDNOYPz0= X-Received: by 2002:a05:6214:5f08:b0:8f1:507a:ed6c with SMTP id 6a1803df08f44-8fec73525f1mr108514266d6.5.1783688406540; Fri, 10 Jul 2026 06:00:06 -0700 (PDT) X-Received: by 2002:a05:6214:5f08:b0:8f1:507a:ed6c with SMTP id 6a1803df08f44-8fec73525f1mr108513496d6.5.1783688405829; Fri, 10 Jul 2026 06:00:05 -0700 (PDT) Received: from [192.168.120.193] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-69a19cd88aesm10646911a12.3.2026.07.10.06.00.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 10 Jul 2026 06:00:04 -0700 (PDT) Message-ID: <97d0233e-75fe-451f-a190-ee0797d2b551@oss.qualcomm.com> Date: Fri, 10 Jul 2026 15:00:02 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/4] arm64: dts: qcom: pm4125: Add VADC and temp alarm nodes To: Jishnu Prakash , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Kamal Wadhwa , Rakesh Kota References: <20260710-shikra_adc_support-v3-0-ddc840fca0a0@oss.qualcomm.com> <20260710-shikra_adc_support-v3-1-ddc840fca0a0@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260710-shikra_adc_support-v3-1-ddc840fca0a0@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: zsElJyimCqQ9P0FXgETRkaoXqlqrbEW2 X-Proofpoint-ORIG-GUID: zsElJyimCqQ9P0FXgETRkaoXqlqrbEW2 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzEwMDEyOSBTYWx0ZWRfX53Y5BYQNK2Ev Gb9lnIKpatZevuJB2f9GiA6Y/KHf2L2W5eBB75w9aPaGyRwNprI2UGQWA0bhB41pi07G37lU9Ow r/9FesLcQRGEfNNRVgYKAJu47xzB8NIFz2ckuDD/M8VhEzeMBOEtlc78kdAJsHioYkK9ZonhVyr 0Z/nFAFhJVmgQkrt4yIUxvZ49qwmaZOBF6EGnR0FSDy4XwRMornbLXftzG2V2vD3QZwNT/fmzt6 nMiO5Ui1w5Cb/V1MIBO9ayuzYYCISzkyjsk+RVJjKKg04hdUYoGcHMhahSeoYzp0UzP4Khpuz5q dhhu4qkX1obg434l36oniJSQbkcRMYFlMjRQ85ivC95hXeYwWBN3yOA1WiVPbBVoKwdfKpUoMqi 2mWhKFeHSEQBPf3eOxqLCLzAZHuGGvaBEPvgiymida3uJfQa7av2ngo0IlQUkalKnGV96g+Gwlp xbbxJTGliJsHXuy0Rdg== X-Authority-Analysis: v=2.4 cv=N7MZ0W9B c=1 sm=1 tr=0 ts=6a50ecd7 cx=c_pps a=oc9J++0uMp73DTRD5QyR2A==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=EUspDBNiAAAA:8 a=SXoWBDIS_OCUn4CpEIoA:9 a=QEXdDO2ut3YA:10 a=iYH6xdkBrDN1Jqds4HTS:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwNzEwMDEyOSBTYWx0ZWRfX77B3Yf22v5V1 IZ6Jfvslqbd2TmCLdxhAlMHnyyZc5a9HYXsEO+dQElsfJ3E0HyqJe/iFS1ANRytXOTGfWj+Z4R3 ow3r778k83cCwm0X4wa1IfsMb08r0VQ= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-10_03,2026-07-09_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 spamscore=0 impostorscore=0 suspectscore=0 adultscore=0 malwarescore=0 phishscore=0 lowpriorityscore=0 priorityscore=1501 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607100129 On 7/10/26 8:52 AM, Jishnu Prakash wrote: > Add VADC node with some channels under it, for voltage and > temperature readings. Add temperature alarm node, used for > PMIC thermal mitigation. > > Co-developed-by: Rakesh Kota > Signed-off-by: Rakesh Kota > Signed-off-by: Jishnu Prakash > --- [...] > + pm4125_adc: adc@3100 { > + compatible = "qcom,spmi-adc5"; > + reg = <0x3100>; > + #address-cells = <1>; > + #size-cells = <0>; > + #io-channel-cells = <1>; > + interrupts = <0x0 0x31 0x0 IRQ_TYPE_EDGE_RISING>; > + > + /* Channel nodes */ This comment is mildly useful but OK Reviewed-by: Konrad Dybcio Konrad