From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752903AbeCWMUK (ORCPT ); Fri, 23 Mar 2018 08:20:10 -0400 Received: from pegase1.c-s.fr ([93.17.236.30]:64097 "EHLO pegase1.c-s.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752632AbeCWMUH (ORCPT ); Fri, 23 Mar 2018 08:20:07 -0400 Subject: Re: [PATCH 14/19] powerpc/altivec: Add missing prototypes for altivec To: Mathieu Malaterre , Michael Ellerman Cc: linux-kernel@vger.kernel.org, kvm-ppc@vger.kernel.org, Paul Mackerras , linuxppc-dev@lists.ozlabs.org References: <20180322202007.23088-1-malat@debian.org> <20180322202007.23088-15-malat@debian.org> From: christophe leroy Message-ID: <97df68d1-d4fe-bf8e-7852-9b418eec042f@c-s.fr> Date: Fri, 23 Mar 2018 13:19:59 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <20180322202007.23088-15-malat@debian.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: fr Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le 22/03/2018 à 21:20, Mathieu Malaterre a écrit : > Some functions prototypes were missing for the non-altivec code. Add the > missing prototypes directly in xor_vmx, fix warnings treated as errors with > W=1: > > arch/powerpc/lib/xor_vmx_glue.c:18:6: error: no previous prototype for ‘xor_altivec_2’ [-Werror=missing-prototypes] > arch/powerpc/lib/xor_vmx_glue.c:29:6: error: no previous prototype for ‘xor_altivec_3’ [-Werror=missing-prototypes] > arch/powerpc/lib/xor_vmx_glue.c:40:6: error: no previous prototype for ‘xor_altivec_4’ [-Werror=missing-prototypes] > arch/powerpc/lib/xor_vmx_glue.c:52:6: error: no previous prototype for ‘xor_altivec_5’ [-Werror=missing-prototypes] > > Signed-off-by: Mathieu Malaterre > --- > arch/powerpc/lib/xor_vmx.h | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/arch/powerpc/lib/xor_vmx.h b/arch/powerpc/lib/xor_vmx.h > index 5c2b0839b179..2173e3c84151 100644 > --- a/arch/powerpc/lib/xor_vmx.h > +++ b/arch/powerpc/lib/xor_vmx.h > @@ -19,3 +19,17 @@ void __xor_altivec_4(unsigned long bytes, unsigned long *v1_in, > void __xor_altivec_5(unsigned long bytes, unsigned long *v1_in, > unsigned long *v2_in, unsigned long *v3_in, > unsigned long *v4_in, unsigned long *v5_in); > + > +void xor_altivec_2(unsigned long bytes, unsigned long *v1_in, > + unsigned long *v2_in); > + Only used in one place, should be static instead of adding it in a .h Same for the other ones. Christophe > +void xor_altivec_3(unsigned long bytes, unsigned long *v1_in, > + unsigned long *v2_in, unsigned long *v3_in); > + > +void xor_altivec_4(unsigned long bytes, unsigned long *v1_in, > + unsigned long *v2_in, unsigned long *v3_in, > + unsigned long *v4_in); > + > +void xor_altivec_5(unsigned long bytes, unsigned long *v1_in, > + unsigned long *v2_in, unsigned long *v3_in, > + unsigned long *v4_in, unsigned long *v5_in); > --- L'absence de virus dans ce courrier électronique a été vérifiée par le logiciel antivirus Avast. https://www.avast.com/antivirus