From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A567CD80D5 for ; Tue, 10 Oct 2023 13:55:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232487AbjJJNzr (ORCPT ); Tue, 10 Oct 2023 09:55:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58886 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232258AbjJJNzm (ORCPT ); Tue, 10 Oct 2023 09:55:42 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AC5A89E; Tue, 10 Oct 2023 06:55:41 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5121AC433C8; Tue, 10 Oct 2023 13:55:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1696946141; bh=CAC3ydJqdRBVcEoBwK9bf67K3RO2fxSTF5IMiNQO4dg=; h=Date:From:To:Cc:Subject:Reply-To:References:In-Reply-To:From; b=pZ5IVSp/ybAsYDh+hx4w80XtSoyiLhJiumboqq+iPlqTNn9eJarj1uDzYk6xgiEbI Vq7fUkNTHi2wE15vKo9fwJMLyOXrDKf6/ULWdUShAE/fWprfbziD5D0yjxt6r4SwUn lV1RpCL0H681Q+gSiswgQUBR9jtF1gu0hZ9y8AheVt1KYKPnrf2HZU6HG6DAc1/i86 Qz7O3IIOJygTKD6ombCkvx6tYUwrDcrODM75WOX3m2CFQ3lL6FDISusfe7/4Mf6IiR irWI5sydAAFcpHqsOCjZgW7ImjbXEZSoxViPKsOR5thF7rH57nH+d6Cg6Q1DdAJymF sVlc3OdAYK18g== Received: by paulmck-ThinkPad-P17-Gen-1.home (Postfix, from userid 1000) id EB10BCE0C54; Tue, 10 Oct 2023 06:55:40 -0700 (PDT) Date: Tue, 10 Oct 2023 06:55:40 -0700 From: "Paul E. McKenney" To: Frederic Weisbecker Cc: LKML , Dan Carpenter , Boqun Feng , Joel Fernandes , Josh Triplett , Mathieu Desnoyers , Neeraj Upadhyay , Steven Rostedt , Uladzislau Rezki , rcu Subject: Re: [PATCH 23/23] locktorture: Check the correct variable for allocation failure Message-ID: <97ecfb49-e500-45f4-86bb-769b2d32e91c@paulmck-laptop> Reply-To: paulmck@kernel.org References: <20231010115921.988766-1-frederic@kernel.org> <20231010115921.988766-24-frederic@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231010115921.988766-24-frederic@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 10, 2023 at 01:59:21PM +0200, Frederic Weisbecker wrote: > From: Dan Carpenter > > There is a typo so this checks the wrong variable. "chains" plural vs > "chain" singular. We already know that "chains" is non-zero. > > Fixes: 7f993623e9eb ("locktorture: Add call_rcu_chains module parameter") > Signed-off-by: Dan Carpenter > Signed-off-by: Frederic Weisbecker Reviewed-by: Paul E. McKenney A name change to increase the Hamming distance would of course also be good, though less urgent. ;-) > --- > kernel/locking/locktorture.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/locking/locktorture.c b/kernel/locking/locktorture.c > index a3abcd136f56..69d3cd2cfc3b 100644 > --- a/kernel/locking/locktorture.c > +++ b/kernel/locking/locktorture.c > @@ -1075,7 +1075,7 @@ static int call_rcu_chain_init(void) > if (call_rcu_chains <= 0) > return 0; > call_rcu_chain = kcalloc(call_rcu_chains, sizeof(*call_rcu_chain), GFP_KERNEL); > - if (!call_rcu_chains) > + if (!call_rcu_chain) > return -ENOMEM; > for (i = 0; i < call_rcu_chains; i++) { > call_rcu_chain[i].crc_stop = false; > -- > 2.34.1 >