From: Arvind Yadav <arvind.yadav.cs@gmail.com>
To: oleg.drokin@intel.com, andreas.dilger@intel.com,
jsimmons@infradead.org, gregkh@linuxfoundation.org,
lustre-devel@lists.lustre.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Cc: john.hammond@intel.com, dmitry.eremin@intel.com, fan.yong@intel.com
Subject: Re: [PATCH 3/4] staging: lustre: obdclass: linux: constify attribute_group structures.
Date: Mon, 17 Jul 2017 13:11:53 +0530 [thread overview]
Message-ID: <97f530fa-1a6a-b129-4190-2e96f2f0b81f@gmail.com> (raw)
In-Reply-To: <1500270540-5928-4-git-send-email-arvind.yadav.cs@gmail.com>
Sorry for noise. Please ignore this.
~arvind
On Monday 17 July 2017 11:18 AM, Arvind Yadav wrote:
> attribute_groups are not supposed to change at runtime. All functions
> working with attribute_groups provided by <linux/sysfs.h> work
> with const attribute_group. So mark the non-const structs as const.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> ---
> drivers/staging/lustre/lustre/obdclass/linux/linux-module.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/lustre/lustre/obdclass/linux/linux-module.c b/drivers/staging/lustre/lustre/obdclass/linux/linux-module.c
> index 9f5e829..eb88bd9 100644
> --- a/drivers/staging/lustre/lustre/obdclass/linux/linux-module.c
> +++ b/drivers/staging/lustre/lustre/obdclass/linux/linux-module.c
> @@ -405,7 +405,7 @@ static int obd_device_list_open(struct inode *inode, struct file *file)
> struct kobject *lustre_kobj;
> EXPORT_SYMBOL_GPL(lustre_kobj);
>
> -static struct attribute_group lustre_attr_group = {
> +static const struct attribute_group lustre_attr_group = {
> .attrs = lustre_attrs,
> };
>
next prev parent reply other threads:[~2017-07-17 7:42 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-17 5:48 [PATCH 0/4] constify lustre " Arvind Yadav
2017-07-17 5:48 ` [PATCH 1/4] staging: lustre: constify " Arvind Yadav
2017-07-17 7:15 ` kbuild test robot
2017-07-17 7:45 ` Arvind Yadav
2017-07-17 5:48 ` [PATCH 2/4] staging: lustre: ldlm: " Arvind Yadav
2017-07-17 7:42 ` Arvind Yadav
2017-07-17 5:48 ` [PATCH 3/4] staging: lustre: obdclass: linux: " Arvind Yadav
2017-07-17 7:41 ` Arvind Yadav
2017-07-17 7:41 ` Arvind Yadav [this message]
2017-07-17 5:49 ` [PATCH 4/4] staging: lustre: obdclass: " Arvind Yadav
2017-07-17 7:41 ` Arvind Yadav
2017-07-17 7:44 ` [PATCH 0/4] constify lustre " Arvind Yadav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=97f530fa-1a6a-b129-4190-2e96f2f0b81f@gmail.com \
--to=arvind.yadav.cs@gmail.com \
--cc=andreas.dilger@intel.com \
--cc=devel@driverdev.osuosl.org \
--cc=dmitry.eremin@intel.com \
--cc=fan.yong@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=john.hammond@intel.com \
--cc=jsimmons@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lustre-devel@lists.lustre.org \
--cc=oleg.drokin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®