From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f49.google.com (mail-ej1-f49.google.com [209.85.218.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 07F48187872 for ; Tue, 31 Dec 2024 07:42:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735630939; cv=none; b=fbNv3io+JWa1A2fwBZdE28UnQyOx+xWNZ7BEoTf2YgfeC2DTKiqgGTZqellNTkkos6tEF7dwo7Z9kZZo7neWDADfY/C/Nay9sUJamN2SAko+DDwn2ci8uXpb+HIVL5QO922Bb7JKcatxFHJqnMyevjPyaUl9itE7/PTEbT0pqAE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735630939; c=relaxed/simple; bh=OIIIHvRIxIHxEBMmDuGdkER/XB9yAK9pRHFHJSHH2Nk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=iu/zFFOZlySwLBusu/l+WqDd7Wot1fDXXBzV4O71VPX8pqIGK/YY5w6IdoSI64CVTwTx5cePAWx3qyqtyy3W7zriHZIrAffAsvYz0/GqHYx19Vrivyw7StHMgGZ1eu0Rt9H22U2ijQfJPdMjSqcTc0IUSP+UX1S5QXLe9UsQf/w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=openvpn.net; spf=pass smtp.mailfrom=openvpn.com; dkim=pass (2048-bit key) header.d=openvpn.net header.i=@openvpn.net header.b=QsKlaobR; arc=none smtp.client-ip=209.85.218.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=openvpn.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=openvpn.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=openvpn.net header.i=@openvpn.net header.b="QsKlaobR" Received: by mail-ej1-f49.google.com with SMTP id a640c23a62f3a-aa66ead88b3so1798373566b.0 for ; Mon, 30 Dec 2024 23:42:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=openvpn.net; s=google; t=1735630935; x=1736235735; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=SUQ/117o2pVOfsQwHm9Em7LXO/LveElAMhz4OgmXTrM=; b=QsKlaobRqW5WfgOLJhs3QcoRm+6VquQKBWzay6xhNFGXTR/J8tRL5fHdZXwS6n6ssu ob4lTP/qIo8breSwvXl5AKNPmLpgSlDU2ndSA41l7rajEVgsfHqMsBgN1xyPchfVwyQZ 13B07bRIq4h79LY9QxF1/VcRBL3nruIOZTvyAIY7tdmJofoJ7g+6imCdGI/plziHJkTZ NLBrso+YDg8dVzCrVtNlIgbUOdZ5yK0jxHYnZ+YvMMPMfricNI6pAonwwKZLBO3glz0s Rq5kt+Q2w1oaWyIGj8Vsjz6mlIMbd80sgreGa4+x1wRsnFp48uCOfT1Ifh+rC4ho1/3d YR8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735630935; x=1736235735; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=SUQ/117o2pVOfsQwHm9Em7LXO/LveElAMhz4OgmXTrM=; b=h+LDq7M/Yum0L2N8T5X1WdT4U7s1sU9gY8ybEEVHaMGCRT3gWm2kssang7oLxsiB2I FBkf8xvYCuR+z4Gs7SNMlhXDHyeS7PXVaZRyw9jV8q4YJubnX/tmPBQNP+vlF0B/ahBO 0VuujRsuR5Io+5I5TMlbIdBoXn0FM8kxhTb6Jieja/X5mcPpJqD3XC5hB4t8oc9kdqxZ KDqkZeNrzBoOwKW/0htlSn6voJ5YsIJo1Go19pj6aAjrO1QyM1VtKuuKz2K//zQvUeWS hr8by5QG9H6chlAOAQLwtQvnEMs4kPgHMR5phcsmpesh8LwxdTysYv/gKpVJdIE1gW8+ QZ4A== X-Forwarded-Encrypted: i=1; AJvYcCXCQFNZEos4mDyH4J/zXRust1fTVkXiF03Z7d7S3WQBOrRwOykLq7VwGuneg3ljQWWHU9k2671vCSQvyLI=@vger.kernel.org X-Gm-Message-State: AOJu0YwJz99GIFblK15r+Ke/gJ0cmh9Rg3YohA2BuG9dl5Ym00+9A1JK Sa90eOzd5rdObqipbHyOjEj5u6wINJhs2GwwmHzg3g2FjP9c2ZB6FZ8kLjlVqUs= X-Gm-Gg: ASbGncvc3vx1KvuXbCL7rzFG5De9NkVlanYlTEmLlrpZVnHBfYjck0c8M9bZ7Nrh98L va9ZbbOJC4IH5IQqMKmTgBZ9Gt2+Ik6eCMbIvqmBu5N8X1G5tahmspMzQFU7hxj3i9tNnC8veP6 ygjygJwahNMTxZt3vk79ho2rEjwo1E55+gtg8m0xRTGBgZFneSR4PhWATI6nxb3K6FTHife1W9P o89g9cyD1BUSwnJlGBxdD9REjKm6u1+mMHb9DWdXDnDo4Qj4x+qNvbhy5UcbwLovg== X-Google-Smtp-Source: AGHT+IHJ3LZn/dw6Q3RdklojRoLZ4JYqxGeF/O2KsycT1HvQOXnJk5lDUSk8vRMOcWtIAvIoEXjYaQ== X-Received: by 2002:a17:907:7f8e:b0:aa6:995d:9ee8 with SMTP id a640c23a62f3a-aac2702ae5cmr3305806366b.5.1735630935342; Mon, 30 Dec 2024 23:42:15 -0800 (PST) Received: from ?IPV6:2001:67c:2fbc:1000::1001? ([2001:67c:2fbc:1000::1001]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-aac0e89490dsm1538233666b.45.2024.12.30.23.42.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 30 Dec 2024 23:42:14 -0800 (PST) Message-ID: <97f8ebf1-bdea-4084-aadd-360d02d00d85@openvpn.net> Date: Tue, 31 Dec 2024 08:42:11 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v16 26/26] testing/selftests: add test tool and scripts for ovpn module To: Jakub Kicinski Cc: netdev@vger.kernel.org, Eric Dumazet , Paolo Abeni , Donald Hunter , Shuah Khan , sd@queasysnail.net, ryazanov.s.a@gmail.com, Andrew Lunn , Simon Horman , linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, Xiao Liang , Shuah Khan References: <20241219-b4-ovpn-v16-0-3e3001153683@openvpn.net> <20241219-b4-ovpn-v16-26-3e3001153683@openvpn.net> <20241219200222.4b0365b7@kernel.org> Content-Language: en-US From: Antonio Quartulli In-Reply-To: <20241219200222.4b0365b7@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 20/12/24 05:02, Jakub Kicinski wrote: > On Thu, 19 Dec 2024 02:42:20 +0100 Antonio Quartulli wrote: >> +uint64_t nla_get_uint(struct nlattr *attr) >> +{ >> + if (nla_len(attr) == sizeof(uint32_t)) >> + return nla_get_u32(attr); >> + else >> + return nla_get_u64(attr); >> +} > > Fedora 41 has: libnl3 3.11.0 > which already defines nla_get_uint() > > ovpn-cli.c:46:10: error: conflicting types for ‘nla_get_uint’; have ‘uint64_t(struct nlattr *)’ {aka ‘long unsigned int(struct nlattr *)’} > 46 | uint64_t nla_get_uint(struct nlattr *attr) > | ^~~~~~~~~~~~ > In file included from /usr/include/libnl3/netlink/msg.h:11, > from /usr/include/libnl3/netlink/genl/genl.h:10, > from ovpn-cli.c:26: > /usr/include/libnl3/netlink/attr.h:126:25: note: previous declaration of ‘nla_get_uint’ with type ‘uint64_t(const struct nlattr *)’ {aka ‘long unsigned int(const struct nlattr *)’} > 126 | extern uint64_t nla_get_uint(const struct nlattr *); > | ^~~~~~~~~~~~ dang! I guess I will just rename this function to avoid the clash for the time being. Thanks. Regards, -- Antonio Quartulli OpenVPN Inc.