From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751534AbdI3OGg (ORCPT ); Sat, 30 Sep 2017 10:06:36 -0400 Received: from mail-co1nam03on0071.outbound.protection.outlook.com ([104.47.40.71]:17952 "EHLO NAM03-CO1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751028AbdI3OGd (ORCPT ); Sat, 30 Sep 2017 10:06:33 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=brijesh.singh@amd.com; Cc: brijesh.singh@amd.com, Paolo Bonzini , =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= , Herbert Xu , Gary Hook , Tom Lendacky , linux-crypto@vger.kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] crypto: ccp: Build the AMD secure processor driver only with AMD CPU support To: Borislav Petkov References: <20170929151607.zn4lmdkyn25sczfg@pd.tnic> <20170929162322.47553-1-brijesh.singh@amd.com> <20170930083054.eeblfi65qpz2xop7@pd.tnic> From: Brijesh Singh Message-ID: <97fbfa26-48df-419d-cd41-1a34e6c5eff3@amd.com> Date: Sat, 30 Sep 2017 09:06:26 -0500 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20170930083054.eeblfi65qpz2xop7@pd.tnic> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US X-Originating-IP: [165.204.77.1] X-ClientProxiedBy: DM5PR1101CA0015.namprd11.prod.outlook.com (2603:10b6:4:4c::25) To DM2PR12MB0155.namprd12.prod.outlook.com (2a01:111:e400:50ce::18) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 1c0d1e8e-7354-4150-85ba-08d5080c7329 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(2017030254152)(48565401081)(2017052603199)(201703131423075)(201703031133081)(201702281549075);SRVR:DM2PR12MB0155; X-Microsoft-Exchange-Diagnostics: 1;DM2PR12MB0155;3:019OwreIeH0sUnJjzNoWvbj1EmMVNp4U5lUNMqGChTm5w7R+Abx6iXEVTSpoqWvuaBY4IhD5NT/PHMmYuMh2c4oH9sgp9eQ/4ykxkWSq8anHbDY/VLAY+c6XBkwnxqvV/mq4uJUx6l7yE3R1FgcPEy1tvabApsXUkD7TX7LAoQtf5dqUJ+y58dDK+e5T8GOG/ZiIE1t5HyTKpDo/1PJeaeNq2gKUTo7zW+vPNCnsvV7LynVzdlJbZhiWmdvtTTF1;25:kKD/R6qRlzCuHnYArzW1G5B0L11L9BB0rY9CbwK8TIIali3Zfsa6EcOCMT9TMe4390sx5fNxMnnSe4OOJ+HWilGG5EJHzms390BrveIQG5jgCc3o4rT8WAb3DY23iRCaqIJRjwrxyrQ+4yOIHl0JT2XMNDZl5h/XC1tnt/O4ofJsKCWKnVxbmw77iyOAxe0fyMUDKL2BTMtLM1ycJ6vsJFR/unqy8RzJ8wuwVJ9LDx4wBPZr724HqFOZT12l341whasxILvnM6QqWB7j0JPXioehxdmE6lCn0zWPV3aektV/MlzZUIUPkoeWUV4uY2txjb0czMyxRaKNJA7Wz09R/A==;31:GXUUNTNnmdPMHfqkuwn0O7Ns/VRYgJYJLU19ubPpdRa/3dkwySD0sGT2JRAEoUzeld3bS8tKnmQGzhMPqpWYv+0ES4yyUpBxTz5kOoaICKwxoVT9Bfy7jvQjzVLAP9Rs0+AbZ+wIyCpE7mznk85/COToZgrtcwkJEktt1Z9GimvWTeBncN079DSUlcDO+QN0UJ9m4L1UklVP8rgvqgBQu7FOXNgjkWSyP+FWdRfxvoQ= X-MS-TrafficTypeDiagnostic: DM2PR12MB0155: X-Microsoft-Exchange-Diagnostics: 1;DM2PR12MB0155;20:3bOgCNXHwfG9v9zx74ADxkNswdBNPGEYgLYs4RjtY+XlWMONN9jW43mnj1jXFwpotJ+T9Ax6PGtFNoicJVTvV3ip5qIB2dANGnAHcXR9c0Q1gxorjQD5I/SsuMsn3gtjpoJXLh2Fcj5bI7rYOvMzXUdPEWkwxOxK6VS13G8cNB0QfsZy5RlFrthskhJeX3gvDzxzB+evPGb/knaL2SR5wDzhbSDHD1HZkOZd6NRULNBCBl5vN+nThwy2WZ8BbU1NongQQX4aVVa5TmjXTcZtRg11q8g6OOScBb5fJp5wSAMgeRSN0rjNySvQGQj9lEXqNGOQDabBq+kA2DfzPkJfwhHJeUgwZhI1GRSR3NeTVgZfwvbZsv9n4B9ICieYJSPrC5z6y4QuHXC8RFdblcsF3UTowlqNxPRj02cIDuJ8q4GP0SvgAQszzFmvnUJUbZ5uJlWxJzLRodtnligQJOeBtbeEXxJpBKUKY0zgIlnr4ND+VEK33DJmMAYOdYNS82xP;4:2Oq5XMhUAzJ6E4uwEPWLCLwsSM26COxd9hhu0UEu+5SBqEhDjFhDkUuR76bVL0+RnKORqH7isdqwTt8NnhTfQkU3mhBgN3SExpnRJ21G+fXR9ighgWHibDkv5t+uCrl0DENO6kXspxX3+LZUaDGImlx0BOQb0v3WKvP/T5idz9dWEy90bAubVNCUbky3xWaAWXkou8KrECozbgq9S52jmUVyznEWiHO5lCqni89P3jRRvjT15PpdFNB/is5orr4EH7bwryU2DLAaieQZDQFE9ethpR6sup72AnpBnuWZyoJQfUe3JhEFjcZHVA6SzS5yJPrcVhGAdcrcN56fAKhzxw== X-Exchange-Antispam-Report-Test: UriScan:(9452136761055)(767451399110); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(3002001)(10201501046)(93006095)(93001095)(100000703101)(100105400095)(6055026)(6041248)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123564025)(20161123562025)(20161123558100)(20161123560025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:DM2PR12MB0155;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:DM2PR12MB0155; X-Forefront-PRVS: 0446F0FCE1 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6009001)(39860400002)(346002)(376002)(189002)(377454003)(24454002)(199003)(6246003)(105586002)(6116002)(65826007)(68736007)(54356999)(50986999)(53416004)(101416001)(76176999)(64126003)(6486002)(66066001)(65956001)(65806001)(8676002)(36756003)(229853002)(189998001)(8936002)(81166006)(7736002)(305945005)(33646002)(5660300001)(53546010)(53936002)(83506001)(97736004)(50466002)(6666003)(81156014)(2906002)(106356001)(3846002)(230700001)(16526017)(316002)(31696002)(86362001)(47776003)(31686004)(58126008)(54906003)(2950100002)(6916009)(23676002)(478600001)(4326008)(25786009)(217873001);DIR:OUT;SFP:1101;SCL:1;SRVR:DM2PR12MB0155;H:wsp100707wss.amd.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtETTJQUjEyTUIwMTU1OzIzOlFDU1d0YWFJckFGQlhmQStOblIxeHhlcUls?= =?utf-8?B?S1VkblFjZXVvaS9qRFhoeHZNQ1JwNmdkMkQ4OFRaaC85OXJzUHJyWHZIM0lu?= =?utf-8?B?MnBmOUJqM05hcmdpWXpodmNkNWM2RnRSOGtrenZqbVUxczkxVjNMQy9xVURr?= =?utf-8?B?TFY5REphRFJXRkcweEIxQmRiTldPaTNrTzVqVm1WakRMOUM2MUM5ejR6b3hQ?= =?utf-8?B?UjRIR2tVdE0ycVo4eG1pUUFvemFMMy9RdnFDY1NVN1JNOWIrQkt3ZzR2eHdh?= =?utf-8?B?RmttQ0VTemxzRVc4QVJqbEVVYWc5czlyUWg2bnVab3FJU092ZzhLdzZ1Nmo3?= =?utf-8?B?eFVqc29SWlVsY3VTZnRFSjQwbmhVZy9SdVdzcnNHQlBRUXdBMW8yVGJ5Sldq?= =?utf-8?B?VEtVY1FIZGJ3dEtLS3AraklqVFRFVVZaZXlVMkhqcHRxSVpOS0JaM1IyT0Y5?= =?utf-8?B?ZUtLUjgrR3psdUNaK2JXQmxJeUdZYTJMWHBwSHh5TjRXT1Q0TlhnZWRuc0Q0?= =?utf-8?B?RVV3UlhuNm5rM3l4ZHEzWnhsTkRERlM3L21tY0svRWI3UHJsWGlBa0RzbjI1?= =?utf-8?B?YXNjeXpuK2l1SysvQ1JWSkNCdWd5QVRVeFRzTnRIVkRNSDV2NUhpUHhlZ25i?= =?utf-8?B?d3FJQXVybWFUeTIrdXRLSFFnbUJHTjVqMU93bGJaQ1AzQ3Uydk5kWlFqT3k2?= =?utf-8?B?VzNDaGlaRlZXRTdLTXMwN3JuZkhIMVpJVS9XQmFGMFhONGR6dldZWlBuRndK?= =?utf-8?B?aVhPc0dOalFDQ09PVm1aMENqQWRmSllEejdvSG9lM2Fsa1FYcDdIWXFBU2R3?= =?utf-8?B?RUxzTXA5ZU9MZ0NDYTJ0SzlCU1M4TFRjVC9EamdBU2pMT1czUytTMzlPWDBw?= =?utf-8?B?SVNkUGtsQjhGOFhRZlRYRDhSQWNpU3lRUTQ3VG9hM2xLY2pJMnp1cVpoSVUv?= =?utf-8?B?S2tETCtHS0xFOVFVa1VrTlR6N29CVHZYOHJ0K3BJNWVZZEJXOUxGUUFPWXRB?= =?utf-8?B?MUtJWm9WVUZOQXdaVnVTK2Y0c1NoTzlKMkJHRTF1UTFLUzBZckoxMTFDdmYy?= =?utf-8?B?VjNVVDhadjV0cHFpclZZYWNPUHByUUhBQ2dGTHR0eWcrT0dOOXBuL2VYSjJD?= =?utf-8?B?eVhtaHFCcHAxRkU0ZEFydjEvTG8vSXRCQVpMRW9vNmw3RStHdGw1LzJzejhK?= =?utf-8?B?NjYzL1NlZm8zelZlc0hPNHp6QmEvdWNJK0FEMlpZdGNPU013U1R3MjQrazNk?= =?utf-8?B?cjNOczNuVXRnSjZTM1pGd21lVmRVZDJNRXN0N2JWbUNWQUptVnVYYjgyck9q?= =?utf-8?B?WmdqcGpPdnBpdnAwcUxGU2ZNQlVxSHVTWDBKdTFzZG9SZHhweDdsdG1Gd3Ba?= =?utf-8?B?RHBpOFJVdWVzcW5UbW85QUU1Z1M0VHJOYjdMWkFLTzdhKzQvZGY2cVAvTFhv?= =?utf-8?B?aDQzZzBHWjRDYU95MlQ1SHZmeDR1K0ZsRHdLeDdNN3VrMjBOTEk0cXZFVDFz?= =?utf-8?B?UmFBa3JKRHVpQ3pkaHozMWhCMGUvQ2V1NnFDbEVnTERDYWhYY3pCOFYwcXRL?= =?utf-8?B?eTNVeHNrYkJVT1gvMjdGVEdNVFozVWJGbjNOOW5BM3V6bWwvQ3ZoMUhxWW5N?= =?utf-8?B?R2pGZ2ZpNFBOZ3VlenNFVGx3dzVqQUQ4K0RnQ2NTR2ZBSFFra0cvRmNzQ3lx?= =?utf-8?B?YWJGNUMxWlZMbEE5bGF0VVJVR2JQN2FEUFRJSUJQeWpWREMyMlBxbDdQa2ZU?= =?utf-8?B?MHJKRVNvcEk1UmJmSUd2OHlXUnFvM0RDVEpGSDdsSmd5SEpBTGhuR2ZJSGND?= =?utf-8?B?ZWx5dHRMTWxHcWhYaE8zUUNyaEJQVmd4b09TWHNOdGVaTGZ3NWQ1V2pSUE5Q?= =?utf-8?Q?NHK0t5uhCug=3D?= X-Microsoft-Exchange-Diagnostics: 1;DM2PR12MB0155;6:giT2FYV+Ffvk0x7kiU+6p5WtboVPV8GXzVf+prweLcDxa4J5f2OhRYT38RRKj5UEbkiON8P62caUZNo8wsSVAOgjrvtt2vXYsM4gIE6XjBfPLmYZldWZRGdqP/nG67rfZIAQE8ZAwONJDinffsinMhcj54B4aAqAFZQOYJ7n6c6t3ZmPK/gfRaSZSSV737Zi+JUEWQt4sHetxnbm1sFm6YqCdEEvzpHTyhBaoRwAOHbrEu5303QJzHOII7s7Uu6N4fctzzyWOd1Awe1iui8ZSlxP6KB6kOSNPPU/xkx3sRf+JXtkCNanFEGT3qq2oXBHb94sVK3g4uAKbJT7laaGJg==;5:sdibybMd6KRASOZPY0JU97hHW3XprMh7yop9pHMZI0HbY/GOmT3JyuoPsmpLALJ3COTvZlopirnomZQy5Bgzi6u/oU/JnVDVWIkvDYPt14AZXnRSPOZGqsC4jrSfangvwe1Fm+w97vNe4aw1EU3NVg==;24:wXfiCz1ZZs1qE73bIEDXN13ISs/FkQES9JNvxcalPwwRg4enAeL6DdZg+q8Ma/pgvkNmBJMC4LjeV4TILdP/GU2M62crlXLu/20whziOE2s=;7:DtAr3qcyuWJzr9yUKwiDK6/EXtMANCE33Z6QZuk00Mk5PPkNaYTFEY/tnZ0R4dCwtkfzyfI9I5OOc2TgPgLvTBsRBzZKwTEETGLBVPSDtzIoHs5e7H8fs9zmqPIaVFV+5LXGQtHHPnPdrI0CKy49/e9DyeqAeVTZebAaEfMBJSFkfV6RSpedsiEUsbR2nEA09DEXW6tUvCggLzUGrbAH0RXQ4b5Z3Hwk9rwYJ6P1KJY= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;DM2PR12MB0155;20:QeZJXJRdtgR1YZSWE/hws8HSLMiMa1oCSyXPJIJEOuRDRqPJCMurSvH9EOCwir1qo16DV9a8nOd8gkvCJTSp/1yggddUbPydYPxRBZ0BmNZpFmodFKvrCojX2U+LctHG2fs8jJ+l3hytrIUgEomKoQoVL1cBKLuQzW6uBk3SdcS1mfCBfq35eFqaN4Gz+uOHfwP4TTa3ImpaTkhDIn7lRqm9GMkUqjdbRH1ME5fS7m8QvzvST+elKzaLJf3IL0+j X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Sep 2017 14:06:30.0961 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM2PR12MB0155 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/30/17 3:30 AM, Borislav Petkov wrote: ... > From: Borislav Petkov > > This is AMD-specific hardware so present it in Kconfig only when AMD > CPU support is enabled. > > Signed-off-by: Borislav Petkov > Cc: Brijesh Singh > Cc: Tom Lendacky > Cc: Gary Hook > Cc: Herbert Xu > Cc: "David S. Miller" > Cc: linux-crypto@vger.kernel.org > --- > drivers/crypto/ccp/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/crypto/ccp/Kconfig b/drivers/crypto/ccp/Kconfig > index 627f3e61dcac..f58a6521270b 100644 > --- a/drivers/crypto/ccp/Kconfig > +++ b/drivers/crypto/ccp/Kconfig > @@ -1,5 +1,6 @@ > config CRYPTO_DEV_CCP_DD > tristate "Secure Processor device driver" > + depends on CPU_SUP_AMD Please note that ccp.ko is built on both x86 and aarch64 (AMD Seattle) architectures. I have not looked into details but I thought CPU_SUP_AMD is x64 specific config. I will look into it and verify that we don't break AMD Seattle platform builds. > default m > help > Provides AMD Secure Processor device driver.