mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Vishnu Saini <vishnu.saini@oss.qualcomm.com>
Cc: Neil Armstrong <neil.armstrong@linaro.org>,
	Jessica Zhang <jesszhan0024@gmail.com>,
	David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Maxime Ripard <mripard@kernel.org>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Arpit Saini <arpit.saini@oss.qualcomm.com>,
	dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, venkata.valluru@oss.qualcomm.com
Subject: Re: [PATCH] dt-bindings: display: panel: ilitek,ili7807s: Allow backlight property
Date: Tue, 27 Oct 2026 19:24:08 +0100	[thread overview]
Message-ID: <97ffe608-a69d-4f88-9e1c-fe991a36aa1d@kernel.org> (raw)
In-Reply-To: <auDrCTMk3oCLa91X@hu-vishsain-blr.qualcomm.com>

On 27/10/2026 19:18, Vishnu Saini wrote:
>>>>> Declare 'backlight: true' so the property is explicitly allowed by the
>>>>> schema.
>>>>
>>>> Why do you need to explicitly allow it? Since when?
>>>>
>>>> I see no benefit of this patch and commit msg does not explain me what
>>>> that benefit would be.
>>> It is required for below DLC panel, when enabling backlight using gpio-backlight driver,
>>
>> How is it required? You did not really answer, so again:
>>
>> Why do you need to explicitly allow it?
>>
>> Answer starts "because ... " and you provide technical arguments, not
>> wishes.
> Because the DLC panel node references an external gpio-backlight device through the
> backlight property, but the current DLC binding does not allow this property.
> As a result, adding the backlight phandle to the panel node causes a dtbs_check validation error.

Thanks, but that's confusing or we looked at different source code,
because to my eyes it clearly lists backlight already. Can you show me
how can I reproduce the dtbs_check error?


Best regards,
Krzysztof

  reply	other threads:[~2026-10-27 18:24 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-25  6:48 Vishnu Saini
2026-10-27  8:12 ` Krzysztof Kozlowski
2026-10-27 10:57   ` Vishnu Saini
2026-10-27 14:34     ` Krzysztof Kozlowski
2026-10-27 18:18       ` Vishnu Saini
2026-10-27 18:24         ` Krzysztof Kozlowski [this message]
2026-10-27 18:55           ` Vishnu Saini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=97ffe608-a69d-4f88-9e1c-fe991a36aa1d@kernel.org \
    --to=krzk@kernel.org \
    --cc=airlied@gmail.com \
    --cc=arpit.saini@oss.qualcomm.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jesszhan0024@gmail.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mripard@kernel.org \
    --cc=neil.armstrong@linaro.org \
    --cc=robh@kernel.org \
    --cc=simona@ffwll.ch \
    --cc=tzimmermann@suse.de \
    --cc=venkata.valluru@oss.qualcomm.com \
    --cc=vishnu.saini@oss.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®