From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CE4B72D97BA for ; Sat, 4 Jul 2026 19:48:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783194505; cv=none; b=IyaGEyACcf1Pto8U+b6YLwIp5pTtXGEvr23CGRMqnJnfpQTk07zAhaLiAU3PE4qQBKSNJu0SHJoC5fmU1at5zyeDp6YyoZcsczUC2pRnvDqUuIoGBVf3w6iqqZm6JlYdjubLD3I98IIXIA531FhtK+MuPTbCh3Ltos3lz9yY/Bs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783194505; c=relaxed/simple; bh=IwJ+wvk7kB5TZLk4OyHhlW2Zy1qE0t2FKImu1jcru8c=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=AxLUt51u/MriExn1GTSdFf0scOmS3nV+9yT6T/f0haz5lf1/pwTdozM+Bvs0Ig4alolw0xjOIqxhwrimIqaAnXHNUCLWbwMFFUx430AzYSqWij9z7YvIUdhoUDS+jwxs2P/KRh4MW1xY9apr1rEBwMQEgopuUMB2rID9QYdAIwI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Piy9M9z2; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Piy9M9z2" Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-493d3135f62so2497485e9.2 for ; Sat, 04 Jul 2026 12:48:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783194502; x=1783799302; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=kREsOPDfNFErk1qJgbzlZaBpqgqmcQBNj8RDdAgPTJo=; b=Piy9M9z2bpltvMf9cn/dYf4mkfKZifW3mZx9s6YeApHO5jdmFLcglxTrOgsR7Qq6sO DPzH3A+FgX/6Ydx/3mlce2haBmcbKeGxQFx3FLgWDU4SrIFpX1Xw2QUHOIcaUCr7Z5DK 6C8u+bZRyoN5fSCIDj5LPrIxapKW6lvpqHB0+uGk2gdlhW9AJfcoGZ+twltfS4P9i3Yx /ILutTD4PzqoBnlH26HfQT6lGiVb3Tja+oUAg5dhP6/i8m+lhHbiehB8PSlcNvl/QFGJ +LogO61WonKfncHbIQLEH/FKcWJXYYGGzd3w3WcEzZaNLDzhCYn0zvHzl4gp8J4lwPbT XKRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783194502; x=1783799302; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=kREsOPDfNFErk1qJgbzlZaBpqgqmcQBNj8RDdAgPTJo=; b=N4Uin3AlVKYtwOFL/n+JZoxLzEaKwTqx5wEdQKuJz4jiDKduzg0JjWwefqP5pYZ8hz /oQT0DSyaujbZAN1AlZcHCYTxMx1rSTq1pCO7PFOM/X8waIJ7OLF7J8Ku4/MaV9teLF1 0vVaiVMJi2pnz75E++rhR5uNpUlj/rMUp2Wj6cw2Ym0ZhVT3TfaB0TyWX9AomWabfUAP PzrosIdBpB+7XX4uEUpG3NoBwPcvieTxQe/nSCc/IPIRK39zlAG1lHxqJP8nJVuKrexB 0rsFqd2kVVjttnrZWhhtxMn9p0/HmD0lByLAen9If84jgucBPskoPwhvKSfVfM2loR6d rxaA== X-Forwarded-Encrypted: i=1; AFNElJ/PhcoQ4d7DHcplJ20fYMZJoJ/nFxNvk5Wg7WHMojDIBBRLrOCpl7XFTeNO52LmqQpCN37GoW+g2/8WZQ0=@vger.kernel.org X-Gm-Message-State: AOJu0YyaaN7Kr0ROGVfRx5j4u8IJD5ipFXmUfrgyxrTTt79qL0NTubWV tMjkST/8/BNXIG/ni9Cl23Pk+to5e86WnA9NYvpkY/CxgVK/jnsx+/+3 X-Gm-Gg: AfdE7cmCye3+Cm/ZW62bruJguzczDckZHkOgWbwkmMIKlMJ/rvs8CLIDUep7EDVIsOq 8vLklE2YoKlx0AbgY1DQuE2r2Oglh9AR5ACZAW5gQAsuhfvrvDZ00B0TOcSn+RrxhVnsOI5umCy ZUzUS1tIVPlkly8saRuE9bk9TNxZ3AJugCAyVJWAxPlG3dHRfNbOxD7GQ7Dek0d9TYKPRwqeVeJ ivO20U+WeJepi6KNGI7s0N7/U/FlkIC+GWvhbKIg1g5+ozKruiDpU5QXWFHloAWAn8z6lXvCbix y5o7R6cqcRIVJFjWNiJebFjJlEj0mJW1EA4eQmx1Hlebpd9waD73W/0yrfqBh1WYk7Ct7+oEXB7 dfQHR19+80wpRtYYDjt82uPMvm2sZ4IzhCH6n32UH0ydQoSQ++sb0NsXHaOx7vohEfN8ef5zuAb BVXeGv093P887WRyJfvtlf6YbTCg+RpwaV6W75FlE7ELnQt4H9EexauMETXHbRqCsXSpoILZrdZ TrAtHxT0CE= X-Received: by 2002:a05:600c:8708:b0:492:4911:8a with SMTP id 5b1f17b1804b1-493d11db676mr45087455e9.12.1783194502227; Sat, 04 Jul 2026 12:48:22 -0700 (PDT) Received: from shift (p200300d5ff229f0050f496fffe46beef.dip0.t-ipconnect.de. [2003:d5:ff22:9f00:50f4:96ff:fe46:beef]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493c63172fesm404118485e9.0.2026.07.04.12.48.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 04 Jul 2026 12:48:21 -0700 (PDT) Received: from localhost ([127.0.0.1]) by shift with esmtp (Exim 4.99.4) (envelope-from ) id 1wg6Lc-00000000Jo5-0gFR; Sat, 04 Jul 2026 21:48:20 +0200 Message-ID: <9800b46a-1d24-472c-8f94-eb54386c2605@gmail.com> Date: Sat, 4 Jul 2026 21:48:20 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/3] wifi: carl9170: bound memcpy length in cmd callback to prevent OOB read To: Tristan Madani , Christian Lamparter Cc: Johannes Berg , linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, Tristan Madani References: <20260421134929.325662-1-tristmd@gmail.com> <20260421134929.325662-2-tristmd@gmail.com> Content-Language: de-DE From: Christian Lamparter In-Reply-To: <20260421134929.325662-2-tristmd@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 4/21/26 3:49 PM, Tristan Madani wrote: > From: Tristan Madani > > When the firmware sends a command response with a length mismatch, > carl9170_cmd_callback() logs the mismatch and calls carl9170_restart() > but then falls through to memcpy(ar->readbuf, buffer + 4, len - 4). > Since len comes from the firmware and can exceed ar->readlen, this > copies more data than the readbuf was allocated for. > > Bound the memcpy to min(len - 4, ar->readlen) so that the response > is still completed -- avoiding repeated restarts from queued garbage -- > while preventing an overread past the response buffer. > > Fixes: a84fab3cbfdc ("carl9170: 802.11 rx/tx processing and usb backend") > Signed-off-by: Tristan Madani Acked-by: Christian Lamparter > --- > Changes in v3: > - Regenerated from wireless-next with proper git format-patch to > produce valid index hashes (v2 had post-processed index lines). > > Changes in v2: > - No code changes from v1. > > drivers/net/wireless/ath/carl9170/rx.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/wireless/ath/carl9170/rx.c b/drivers/net/wireless/ath/carl9170/rx.c > index 6833430130f4c..f6855efc05c0f 100644 > --- a/drivers/net/wireless/ath/carl9170/rx.c > +++ b/drivers/net/wireless/ath/carl9170/rx.c > @@ -150,7 +150,8 @@ static void carl9170_cmd_callback(struct ar9170 *ar, u32 len, void *buffer) > spin_lock(&ar->cmd_lock); > if (ar->readbuf) { > if (len >= 4) > - memcpy(ar->readbuf, buffer + 4, len - 4); > + memcpy(ar->readbuf, buffer + 4, > + min_t(u32, len - 4, ar->readlen)); > > ar->readbuf = NULL; > }