From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 63F185588F for ; Fri, 20 Dec 2024 09:29:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734686955; cv=none; b=Pi8St9Rsl8iTIrdkKaD4LRW9q9czrTTRFtde4CVd9Z3ABIwqAFwICEDlm4UaWhuYx0KZLKFPU5RW8au+Qn171Nu5tClv1kC2wuJof/h9rxeZxoiZ0KlCqYAwW6/ng10xvf0bmMmiqDcElSOx5xUbtNyaLlV36gcaiMbqk+Jbxfg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734686955; c=relaxed/simple; bh=7NVspW2N9/nnEycXBEp5P9ilFA7sn7OJXpabrG1aUSk=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=rEFDCvV/VwSmcJvvjc1gREvAsHN6lACWOWaP21CxwzGyredFcKXwybAvH5MmdKZVtrPca07DVsEllwzalPbCfdphe0L2cio6ZqsOG6LPcZxK4HREK7xETECelCNzbBRvlc5YOC442yRthaN0C5ODz+0cu2UL5H9COa4/sFcQDAI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=OHHutufu; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="OHHutufu" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1734686952; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7NVspW2N9/nnEycXBEp5P9ilFA7sn7OJXpabrG1aUSk=; b=OHHutufuRmJY2yZb4hPXG/TKtP2NASbMgL/9Cx3dxVuWAyZ6yMMVGSXXRuDNDJPGGJ8Sdm 81FkxjW7RWaqJHkOZ5r7iR549dx7AB9ORv0vt9ycF26lnczP3ypIYj0ZC7vdsn+vNODKe9 jof8Re9J9q5lOEwfReM5h8LXPFTtrKk= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-661-ym_GNuRFMjuo5FIAAm8zZw-1; Fri, 20 Dec 2024 04:29:11 -0500 X-MC-Unique: ym_GNuRFMjuo5FIAAm8zZw-1 X-Mimecast-MFC-AGG-ID: ym_GNuRFMjuo5FIAAm8zZw Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-43631d8d9c7so9576635e9.1 for ; Fri, 20 Dec 2024 01:29:10 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734686950; x=1735291750; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=7NVspW2N9/nnEycXBEp5P9ilFA7sn7OJXpabrG1aUSk=; b=P3+I4VHGT3ymd77/XewnMgLYbNcf5yiDIbpM3trMK1d/ZDpJ50n0utVRPG3vxkR5NG rZPcFyu03tBb3HQRPBY/j5nbNNJnxIEAcjq1hD/UPPlhf/AthCrNGa0EQPzSgjcUYYfm NcOotE801eVDUvuwqNLx64GNiKo7ViFMkkeO6Emf1fgx6U/5TOqWjVVb6bcAdJvY2eQU zzucPkreHwU/PflZ3ksqk+8NNva7NHZTiQKYUQwtc98TkohcMRLoXtsU/QJ/HrPzPKOE 2NaaYpuItYuC8cEAmVs+jmcrLHveS4yVRf0BkLSFQg2EbiCi/skGbOKyUn8EnlUqbery bEpw== X-Forwarded-Encrypted: i=1; AJvYcCWzVUlECXVGTuYIh933aYIp3Go3nMPdWnXLDMmBOUkrpN2a73tQwjIy1anrw/BnauRLA9UfCKt8BK4gELU=@vger.kernel.org X-Gm-Message-State: AOJu0Yy1Ntlb9HZvKVaigirnG8KzuR8ufLdnzi2JTn0EMazcahXFKD3n ZlMqSbu3HlJFKH7op0BStmsMj+SbS0B2cOX5pmqi+lDG4iB03nYu2tKk/zdPE8iuucWLBVNKvm+ mRTHHfyUAVBfQE0FljWi9RchYCr0r7GrY0I6dyD36/dHhH4c1PnjPBiPn2BGNsg== X-Gm-Gg: ASbGnctUmD0j1VhmI3V7DfAJAAZQK9AHG1SKmDtR2aX82xIRcucusCqsohXVcru0Gx6 pkarfvinD3nIC+QSLDw9rQLTMdBa4vypp4gpK2KaWi0uHevbbD1+nve3eoe4cYNVS5lgBsYzK9+ yZE7BebDmtjtm9ZRFmbhPk/ORHbxFZ6cHivLsHJgB1Tzf1QaEQ/6481PZjFGk1jOAwwX0yq3s2E t4PEfNXHGLNcfonQAg86Q9gqTFjvA257Ku9RTzgIG8uBfP1WX2kfGaDZIfWoYebHA58g87GxxYq 2zmz09fQNp6OsPJsQGi4uFWFy0SKkTk= X-Received: by 2002:a05:600c:3596:b0:434:f1bd:1e40 with SMTP id 5b1f17b1804b1-436697f917fmr16506285e9.6.1734686949625; Fri, 20 Dec 2024 01:29:09 -0800 (PST) X-Google-Smtp-Source: AGHT+IGAgRWuaAvDXWDRZqcewAmpb5XTckPo7Go/SgGSQnqpV8nhLUAtPoayxjas2Nj3NQZO3WPEOA== X-Received: by 2002:a05:600c:3596:b0:434:f1bd:1e40 with SMTP id 5b1f17b1804b1-436697f917fmr16504925e9.6.1734686947873; Fri, 20 Dec 2024 01:29:07 -0800 (PST) Received: from ?IPv6:2001:16b8:3db8:2e00:4b6c:c773:a3e0:8035? ([2001:16b8:3db8:2e00:4b6c:c773:a3e0:8035]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38a1c84722dsm3590722f8f.53.2024.12.20.01.29.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Dec 2024 01:29:07 -0800 (PST) Message-ID: <980135e6c31a88c41671eb01002b65ce439cc38c.camel@redhat.com> Subject: Re: [PATCH] drm/sched: Separate drm_sched_fini() driver checklist From: Philipp Stanner To: Bagas Sanjaya , Linux Kernel Mailing List , Linux DRI Development Cc: Luben Tuikov , Matthew Brost , Danilo Krummrich , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Christian =?ISO-8859-1?Q?K=F6nig?= , Stephen Rothwell Date: Fri, 20 Dec 2024 10:29:06 +0100 In-Reply-To: <20241217034915.62594-1-bagasdotme@gmail.com> References: <20241217034915.62594-1-bagasdotme@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.52.4 (3.52.4-2.fc40) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Tue, 2024-12-17 at 10:49 +0700, Bagas Sanjaya wrote: > Commit baf4afc5831438 ("drm/sched: Improve teardown documentation") > documents drm_sched_fini() with a post-function call checklist for > drivers. The checklist triggers htmldocs warning (but renders > correctly > in htmldocs output): >=20 > Documentation/gpu/drm-mm:571: > ./drivers/gpu/drm/scheduler/sched_main.c:1359: ERROR: Unexpected > indentation. >=20 > Separate the checklist from preceding paragraph by a blank line to > fix > the warning. While at it, also end the aforementioned paragraph by a > colon. >=20 > Fixes: baf4afc58314 ("drm/sched: Improve teardown documentation") > Reported-by: Stephen Rothwell > Closes: > https://lore.kernel.org/r/20241108175655.6d3fcfb7@canb.auug.org.au/ > Signed-off-by: Bagas Sanjaya Applied (with some adjustments to commit message), thank you P. > --- > =C2=A0drivers/gpu/drm/scheduler/sched_main.c | 3 ++- > =C2=A01 file changed, 2 insertions(+), 1 deletion(-) >=20 > diff --git a/drivers/gpu/drm/scheduler/sched_main.c > b/drivers/gpu/drm/scheduler/sched_main.c > index 7ce25281c74ce5..57da84908752c6 100644 > --- a/drivers/gpu/drm/scheduler/sched_main.c > +++ b/drivers/gpu/drm/scheduler/sched_main.c > @@ -1355,7 +1355,8 @@ EXPORT_SYMBOL(drm_sched_init); > =C2=A0 * drm_sched_backend_ops.run_job(). Consequently, > drm_sched_backend_ops.free_job() > =C2=A0 * will not be called for all jobs still in > drm_gpu_scheduler.pending_list. > =C2=A0 * There is no solution for this currently. Thus, it is up to the > driver to make > - * sure that > + * sure that: > + * > =C2=A0 *=C2=A0 a) drm_sched_fini() is only called after for all submitted= jobs > =C2=A0 *=C2=A0=C2=A0=C2=A0=C2=A0 drm_sched_backend_ops.free_job() has bee= n called or that > =C2=A0 *=C2=A0 b) the jobs for which drm_sched_backend_ops.free_job() has= not > been called >=20 > base-commit: d172ea67dbeec5c90f72752c91d202d5718e3754