From: Kuogee Hsieh <quic_khsieh@quicinc.com>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Bjorn Andersson <andersson@kernel.org>
Cc: <robdclark@gmail.com>, <sean@poorly.run>, <swboyd@chromium.org>,
<dianders@chromium.org>, <vkoul@kernel.org>, <daniel@ffwll.ch>,
<airlied@gmail.com>, <agross@kernel.org>,
<marijn.suijten@somainline.org>, <quic_abhinavk@quicinc.com>,
<quic_jesszhan@quicinc.com>, <quic_sbillaka@quicinc.com>,
<freedreno@lists.freedesktop.org>,
<dri-devel@lists.freedesktop.org>,
<linux-arm-msm@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3] drm/msm/dp: enable HDP plugin/unplugged interrupts at hpd_enable/disable
Date: Mon, 22 May 2023 15:35:13 -0700 [thread overview]
Message-ID: <9804c558-124d-aca4-c534-158c0457b7bf@quicinc.com> (raw)
In-Reply-To: <c4d6e019-1582-c94f-d56d-271c420d72ea@linaro.org>
>>> -static void dp_display_config_hpd(struct dp_display_private *dp)
>>> -{
>>> -
>>> - dp_display_host_init(dp);
>>> - dp_catalog_ctrl_hpd_config(dp->catalog);
>>> -
>>> - /* Enable plug and unplug interrupts only if requested */
>>> - if (dp->dp_display.internal_hpd)
>>> - dp_catalog_hpd_config_intr(dp->catalog,
>>> - DP_DP_HPD_PLUG_INT_MASK |
>>> - DP_DP_HPD_UNPLUG_INT_MASK,
>>> - true);
>>> -
>>> - /* Enable interrupt first time
>>> - * we are leaving dp clocks on during disconnect
>>> - * and never disable interrupt
>>> - */
>>> - enable_irq(dp->irq);
>>
>> ...we need dp->irq enabled for handling the other interrupts, otherwise
>> e.g. AUX transfers will time out.
>>
>> I added enable_irq(dp_priv->irq) to the EV_HPD_INIT_SETUP case below,
>> just for testing, and with that the patch seems to be working fine.
>>
>>
>> Is there any reason why we need to delay its enablement to after we
>> unmask the HPD interrupts?
my though is aux transaction should happen after plugin interrupt detected.
can you please let me know what did you do to trigger aux timeout?
It does not happen on me at my test.
>
> As I wrote, I'd probably prefer to see enable_irq() and disable_irq()
> calls gone.
ok, i will move enable_irq() out of here.
>>
>> Regards,
>> Bjorn
>>
>
next prev parent reply other threads:[~2023-05-22 22:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-22 21:31 Kuogee Hsieh
2023-05-22 21:39 ` Dmitry Baryshkov
2023-05-22 22:05 ` Bjorn Andersson
2023-05-22 22:03 ` Dmitry Baryshkov
2023-05-22 22:35 ` Kuogee Hsieh [this message]
2023-05-22 22:47 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9804c558-124d-aca4-c534-158c0457b7bf@quicinc.com \
--to=quic_khsieh@quicinc.com \
--cc=agross@kernel.org \
--cc=airlied@gmail.com \
--cc=andersson@kernel.org \
--cc=daniel@ffwll.ch \
--cc=dianders@chromium.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=quic_abhinavk@quicinc.com \
--cc=quic_jesszhan@quicinc.com \
--cc=quic_sbillaka@quicinc.com \
--cc=robdclark@gmail.com \
--cc=sean@poorly.run \
--cc=swboyd@chromium.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®