mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Arend van Spriel <arend.vanspriel@broadcom.com>
To: Alex Shumsky <alexthreed@gmail.com>, linux-wireless@vger.kernel.org
Cc: "Alexey Berezhok" <a@bayrepo.ru>,
	"Alvin Šipraga" <ALSI@bang-olufsen.dk>,
	"Hector Martin" <marcan@marcan.st>, "Janne Grunau" <j@jannau.net>,
	"Kalle Valo" <kvalo@kernel.org>, "Kees Cook" <kees@kernel.org>,
	"Neal Gompa" <neal@gompa.dev>,
	"Wolfram Sang" <wsa+renesas@sang-engineering.com>,
	brcm80211-dev-list.pdl@broadcom.com, brcm80211@lists.linux.dev,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] brcmfmac: fix RSSI report in AP mode
Date: Tue, 26 Nov 2024 12:13:44 +0100	[thread overview]
Message-ID: <980c5cee-2dc3-4d26-b749-6ba00b9c2091@broadcom.com> (raw)
In-Reply-To: <20241122210346.2848578-1-alexthreed@gmail.com>

On 11/22/2024 10:03 PM, Alex Shumsky wrote:
> After commit 9a1590934d9a ("brcmfmac: correctly report average RSSI in
> station info") it is required from firmware to provide rx_lastpkt_rssi.
> If this field is not provided brcmfmac doesn't report any RSSI at all.
> Unfortunately some firmwares doesn't provide it. One example is firmware
> for BCM43455 found in Raspbberry Pi.
> See https://github.com/raspberrypi/linux/issues/4574
> 
> Fix it by falling back to rssi field if rx_lastpkt_rssi is not provided
> (like it was before 9a1590934d9a).

Sounds like a reasonable approach. However, I would like to learn more 
about the issue. Maybe it is a per-vendor issue so I am interested what 
the sta_info version is that we get from firmware. It is printed in 
brcmf_cfg80211_get_station() with brcmf_dbg(). You can make it a 
bphy_err() call instead or enable TRACE level debug messages in the driver.

Also would be good to know the firmware version and kernel version of 
the BCM43455.

Regards,
Arend

  parent reply	other threads:[~2024-11-26 11:13 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-22 21:03 Alex Shumsky
2024-11-25 11:58 ` Kalle Valo
2024-11-26 11:13 ` Arend van Spriel [this message]
2024-12-09 21:08   ` Alex Shumsky
2024-12-09 21:43     ` KeithG
2024-12-17 18:54   ` Alex Shumsky
2024-12-17 19:45     ` Arend van Spriel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=980c5cee-2dc3-4d26-b749-6ba00b9c2091@broadcom.com \
    --to=arend.vanspriel@broadcom.com \
    --cc=ALSI@bang-olufsen.dk \
    --cc=a@bayrepo.ru \
    --cc=alexthreed@gmail.com \
    --cc=brcm80211-dev-list.pdl@broadcom.com \
    --cc=brcm80211@lists.linux.dev \
    --cc=j@jannau.net \
    --cc=kees@kernel.org \
    --cc=kvalo@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=marcan@marcan.st \
    --cc=neal@gompa.dev \
    --cc=wsa+renesas@sang-engineering.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®