From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751274AbdKTLnQ (ORCPT <rfc822;w@1wt.eu>);
        Mon, 20 Nov 2017 06:43:16 -0500
Received: from foss.arm.com ([217.140.101.70]:56200 "EHLO foss.arm.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751021AbdKTLnO (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 20 Nov 2017 06:43:14 -0500
Subject: Re: [PATCH] sched/fair: Consider RT/IRQ pressure in
 capacity_spare_wake
To: Joel Fernandes <joelaf@google.com>, linux-kernel@vger.kernel.org
Cc: Vincent Guittot <vincent.guittot@linaro.org>,
        Morten Ramussen <morten.rasmussen@arm.com>,
        Brendan Jackman <brendan.jackman@arm.com>,
        Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
        Len Brown <lenb@kernel.org>, "Rafael J. Wysocki" <rjw@rjwysocki.net>,
        Viresh Kumar <viresh.kumar@linaro.org>, Ingo Molnar <mingo@redhat.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Juri Lelli <juri.lelli@gmail.com>,
        Patrick Bellasi <patrick.bellasi@arm.com>,
        Chris Redpath <Chris.Redpath@arm.com>,
        Steve Muckle <smuckle@google.com>,
        Steven Rostedt <rostedt@goodmis.org>,
        Saravana Kannan <skannan@quicinc.com>,
        Vikram Mulukutla <vmulukut@quicinc.com>,
        Rohit Jain <rohit.k.jain@oracle.com>,
        Atish Patra <atish.patra@oracle.com>,
        EAS Dev <eas-dev@lists.linaro.org>,
        Android Kernel <kernel-team@android.com>
References: <20171109185219.30130-1-joelaf@google.com>
From: Dietmar Eggemann <dietmar.eggemann@arm.com>
Message-ID: <980fc318-50b4-0494-6d20-b76c39ce86f3@arm.com>
Date: Mon, 20 Nov 2017 11:43:09 +0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <20171109185219.30130-1-joelaf@google.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 11/09/2017 06:52 PM, Joel Fernandes wrote:

[...]

> diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
> index 56f343b8e749..ba9609407cb9 100644
> --- a/kernel/sched/fair.c
> +++ b/kernel/sched/fair.c
> @@ -5724,7 +5724,7 @@ static int cpu_util_wake(int cpu, struct task_struct *p);
>   
>   static unsigned long capacity_spare_wake(int cpu, struct task_struct *p)
>   {
> -	return capacity_orig_of(cpu) - cpu_util_wake(cpu, p);
> +	return max_t(long, capacity_of(cpu) - cpu_util_wake(cpu, p), 0);
>   }
>   
>   /*
> 

Looks good to me. Maybe you could mention in the patch header that you 
switch capacity_orig_of() for capacity_of() since its only a tiny diff 
in the hunk.

Reviewed-by: Dietmar Eggemann <dietmar.eggemann@arm.com>