From: "Bill Huey (hui)" <bill.huey@gmail.com>
To: "Ingo Molnar" <mingo@elte.hu>
Cc: "Gregory Haskins" <ghaskins@novell.com>,
a.p.zijlstra@chello.nl, tglx@linutronix.de, rostedt@goodmis.org,
linux-rt-users@vger.kernel.org, linux-kernel@vger.kernel.org,
kevin@hilman.org, cminyard@mvista.com, dsingleton@mvista.com,
dwalker@mvista.com, npiggin@suse.de, dsaxena@plexity.net,
ak@suse.de, gregkh@suse.de, sdietrich@novell.com,
pmorreale@novell.com, mkohari@novell.com
Subject: Re: [PATCH [RT] 00/14] RFC - adaptive real-time locks
Date: Thu, 21 Feb 2008 13:33:34 -0800 [thread overview]
Message-ID: <9810cff90802211333k3d19ca2exf28c18ae5a2b86a@mail.gmail.com> (raw)
In-Reply-To: <20080221212420.GA20953@elte.hu>
It would also help to get the lockdep/lockstat output for those runs
so that more discussion can happen. That framework can be extended to
do all sorts of contention tracking and that is why I took implemented
it in the first place to track the viability of adaptive spins. My
initial results where that about 10 percent (heavier against BKL)
where suitable for adaptive spins and 10 percent roughly for ownership
stealing. The current implementation didn't seem to have those
measurements coded in just yet (unlike my private implementation).
I came to the original conclusion that it wasn't originally worth it,
but the dbench number published say otherwise. It would be a good
thing to get both a precise chunk of instrumentation to show where the
problems are (these number could be skewed by a number of things) as
well as the specific locks that are contended against.
See ya
bill
On Thu, Feb 21, 2008 at 1:24 PM, Ingo Molnar <mingo@elte.hu> wrote:
> regarding the concept: adaptive mutexes have been talked about in the
> past, but their advantage is not at all clear, that's why we havent done
> them. It's definitely not an unambigiously win-win concept.
>
> So lets get some real marketing-free benchmarking done, and we are not
> just interested in the workloads where a bit of polling on contended
> locks helps, but we are also interested in workloads where the polling
> hurts ... And lets please do the comparisons without the ticket spinlock
> patch ...
next prev parent reply other threads:[~2008-02-21 21:33 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-21 15:26 Gregory Haskins
2008-02-21 15:26 ` [PATCH [RT] 01/14] spinlocks: fix preemption feature when PREEMPT_RT is enabled Gregory Haskins
2008-02-21 15:26 ` [PATCH [RT] 02/14] spinlock: make preemptible-waiter feature a specific config option Gregory Haskins
2008-02-22 19:09 ` Pavel Machek
2008-02-21 15:26 ` [PATCH [RT] 03/14] x86: FIFO ticket spinlocks Gregory Haskins
2008-02-21 15:26 ` [PATCH [RT] 04/14] disable PREEMPT_SPINLOCK_WAITERS when x86 ticket/fifo spins are in use Gregory Haskins
2008-02-21 15:26 ` [PATCH [RT] 05/14] rearrange rt_spin_lock sleep Gregory Haskins
2008-02-22 13:29 ` Gregory Haskins
2008-02-22 13:35 ` Steven Rostedt
2008-02-22 13:40 ` Peter Zijlstra
2008-02-22 13:35 ` Ingo Molnar
2008-02-22 13:43 ` Steven Rostedt
2008-02-22 13:46 ` Steven Rostedt
2008-02-21 15:26 ` [PATCH [RT] 06/14] optimize rt lock wakeup Gregory Haskins
2008-02-21 15:27 ` [PATCH [RT] 07/14] adaptive real-time lock support Gregory Haskins
2008-02-22 19:14 ` Pavel Machek
2008-02-21 15:27 ` [PATCH [RT] 08/14] add a loop counter based timeout mechanism Gregory Haskins
2008-02-21 16:41 ` Andi Kleen
2008-02-21 17:02 ` Gregory Haskins
2008-02-21 17:04 ` Peter W. Morreale
2008-02-21 17:06 ` Sven-Thorsten Dietrich
2008-02-22 19:08 ` Paul E. McKenney
2008-02-22 19:19 ` Bill Huey (hui)
2008-02-22 19:21 ` Bill Huey (hui)
2008-02-22 19:43 ` Paul E. McKenney
2008-02-22 19:55 ` Sven-Thorsten Dietrich
2008-02-22 20:23 ` Paul E. McKenney
2008-02-22 22:03 ` Gregory Haskins
2008-02-23 12:31 ` Andi Kleen
2008-02-23 16:32 ` Paul E. McKenney
2008-02-25 23:52 ` Sven-Thorsten Dietrich
2008-02-22 20:36 ` Peter W. Morreale
2008-02-23 7:36 ` Sven-Thorsten Dietrich
2008-02-22 20:15 ` Peter W. Morreale
2008-02-21 15:27 ` [PATCH [RT] 09/14] adaptive mutexes Gregory Haskins
2008-02-21 15:27 ` [PATCH [RT] 10/14] adjust pi_lock usage in wakeup Gregory Haskins
2008-02-21 16:48 ` Steven Rostedt
2008-02-21 17:09 ` Peter W. Morreale
2008-02-21 15:27 ` [PATCH [RT] 11/14] optimize the !printk fastpath through the lock acquisition Gregory Haskins
2008-02-21 16:36 ` Andi Kleen
2008-02-21 16:47 ` Gregory Haskins
2008-02-22 19:18 ` Pavel Machek
2008-02-22 22:20 ` Gregory Haskins
2008-02-23 0:43 ` Bill Huey (hui)
2008-02-25 5:20 ` Gregory Haskins
2008-02-25 6:21 ` Bill Huey (hui)
2008-02-25 9:02 ` Bill Huey (hui)
2008-02-21 15:27 ` [PATCH [RT] 12/14] remove the extra call to try_to_take_lock Gregory Haskins
2008-02-21 15:27 ` [PATCH [RT] 13/14] allow rt-mutex lock-stealing to include lateral priority Gregory Haskins
2008-02-21 15:27 ` [PATCH [RT] 14/14] sysctl for runtime-control of lateral mutex stealing Gregory Haskins
2008-02-21 16:05 ` [PATCH [RT] 00/14] RFC - adaptive real-time locks Gregory Haskins
2008-02-21 21:24 ` Ingo Molnar
2008-02-21 21:33 ` Bill Huey (hui) [this message]
[not found] ` <20080221214219.GA27209@elte.hu>
2008-02-21 21:56 ` Gregory Haskins
2008-02-21 22:53 ` Bill Huey (hui)
2008-02-21 21:40 ` Gregory Haskins
2008-02-21 22:12 ` Peter W. Morreale
2008-02-21 22:42 ` Peter W. Morreale
2008-02-23 8:03 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9810cff90802211333k3d19ca2exf28c18ae5a2b86a@mail.gmail.com \
--to=bill.huey@gmail.com \
--cc=a.p.zijlstra@chello.nl \
--cc=ak@suse.de \
--cc=cminyard@mvista.com \
--cc=dsaxena@plexity.net \
--cc=dsingleton@mvista.com \
--cc=dwalker@mvista.com \
--cc=ghaskins@novell.com \
--cc=gregkh@suse.de \
--cc=kevin@hilman.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mkohari@novell.com \
--cc=npiggin@suse.de \
--cc=pmorreale@novell.com \
--cc=rostedt@goodmis.org \
--cc=sdietrich@novell.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®