From: Jonathan Cameron <jic23@kernel.org>
To: "Stefan Brüns" <stefan.bruens@rwth-aachen.de>, linux-iio@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
Marc Titinger <mtitinger@baylibre.com>
Subject: Re: [PATCH 0/2] Enhancements for TI INA219/220 current/voltage monitors
Date: Fri, 14 Apr 2017 15:45:46 +0100 [thread overview]
Message-ID: <98174c5e-d785-38dc-7d1f-c2b14273539e@kernel.org> (raw)
In-Reply-To: <e91408f6b96d461b8d59b8dbd6849bf2@rwthex-w2-b.rwth-ad.de>
On 12/04/17 04:01, Stefan Brüns wrote:
> The ina2xx adc driver does not handle differences between INA219/220 and
> INA226/230/231 completely:
>
> - The 219 uses a 4 bit register field for for the bus/shunt voltage adc
> integration times each, whereas the 226 uses two 3 bit fields for the
> integration times and an additional 3 bit averaging field.
>
> The first patch correct setting integration times in the config register.
>
> - The 219 also has an adjustable PGA. The default setting allows the
> maximum range, but also reduces accuracy.
>
> The second patch adds attributes for shunt PGA gain and bus voltage
> range (bus voltage PGA), and sets the config register accordingly.
>
> Stefan Brüns (2):
> iio: adc: Fix integration time/averaging for INA219/220
> iio: adc: Allow setting Shunt Voltage PGA gain and Bus Voltage range
>
> drivers/iio/adc/ina2xx-adc.c | 344 ++++++++++++++++++++++++++++++++++++++++---
> 1 file changed, 322 insertions(+), 22 deletions(-)
>
These will definitely need an Ack from Marc Titinger if possible.
prev parent reply other threads:[~2017-04-14 14:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-12 3:01 Stefan Brüns
2017-04-14 14:45 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=98174c5e-d785-38dc-7d1f-c2b14273539e@kernel.org \
--to=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mtitinger@baylibre.com \
--cc=pmeerw@pmeerw.net \
--cc=stefan.bruens@rwth-aachen.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®