From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751697AbdEPJqw (ORCPT ); Tue, 16 May 2017 05:46:52 -0400 Received: from mout.web.de ([212.227.17.12]:53997 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751080AbdEPJqt (ORCPT ); Tue, 16 May 2017 05:46:49 -0400 To: linux-pwm@vger.kernel.org, Thierry Reding Cc: LKML , kernel-janitors@vger.kernel.org, Wolfram Sang From: SF Markus Elfring Subject: [PATCH] pwm-bfin: Delete an error message for a failed memory allocation in bfin_pwm_probe() Message-ID: <98188bf2-25b4-b784-6d98-21d51ba5c432@users.sourceforge.net> Date: Tue, 16 May 2017 11:46:37 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:ckY0szYuDFWajuj32KCuMHahkSrtU3EhQvlIC3rQHgfNx0CvU6r VIGbDQYMHq+PU264Vs+qeThiLie3gYkAwSOd4zy0aw8DNY+txDSYSLkA7rOktPPp6g/VqeH XuAWXwOiaYbTIY0TLTbNbw6XXBpwQTpcZ1TV22Lxh8tKWQ5VNToAqB9cckHBji+DTF4V1J6 KeUV02tTu4+XZscEGthcw== X-UI-Out-Filterresults: notjunk:1;V01:K0:yOTriEeHKr0=:UC3RUihqIHbkv132MuK3MI ZeH47oPQytTWLebY2LrJ+C1ELyXeOBncno664dwxl29xqg2dhXgmyMisQE71ASD+4RyMim5kM I5OIT8vz/PpbR8KAryCo9uEfk/FxLiC4RCZumDMYmEQ88yQPm5M6UevhbjiS2eAQmZzYPPLb6 ZB01ZM1bpCBU8M0EIjcn4UlfbXnevy1k0Mv8hXNKN8MoP6BaE5cy9Aj/fI9k9JEKWNMzThKAt pkMweosQ+7NqVq1H25rgW6eaJc8Ldh8xUCPBdQwpgc9Wj5i+4IfypHSOnX1RL4uOmNkxPQQiy aiIV7H0SuwAE8jaZURdBzr9n3iCXyuBu/UZvbW0TeuRD8/ZjVNGNXsbEaNmPyzuvgusEeWD5i 964JTXGthBCczkaBQRE8BKud+LWnylzm/dyiaxMDPauJrCb4zBRbtfgiXJgbqQyW2b6QOgscD xVzn6r4xTSYfKeVnTGZDN4735cm1Ktz3mfwibn9zmxWsW/P63CzVCBLTH5Vs+L6dQ9XWSKNQ3 IyVu/wQU01W9nU5Xks0Dm8+QSdBgPAGyClX5tMbL4wxAOyfMsy/oWGqFxr1JwMnkt6xmy6MpT PhC91dEQCcXbMHfZ9WZ5IJm7gWfYhK4zv/YHJRBQClvxeUbyLRHdsnmmdKMRC1jxsdOHyGJdQ 2uL4wnztQzLKOMBP0fz3H0uuKGePWDtCSJZAQ4wPrDxOJNZMzSFtKqoEbaQg75vio/afSKAM/ 0NlcLAeyNvfFGJ07bzuZgYBNv+eJUch2ERPreXU7KPvPdSJQ+yNVwky3K95KgKTvEaYPhweqJ qYciBD5 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Tue, 16 May 2017 11:40:09 +0200 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf Signed-off-by: Markus Elfring --- drivers/pwm/pwm-bfin.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/pwm/pwm-bfin.c b/drivers/pwm/pwm-bfin.c index d2ed0a2a18e8..a9a88137f2cb 100644 --- a/drivers/pwm/pwm-bfin.c +++ b/drivers/pwm/pwm-bfin.c @@ -118,10 +118,8 @@ static int bfin_pwm_probe(struct platform_device *pdev) int ret; pwm = devm_kzalloc(&pdev->dev, sizeof(*pwm), GFP_KERNEL); - if (!pwm) { - dev_err(&pdev->dev, "failed to allocate memory\n"); + if (!pwm) return -ENOMEM; - } platform_set_drvdata(pdev, pwm); -- 2.13.0