From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Tengfei Fan <quic_tengfan@quicinc.com>,
andersson@kernel.org, konrad.dybcio@linaro.org,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
conor+dt@kernel.org
Cc: quic_tsoni@quicinc.com, quic_shashim@quicinc.com,
quic_kaushalk@quicinc.com, quic_tdas@quicinc.com,
quic_tingweiz@quicinc.com, quic_aiquny@quicinc.com,
kernel@quicinc.com, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 5/8] dt-bindings: arm: qcom,ids: Adjust the position of QCOM_ID_QDU1010
Date: Mon, 31 Jul 2023 09:00:16 +0200 [thread overview]
Message-ID: <981a79ee-5258-eb76-020a-765f5f39866f@linaro.org> (raw)
In-Reply-To: <20230731061325.26431-6-quic_tengfan@quicinc.com>
On 31/07/2023 08:13, Tengfei Fan wrote:
> Adjust the position of QCOM_ID_QDU1010, so that there is a coherent
> sequence of numbers.
>
> Change-Id: Id083e1ecc92c063c1a07a81c66dcb034020964b0
Please run scripts/checkpatch.pl and fix reported warnings. Some
warnings can be ignored, but the code here looks like it needs a fix.
Feel free to get in touch if the warning is not clear.
> ---
> include/dt-bindings/arm/qcom,ids.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/dt-bindings/arm/qcom,ids.h b/include/dt-bindings/arm/qcom,ids.h
> index bcbe9ee2cdaf..977c235ed0d9 100644
> --- a/include/dt-bindings/arm/qcom,ids.h
> +++ b/include/dt-bindings/arm/qcom,ids.h
> @@ -249,8 +249,8 @@
> #define QCOM_ID_SA8775P 534
> #define QCOM_ID_QRU1000 539
> #define QCOM_ID_QDU1000 545
> -#define QCOM_ID_QDU1010 587
> #define QCOM_ID_IPQ5019 569
I don't think this change is needed. Isn't IPQ5019 going away?
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-07-31 7:00 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-31 6:13 [PATCH v3 0/8] soc: qcom: Add support for SM4450 Tengfei Fan
2023-07-31 6:13 ` [PATCH v3 1/8] dt-bindings: qcom,pdc: add qcom,sm4450-pdc compatible Tengfei Fan
2023-07-31 6:13 ` [PATCH v3 2/8] dt-bindings: arm: qcom: Document SM4450 SoC and boards Tengfei Fan
2023-07-31 6:13 ` [PATCH v3 3/8] arm64: dts: qcom: Adds base SM4450 DTSI Tengfei Fan
2023-07-31 6:13 ` [PATCH v3 4/8] arm64: dts: qcom: Add base SM4450 QRD DTS Tengfei Fan
2023-07-31 6:59 ` Krzysztof Kozlowski
2023-07-31 6:13 ` [PATCH v3 5/8] dt-bindings: arm: qcom,ids: Adjust the position of QCOM_ID_QDU1010 Tengfei Fan
2023-07-31 7:00 ` Krzysztof Kozlowski [this message]
2023-07-31 7:21 ` Tengfei Fan
2023-07-31 8:02 ` Krzysztof Kozlowski
2023-07-31 8:07 ` Tengfei Fan
2023-07-31 6:13 ` [PATCH v3 6/8] soc: qcom: socinfo: adjust the position of QDU1010 Tengfei Fan
2023-07-31 7:00 ` Krzysztof Kozlowski
2023-07-31 7:22 ` Tengfei Fan
2023-07-31 6:13 ` [PATCH v3 7/8] dt-bindings: arm: qcom,ids: add SoC ID for SM4450 Tengfei Fan
2023-07-31 6:13 ` [PATCH v3 8/8] soc: qcom: socinfo: add SM4450 ID Tengfei Fan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=981a79ee-5258-eb76-020a-765f5f39866f@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kernel@quicinc.com \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_aiquny@quicinc.com \
--cc=quic_kaushalk@quicinc.com \
--cc=quic_shashim@quicinc.com \
--cc=quic_tdas@quicinc.com \
--cc=quic_tengfan@quicinc.com \
--cc=quic_tingweiz@quicinc.com \
--cc=quic_tsoni@quicinc.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®