From: Paolo Abeni <pabeni@redhat.com>
To: Michal Luczaj <mhal@rbox.co>,
Stefano Garzarella <sgarzare@redhat.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Simon Horman <horms@kernel.org>,
"Michael S. Tsirkin" <mst@redhat.com>,
Bobby Eshleman <bobby.eshleman@bytedance.com>,
Andrii Nakryiko <andrii@kernel.org>,
Eduard Zingerman <eddyz87@gmail.com>,
Mykola Lysenko <mykolal@fb.com>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Martin KaFai Lau <martin.lau@linux.dev>,
Song Liu <song@kernel.org>,
Yonghong Song <yonghong.song@linux.dev>,
John Fastabend <john.fastabend@gmail.com>,
KP Singh <kpsingh@kernel.org>,
Stanislav Fomichev <sdf@fomichev.me>, Hao Luo <haoluo@google.com>,
Jiri Olsa <jolsa@kernel.org>, Shuah Khan <shuah@kernel.org>
Cc: netdev@vger.kernel.org, bpf@vger.kernel.org,
virtualization@lists.linux.dev, linux-kernel@vger.kernel.org,
linux-kselftest@vger.kernel.org
Subject: Re: [PATCH net v3 2/3] selftest/bpf: Add test for AF_VSOCK connect() racing sockmap update
Date: Mon, 17 Mar 2025 09:23:42 +0100 [thread overview]
Message-ID: <981a871f-e0c0-4741-8e7e-4a4e5d93541d@redhat.com> (raw)
In-Reply-To: <20250316-vsock-trans-signal-race-v3-2-17a6862277c9@rbox.co>
On 3/16/25 11:45 PM, Michal Luczaj wrote:
> Racing signal-interrupted connect() and sockmap update may result in an
> unconnected (and missing vsock transport) socket in a sockmap.
>
> Test spends 2 seconds attempting to reach WARN_ON_ONCE().
>
> connect
> / state = SS_CONNECTED /
> sock_map_update_elem
> if signal_pending
> state = SS_UNCONNECTED
>
> connect
> transport = NULL
> vsock_bpf_recvmsg
> WARN_ON_ONCE(!vsk->transport)
>
> Signed-off-by: Michal Luczaj <mhal@rbox.co>
This is apparently causing some bpf self-test failure. (Timeout? the
self-test failure output is not clear to me.)
Could you please have a look?
Thanks!
Paolo
next prev parent reply other threads:[~2025-03-17 8:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-16 22:45 [PATCH net v3 0/3] vsock/bpf: Handle races between sockmap update and connect() disconnecting Michal Luczaj
2025-03-16 22:45 ` [PATCH net v3 1/3] vsock/bpf: Fix EINTR connect() racing sockmap update Michal Luczaj
2025-03-16 22:45 ` [PATCH net v3 2/3] selftest/bpf: Add test for AF_VSOCK " Michal Luczaj
2025-03-17 8:23 ` Paolo Abeni [this message]
2025-03-17 9:51 ` Michal Luczaj
2025-03-16 22:45 ` [PATCH net v3 3/3] vsock/bpf: Fix bpf recvmsg() racing transport reassignment Michal Luczaj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=981a871f-e0c0-4741-8e7e-4a4e5d93541d@redhat.com \
--to=pabeni@redhat.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bobby.eshleman@bytedance.com \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=eddyz87@gmail.com \
--cc=edumazet@google.com \
--cc=haoluo@google.com \
--cc=horms@kernel.org \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kpsingh@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=martin.lau@linux.dev \
--cc=mhal@rbox.co \
--cc=mst@redhat.com \
--cc=mykolal@fb.com \
--cc=netdev@vger.kernel.org \
--cc=sdf@fomichev.me \
--cc=sgarzare@redhat.com \
--cc=shuah@kernel.org \
--cc=song@kernel.org \
--cc=virtualization@lists.linux.dev \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®