From: Grygorii Strashko <grygorii.strashko@ti.com>
To: Florian Fainelli <f.fainelli@gmail.com>,
Kishon Vijay Abraham I <kishon@ti.com>
Cc: <netdev@vger.kernel.org>, Sekhar Nori <nsekhar@ti.com>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] phy: ti: gmii-sel: fix mac tx internal delay for rgmii-rxid
Date: Thu, 24 Oct 2019 08:42:33 +0300 [thread overview]
Message-ID: <98235ce5-a86b-46be-c390-18bbbfd1df03@ti.com> (raw)
In-Reply-To: <45a6ffd4-c0bd-1845-cb71-9adbafde2dd8@gmail.com>
On 24/10/2019 05:41, Florian Fainelli wrote:
>
>
> On 10/23/2019 7:47 AM, Grygorii Strashko wrote:
>> Now phy-gmii-sel will disable MAC TX internal delay for PHY interface mode
>> "rgmii-rxid" which is incorrect.
>> Hence, fix it by enabling MAC TX internal delay in the case of "rgmii-rxid"
>> mode.
>>
>> Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
>
> Should this have a:
>
> Fixes: 92b58b34741f ("phy: ti: introduce phy-gmii-sel driver")
>
Yes. it should.
Kishon, would you like me to re-submit or can you fix while applying?
--
Best regards,
grygorii
next prev parent reply other threads:[~2019-10-24 5:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-23 14:47 Grygorii Strashko
2019-10-24 2:41 ` Florian Fainelli
2019-10-24 5:42 ` Grygorii Strashko [this message]
2019-10-24 6:00 ` Kishon Vijay Abraham I
2019-10-25 11:39 ` Kishon Vijay Abraham I
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=98235ce5-a86b-46be-c390-18bbbfd1df03@ti.com \
--to=grygorii.strashko@ti.com \
--cc=f.fainelli@gmail.com \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nsekhar@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®