From: Marek Vasut <marex@denx.de>
To: Mingwei Zheng <zmw12306@gmail.com>
Cc: linus.walleij@linaro.org, mcoquelin.stm32@gmail.com,
alexandre.torgue@foss.st.com, make24@iscas.ac.cn,
peng.fan@nxp.com, fabien.dessenne@foss.st.com,
linux-gpio@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Jiasheng Jiang <jiashengjiangcool@gmail.com>
Subject: Re: [PATCH v3] pinctrl: stm32: Add check for clk_enable()
Date: Sat, 7 Dec 2024 12:42:44 +0100 [thread overview]
Message-ID: <9830993d-943b-4079-b31d-7c77ee83d306@denx.de> (raw)
In-Reply-To: <20241206214315.3385033-1-zmw12306@gmail.com>
On 12/6/24 10:43 PM, Mingwei Zheng wrote:
[...]
> @@ -1646,8 +1645,8 @@ int stm32_pctl_probe(struct platform_device *pdev)
> if (ret) {
> fwnode_handle_put(child);
>
> - for (i = 0; i < pctl->nbanks; i++)
> - clk_disable_unprepare(pctl->banks[i].clk);
> + clk_bulk_disable(pctl->nbanks, pctl->clks);
> + clk_bulk_unprepare(pctl->nbanks, pctl->clks);
Use clk_bulk_disable_unprepare()
include/linux/clk.h:static inline void clk_bulk_disable_unprepare(int
num_clks,
It looks pretty good otherwise, thanks !
next prev parent reply other threads:[~2024-12-07 13:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-06 21:43 Mingwei Zheng
2024-12-07 11:42 ` Marek Vasut [this message]
2024-12-13 1:13 ` Mingwei Zheng
2024-12-07 14:23 ` [Linux-stm32] " Antonio Borneo
2024-12-13 1:11 ` Mingwei Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9830993d-943b-4079-b31d-7c77ee83d306@denx.de \
--to=marex@denx.de \
--cc=alexandre.torgue@foss.st.com \
--cc=fabien.dessenne@foss.st.com \
--cc=jiashengjiangcool@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=make24@iscas.ac.cn \
--cc=mcoquelin.stm32@gmail.com \
--cc=peng.fan@nxp.com \
--cc=zmw12306@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®