From: Waiman Long <longman@redhat.com>
To: yongli-os <yongli-oc@zhaoxin.com>,
peterz@infradead.org, mingo@redhat.com, will@kernel.org,
boqun.feng@gmail.com
Cc: linux-kernel@vger.kernel.org, yongli@zhaoxin.com,
louisqi@zhaoxin.com, cobechen@zhaoxin.com,
jiangbowang@zhaoxin.com
Subject: Re: [PATCH 4/4] locking/osq_lock: The numa-aware lock memory prepare, assign and cleanup.
Date: Thu, 19 Sep 2024 07:28:00 -0400 [thread overview]
Message-ID: <9836c30e-4ee1-485a-83f2-b38630dd7c21@redhat.com> (raw)
In-Reply-To: <1d9b40ac-f5d8-4242-bb12-92b7a50a3d05@zhaoxin.com>
On 9/19/24 05:41, yongli-os wrote:
> BTW, your patch series lacks performance data to justify the addition of
>
>> quite a lot of complexity to the core locking code. We are unlikely to
>> take this without sufficient justification.
>>
> In the cover letter, these is performance test result for AMD EPYC
> 7551 and
>
> Zhaoxin KH40000. I listed the perf epoll, locktorture mutex, unixbench
> and fxmark.
>
> What test do you think is important for the Lock performance?
>
> I will do more test in next submission.
Ah, I was not sent to/cc on the cover-letter. I only got your patches
1-4. Yes, you did sent out a cover letter with some performance numbers
after checking the LKML list. I will take a closer look at these
performance numbers later as I am attending the LPC conference this week.
Cheers,
Longman
next prev parent reply other threads:[~2024-09-19 11:28 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-14 8:53 [PATCH 0/4] locking/osq_lock: Update osq_lock to dynamic yongli-oc
2024-09-14 8:53 ` [PATCH 1/4] locking/osq_lock: The Kconfig for dynamic numa-aware osq lock yongli-oc
2024-09-14 8:53 ` [PATCH 2/4] locking/osq_lock: Turn to dynamic switch function from osq_lock/unlock yongli-oc
2024-09-14 16:06 ` Waiman Long
2024-09-19 9:32 ` yongli-os
2024-09-14 8:53 ` [PATCH 3/4] locking/osq_lock: From x_osq_lock/unlock to numa-aware lock/unlock yongli-oc
2024-09-14 17:11 ` Waiman Long
2024-09-19 9:35 ` yongli-os
2024-09-15 18:44 ` Uros Bizjak
2024-09-15 21:06 ` Waiman Long
2024-09-14 8:53 ` [PATCH 4/4] locking/osq_lock: The numa-aware lock memory prepare, assign and cleanup yongli-oc
2024-09-14 17:21 ` Waiman Long
2024-09-19 9:41 ` yongli-os
2024-09-19 11:28 ` Waiman Long [this message]
2024-09-15 16:43 ` kernel test robot
2024-09-30 7:23 ` [PATCH v2 0/3] locking/osq_lock: Update osq_lock to dynamic yongli-oc
2024-09-30 7:23 ` [PATCH v2 1/3] locking/osq_lock: The Kconfig for dynamic numa-aware osq lock yongli-oc
2024-09-30 7:23 ` [PATCH v2 2/3] locking/osq_lock: Define osq by union to support dynamic numa-aware lock yongli-oc
2024-09-30 7:23 ` [PATCH v2 3/3] locking/osq_lock: Turn from 2-byte osq_lock/unlock to numa lock/unlock yongli-oc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9836c30e-4ee1-485a-83f2-b38630dd7c21@redhat.com \
--to=longman@redhat.com \
--cc=boqun.feng@gmail.com \
--cc=cobechen@zhaoxin.com \
--cc=jiangbowang@zhaoxin.com \
--cc=linux-kernel@vger.kernel.org \
--cc=louisqi@zhaoxin.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=will@kernel.org \
--cc=yongli-oc@zhaoxin.com \
--cc=yongli@zhaoxin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®