From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83E89C4346E for ; Sun, 27 Sep 2020 17:45:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3B89523976 for ; Sun, 27 Sep 2020 17:45:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726458AbgI0Rpu (ORCPT ); Sun, 27 Sep 2020 13:45:50 -0400 Received: from smtprelay0221.hostedemail.com ([216.40.44.221]:60032 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726267AbgI0Rpu (ORCPT ); Sun, 27 Sep 2020 13:45:50 -0400 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay02.hostedemail.com (Postfix) with ESMTP id 7921C1730858; Sun, 27 Sep 2020 17:45:48 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: cry47_3d0f42d2717a X-Filterd-Recvd-Size: 3344 Received: from XPS-9350.home (unknown [47.151.133.149]) (Authenticated sender: joe@perches.com) by omf10.hostedemail.com (Postfix) with ESMTPA; Sun, 27 Sep 2020 17:45:46 +0000 (UTC) Message-ID: <983c49ebe4bbe0435a73d25cd8525764a4f8adac.camel@perches.com> Subject: Re: [Cocci] coccinelle: Convert comma to semicolons (was Re: [PATCH] checkpatch: Add test for comma use that should be semicolon) From: Joe Perches To: Julia Lawall Cc: Thomas Gleixner , Valdis =?UTF-8?Q?Kl=C4=93tnieks?= , kernel-janitors , kernelnewbies , linux-kernel-mentees@lists.linuxfoundation.org, Andrew Morton , cocci , Giuseppe Scrivano , LKML , Andy Whitcroft , lkp , "Gustavo A. R. Silva" Date: Sun, 27 Sep 2020 10:45:45 -0700 In-Reply-To: References: <87r1qqvo2d.fsf@nanos.tec.linutronix.de> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.36.4-0ubuntu1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 2020-09-27 at 19:08 +0200, Julia Lawall wrote: > I end up with 208 patches. I'm not sure that sending them all at once > would be a good idea... Last I looked the diffstat for comma -> semicolon was: 234 files changed, 509 insertions(+), 509 deletions(-) So it would be nearly 1 patch per individual file, Greg KH does send hundreds of patches for -stable at a time. So, maybe or maybe not send them all at once. Maybe send it in batches of 25 or so. There's no single right way to do this. Maybe put up a git tree somewhere and let the kernel-robot test compilation. (A nicety might be for the kernel-robot to have some option to test pre and post compilation object code differences with an optional report) When I automated 491 patches for /* fallthrough */ to fallthrough;, the robot caught a couple problems which was great. https://repo.or.cz/linux-2.6/trivial-mods.git/shortlog/refs/heads/20200310_fallthrough_2 I only posted the first ~30 patches though with about 50% acceptance. Gustavo Silva picked up the effort and did a great job. Eventually, a single treewide patch was posted and accepted by Linus for this though after dozens of individual patches went through various maintainer trees: $ git log --shortstat -1 df561f6688fe commit df561f6688fef775baa341a0f5d960becd248b11 Author: Gustavo A. R. Silva Date: Sun Aug 23 17:36:59 2020 -0500 treewide: Use fallthrough pseudo-keyword Replace the existing /* fall through */ comments and its variants with the new pseudo-keyword macro fallthrough[1]. Also, remove unnecessary fall-through markings when it is the case. [1] https://www.kernel.org/doc/html/v5.7/process/deprecated.html?highlight=> Signed-off-by: Gustavo A. R. Silva 1148 files changed, 2667 insertions(+), 2737 deletions(-)